* [PATCH i-g-t v5 1/4] test/xe_pm: Add exit handler to close fw handle
2024-01-19 11:55 [PATCH i-g-t v5 0/4] Add d3 mmap test Anshuman Gupta
@ 2024-01-19 11:55 ` Anshuman Gupta
2024-01-19 11:55 ` [PATCH i-g-t v5 2/4] lib/igt_pm: Add helper to get/set auto_suspenddelay_ms Anshuman Gupta
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Anshuman Gupta @ 2024-01-19 11:55 UTC (permalink / raw)
To: igt-dev; +Cc: kamil.konieczny, rodrigo.vivi
Adding an exit handler to close the fw handle to make sure we don't
leak the fw in CI environment. Adding a IGT subtest group for the
test using the fw handle to runtime wake the device.
Scaling forcewake close exit handler for vram-d3cold-threshold
subtest, while doing so add the missing subtest Functionality
as well.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
tests/intel/xe_pm.c | 34 +++++++++++++++++++++++++---------
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c
index 4afe37d93..f793fd24e 100644
--- a/tests/intel/xe_pm.c
+++ b/tests/intel/xe_pm.c
@@ -40,6 +40,7 @@ typedef struct {
} device_t;
uint64_t orig_threshold;
+int fw_handle = -1;
static void dpms_on_off(device_t device, int mode)
{
@@ -195,6 +196,14 @@ static bool out_of_d3(device_t device, enum igt_acpi_d_state state)
return true;
}
+static void close_fw_handle(int sig)
+{
+ if (fw_handle < 0)
+ return;
+
+ close(fw_handle);
+}
+
/**
* SUBTEST: %s-basic
* Description: set GPU state to %arg[1] and test suspend/autoresume
@@ -411,9 +420,9 @@ static void test_vram_d3cold_threshold(device_t device, int sysfs_fd)
};
uint64_t vram_used_mb = 0, vram_total_mb = 0, threshold;
uint32_t bo, placement;
- int handle, i;
bool active;
void *map;
+ int i;
igt_require(xe_has_vram(device.fd_xe));
@@ -457,10 +466,10 @@ static void test_vram_d3cold_threshold(device_t device, int sysfs_fd)
* the device from runtime suspend.
* Therefore open and close fw handle to wake the device.
*/
- handle = igt_debugfs_open(device.fd_xe, "forcewake_all", O_RDONLY);
- igt_assert(handle >= 0);
+ fw_handle = igt_debugfs_open(device.fd_xe, "forcewake_all", O_RDONLY);
+ igt_assert(fw_handle >= 0);
active = igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE;
- close(handle);
+ close(fw_handle);
igt_assert(active);
/* Test D3Cold again after freeing up the Xe BO */
@@ -570,11 +579,18 @@ igt_main
}
}
- igt_describe("Validate whether card is limited to d3hot, if vram used > vram threshold");
- igt_subtest("vram-d3cold-threshold") {
- orig_threshold = get_vram_d3cold_threshold(sysfs_fd);
- igt_install_exit_handler(vram_d3cold_threshold_restore);
- test_vram_d3cold_threshold(device, sysfs_fd);
+ igt_subtest_group {
+ igt_fixture {
+ igt_install_exit_handler(close_fw_handle);
+ }
+
+ igt_describe("Validate whether card is limited to d3hot,"
+ "if vram used > vram threshold");
+ igt_subtest("vram-d3cold-threshold") {
+ orig_threshold = get_vram_d3cold_threshold(sysfs_fd);
+ igt_install_exit_handler(vram_d3cold_threshold_restore);
+ test_vram_d3cold_threshold(device, sysfs_fd);
+ }
}
igt_fixture {
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH i-g-t v5 2/4] lib/igt_pm: Add helper to get/set auto_suspenddelay_ms
2024-01-19 11:55 [PATCH i-g-t v5 0/4] Add d3 mmap test Anshuman Gupta
2024-01-19 11:55 ` [PATCH i-g-t v5 1/4] test/xe_pm: Add exit handler to close fw handle Anshuman Gupta
@ 2024-01-19 11:55 ` Anshuman Gupta
2024-01-19 11:55 ` [PATCH i-g-t v5 3/4] tests/xe_pm: Add d3-mmap IGT test Anshuman Gupta
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Anshuman Gupta @ 2024-01-19 11:55 UTC (permalink / raw)
To: igt-dev; +Cc: kamil.konieczny, rodrigo.vivi
Sometimes we want to test pm igt test with an explicit auto
suspend delay, therefore adding helpers to get/set the pci_dev
auto_suspenddelay_ms.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
lib/igt_pm.c | 53 ++++++++++++++++++++++++++++++++++++++++------------
lib/igt_pm.h | 2 ++
2 files changed, 43 insertions(+), 12 deletions(-)
diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index c2d98fceb..d436c2c50 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -1068,18 +1068,6 @@ static void igt_pm_write_power_attr(int fd, const char *val, int len)
igt_assert(strncmp(buf, val, len) == 0);
}
-static int igt_pm_get_autosuspend_delay(struct pci_device *pci_dev)
-{
- char delay_str[64];
- int delay, delay_fd;
-
- delay_fd = igt_pm_get_power_attr_fd(pci_dev, "autosuspend_delay_ms");
- if (igt_pm_read_power_attr(delay_fd, delay_str, 64, true))
- igt_assert(sscanf(delay_str, "%d", &delay) > 0);
-
- return delay;
-}
-
static void
igt_pm_setup_pci_dev_power_attrs(struct pci_device *pci_dev,
struct igt_pm_pci_dev_pwrattr *pwrattr, int delay_ms)
@@ -1165,6 +1153,47 @@ igt_pm_setup_pci_card_power_attrs(struct pci_device *pci_dev, bool save_attrs, i
pci_iterator_destroy(iter);
}
+/**
+ * igt_pm_get_autosuspend_delay:
+ * @pci_dev: pci_dev.
+ * Get pci_dev autosuspend delay value from pci sysfs "autosuspend_delay_ms".
+ *
+ * Returns:
+ * autosuspend_delay_ms.
+ */
+int igt_pm_get_autosuspend_delay(struct pci_device *pci_dev)
+{
+ char delay_str[64];
+ int delay, delay_fd;
+
+ delay_fd = igt_pm_get_power_attr_fd(pci_dev, "autosuspend_delay_ms");
+ if (igt_pm_read_power_attr(delay_fd, delay_str, 64, true))
+ igt_assert(sscanf(delay_str, "%d", &delay) > 0);
+
+ return delay;
+}
+
+/**
+ * igt_pm_set_autosuspend_delay:
+ * @pci_dev: pci_dev.
+ * @delay_ms: autosuspend delay in ms.
+ * Set pci_dev autosuspend delay value through pci sysfs "autosuspend_delay_ms".
+ */
+void igt_pm_set_autosuspend_delay(struct pci_device *pci_dev, int delay_ms)
+{
+ char delay_str[64];
+ int delay_fd;
+
+ delay_fd = igt_pm_get_power_attr_fd(pci_dev, "autosuspend_delay_ms");
+
+ if (delay_ms >= 0) {
+ int wc;
+
+ wc = snprintf(delay_str, 64, "%d\n", delay_ms);
+ igt_pm_write_power_attr(delay_fd, delay_str, wc);
+ }
+}
+
/**
* igt_pm_enable_pci_card_runtime_pm:
* @root: root port pci_dev.
diff --git a/lib/igt_pm.h b/lib/igt_pm.h
index 306a9eb46..8394315c6 100644
--- a/lib/igt_pm.h
+++ b/lib/igt_pm.h
@@ -77,6 +77,8 @@ int igt_pm_get_pcie_acpihp_slot(struct pci_device *pci_dev);
bool igt_pm_acpi_d3cold_supported(struct pci_device *pci_dev);
enum igt_acpi_d_state
igt_pm_get_acpi_real_d_state(struct pci_device *pci_dev);
+int igt_pm_get_autosuspend_delay(struct pci_device *pci_dev);
+void igt_pm_set_autosuspend_delay(struct pci_device *pci_dev, int delay_ms);
void igt_pm_enable_pci_card_runtime_pm(struct pci_device *root,
struct pci_device *i915);
void igt_pm_get_d3cold_allowed(const char *pci_slot_name, uint32_t *value);
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH i-g-t v5 3/4] tests/xe_pm: Add d3-mmap IGT test
2024-01-19 11:55 [PATCH i-g-t v5 0/4] Add d3 mmap test Anshuman Gupta
2024-01-19 11:55 ` [PATCH i-g-t v5 1/4] test/xe_pm: Add exit handler to close fw handle Anshuman Gupta
2024-01-19 11:55 ` [PATCH i-g-t v5 2/4] lib/igt_pm: Add helper to get/set auto_suspenddelay_ms Anshuman Gupta
@ 2024-01-19 11:55 ` Anshuman Gupta
2024-01-19 11:55 ` [PATCH i-g-t v5 4/4] HAX: Add d3-mmap to xe-fast-feedback Anshuman Gupta
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Anshuman Gupta @ 2024-01-19 11:55 UTC (permalink / raw)
To: igt-dev; +Cc: kamil.konieczny, rodrigo.vivi
Adding a test to validate mmap memory mappings along with runtime
suspend and resume for both xe device and it's pci parent bridge
in device hierarchy.
v2:
- Use 0xc00fee pattern. [Rodrigo]
- Test the pagefault case on read and write the mapping. [Rodrigo]
v3:
- Cosmetic comment. [Kamil]
- Use MAGIC macro for 0xc0ffe and 0xdeadbeef. [Kamil]
- Fix xe_bo_create() with respect to Xe uapi.
- Set auto_suspend delay to 1000ms and restore it.
v4:
- Set autosuspend delay to 1 sec for entire test. [Badal]
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
tests/intel/xe_pm.c | 99 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c
index f793fd24e..9cb25d47c 100644
--- a/tests/intel/xe_pm.c
+++ b/tests/intel/xe_pm.c
@@ -30,6 +30,8 @@
#define NO_RPM -1
#define SIZE (4096 * 1024)
+#define MAGIC_1 0xc0ffee
+#define MAGIC_2 0xdeadbeef
typedef struct {
int fd_xe;
@@ -476,6 +478,79 @@ static void test_vram_d3cold_threshold(device_t device, int sysfs_fd)
igt_assert(in_d3(device, IGT_ACPI_D3Cold));
}
+/**
+ * SUBTEST: d3-mmap-%s
+ * Description:
+ * Validate mmap memory mapping with d3 state, for %arg[1] region,
+ * if supported by device.
+ * arg[1]:
+ *
+ * @vram: vram region
+ * @system: system region
+ *
+ * Functionality: pm-d3
+ * Run type: FULL
+ */
+static void test_mmap(device_t device, uint32_t placement, uint32_t flags)
+{
+ size_t bo_size = 8192;
+ uint32_t *map = NULL;
+ uint32_t bo;
+ int i;
+
+ igt_require_f(placement, "Device doesn't support such memory region\n");
+
+ bo_size = ALIGN(bo_size, xe_get_default_alignment(device.fd_xe));
+
+ bo = xe_bo_create(device.fd_xe, 0, bo_size, placement, flags);
+ map = xe_bo_map(device.fd_xe, bo, bo_size);
+ igt_assert(map);
+ memset(map, 0, bo_size);
+
+ fw_handle = igt_debugfs_open(device.fd_xe, "forcewake_all", O_RDONLY);
+
+ igt_assert(fw_handle >= 0);
+ igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
+
+ for (i = 0; i < bo_size / sizeof(*map); i++)
+ map[i] = MAGIC_1;
+
+ for (i = 0; i < bo_size / sizeof(*map); i++)
+ igt_assert(map[i] == MAGIC_1);
+
+ /* Runtime suspend and validate the pattern and changed the pattern */
+ close(fw_handle);
+ igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+
+ for (i = 0; i < bo_size / sizeof(*map); i++)
+ igt_assert(map[i] == MAGIC_1);
+
+ /* dgfx page-fault on mmaping should wake the gpu */
+ if (xe_has_vram(device.fd_xe))
+ igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
+
+ igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+
+ for (i = 0; i < bo_size / sizeof(*map); i++)
+ map[i] = MAGIC_2;
+
+ if (xe_has_vram(device.fd_xe))
+ igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
+
+ igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+
+ /* Runtime resume and check the pattern */
+ fw_handle = igt_debugfs_open(device.fd_xe, "forcewake_all", O_RDONLY);
+ igt_assert(fw_handle >= 0);
+ igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
+ for (i = 0; i < bo_size / sizeof(*map); i++)
+ igt_assert(map[i] == MAGIC_2);
+
+ igt_assert(munmap(map, bo_size) == 0);
+ gem_close(device.fd_xe, bo);
+ close(fw_handle);
+}
+
igt_main
{
struct drm_xe_engine_class_instance *hwe;
@@ -591,6 +666,30 @@ igt_main
igt_install_exit_handler(vram_d3cold_threshold_restore);
test_vram_d3cold_threshold(device, sysfs_fd);
}
+
+ igt_describe("Validate mmap memory mappings with system region,"
+ "when device along with parent bridge in d3");
+ igt_subtest("d3-mmap-system") {
+ test_mmap(device, system_memory(device.fd_xe), 0);
+ }
+
+ igt_describe("Validate mmap memory mappings with vram region,"
+ "when device along with parent bridge in d3");
+ igt_subtest("d3-mmap-vram") {
+ int delay_ms;
+
+ if (device.pci_root != device.pci_xe) {
+ igt_pm_enable_pci_card_runtime_pm(device.pci_root, NULL);
+ igt_pm_set_d3cold_allowed(device.pci_slot_name, 1);
+ }
+
+ delay_ms = igt_pm_get_autosuspend_delay(device.pci_xe);
+
+ /* Give some auto suspend delay to validate rpm active during page fault */
+ igt_pm_set_autosuspend_delay(device.pci_xe, 1000);
+ test_mmap(device, vram_memory(device.fd_xe, 0), DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
+ igt_pm_set_autosuspend_delay(device.pci_xe, delay_ms);
+ }
}
igt_fixture {
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH i-g-t v5 4/4] HAX: Add d3-mmap to xe-fast-feedback
2024-01-19 11:55 [PATCH i-g-t v5 0/4] Add d3 mmap test Anshuman Gupta
` (2 preceding siblings ...)
2024-01-19 11:55 ` [PATCH i-g-t v5 3/4] tests/xe_pm: Add d3-mmap IGT test Anshuman Gupta
@ 2024-01-19 11:55 ` Anshuman Gupta
2024-01-19 12:46 ` ✗ CI.xeBAT: failure for Add d3 mmap test (rev3) Patchwork
2024-01-19 13:02 ` ✗ Fi.CI.BAT: " Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Anshuman Gupta @ 2024-01-19 11:55 UTC (permalink / raw)
To: igt-dev; +Cc: kamil.konieczny, rodrigo.vivi
Adding d3-mmap to xe-fast-feedback.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
tests/intel-ci/xe-fast-feedback.testlist | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index f297fe965..f35871dd1 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -115,6 +115,7 @@ igt@xe_mmap@system
igt@xe_mmap@vram
igt@xe_mmap@vram-system
igt@xe_pm_residency@gt-c6-on-idle
+igt@xe_pm@d3-mmap
igt@xe_prime_self_import@basic-with_one_bo
igt@xe_prime_self_import@basic-with_fd_dup
#igt@xe_prime_self_import@basic-llseek-size
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* ✗ CI.xeBAT: failure for Add d3 mmap test (rev3)
2024-01-19 11:55 [PATCH i-g-t v5 0/4] Add d3 mmap test Anshuman Gupta
` (3 preceding siblings ...)
2024-01-19 11:55 ` [PATCH i-g-t v5 4/4] HAX: Add d3-mmap to xe-fast-feedback Anshuman Gupta
@ 2024-01-19 12:46 ` Patchwork
2024-01-19 13:02 ` ✗ Fi.CI.BAT: " Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2024-01-19 12:46 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 2032 bytes --]
== Series Details ==
Series: Add d3 mmap test (rev3)
URL : https://patchwork.freedesktop.org/series/124115/
State : failure
== Summary ==
CI Bug Log - changes from XEIGT_7683_BAT -> XEIGTPW_10562_BAT
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with XEIGTPW_10562_BAT absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_10562_BAT, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in XEIGTPW_10562_BAT:
### IGT changes ###
#### Possible regressions ####
* igt@xe_pm@d3-mmap:
- bat-atsm-2: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10562/bat-atsm-2/igt@xe_pm@d3-mmap.html
- bat-adlp-7: NOTRUN -> [SKIP][2]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10562/bat-adlp-7/igt@xe_pm@d3-mmap.html
- bat-pvc-2: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10562/bat-pvc-2/igt@xe_pm@d3-mmap.html
- bat-dg2-oem2: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10562/bat-dg2-oem2/igt@xe_pm@d3-mmap.html
Build changes
-------------
* IGT: IGT_7683 -> IGTPW_10562
* Linux: xe-644-238e8655c184b7cf16731690b59da560641a07ad -> xe-652-ad8fc2d4a396b1123c48340004d8c35dd0320817
IGTPW_10562: 10562
IGT_7683: 7683
xe-644-238e8655c184b7cf16731690b59da560641a07ad: 238e8655c184b7cf16731690b59da560641a07ad
xe-652-ad8fc2d4a396b1123c48340004d8c35dd0320817: ad8fc2d4a396b1123c48340004d8c35dd0320817
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10562/index.html
[-- Attachment #2: Type: text/html, Size: 2648 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* ✗ Fi.CI.BAT: failure for Add d3 mmap test (rev3)
2024-01-19 11:55 [PATCH i-g-t v5 0/4] Add d3 mmap test Anshuman Gupta
` (4 preceding siblings ...)
2024-01-19 12:46 ` ✗ CI.xeBAT: failure for Add d3 mmap test (rev3) Patchwork
@ 2024-01-19 13:02 ` Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2024-01-19 13:02 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 14983 bytes --]
== Series Details ==
Series: Add d3 mmap test (rev3)
URL : https://patchwork.freedesktop.org/series/124115/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14145 -> IGTPW_10562
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_10562 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10562, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/index.html
Participating hosts (37 -> 37)
------------------------------
Additional (3): bat-dg2-8 bat-dg2-9 bat-mtlp-8
Missing (3): fi-bsw-n3050 fi-snb-2520m fi-pnv-d510
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_10562:
### IGT changes ###
#### Possible regressions ####
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-mtlp-6: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14145/bat-mtlp-6/igt@i915_suspend@basic-s2idle-without-i915.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-6/igt@i915_suspend@basic-s2idle-without-i915.html
Known issues
------------
Here are the changes found in IGTPW_10562 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-mtlp-8: NOTRUN -> [SKIP][3] ([i915#9318])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@debugfs_test@basic-hwmon.html
* igt@gem_exec_suspend@basic-s0@smem:
- bat-mtlp-6: [PASS][4] -> [FAIL][5] ([i915#10054]) +1 other test fail
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14145/bat-mtlp-6/igt@gem_exec_suspend@basic-s0@smem.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-6/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_lmem_swapping@verify-random:
- bat-mtlp-8: NOTRUN -> [SKIP][6] ([i915#4613]) +3 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-dg2-9: NOTRUN -> [SKIP][7] ([i915#4083])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@gem_mmap@basic.html
- bat-mtlp-8: NOTRUN -> [SKIP][8] ([i915#4083])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@gem_mmap@basic.html
- bat-dg2-8: NOTRUN -> [SKIP][9] ([i915#4083])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@gem_mmap@basic.html
* igt@gem_mmap_gtt@basic:
- bat-dg2-9: NOTRUN -> [SKIP][10] ([i915#4077]) +2 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@gem_mmap_gtt@basic.html
- bat-mtlp-8: NOTRUN -> [SKIP][11] ([i915#4077]) +2 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@gem_mmap_gtt@basic.html
- bat-dg2-8: NOTRUN -> [SKIP][12] ([i915#4077]) +2 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@gem_mmap_gtt@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-dg2-9: NOTRUN -> [SKIP][13] ([i915#4079]) +1 other test skip
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@gem_render_tiled_blits@basic.html
- bat-mtlp-8: NOTRUN -> [SKIP][14] ([i915#4079]) +1 other test skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg2-8: NOTRUN -> [SKIP][15] ([i915#4079]) +1 other test skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-dg2-9: NOTRUN -> [SKIP][16] ([i915#6621])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@i915_pm_rps@basic-api.html
- bat-mtlp-8: NOTRUN -> [SKIP][17] ([i915#6621])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@i915_pm_rps@basic-api.html
- bat-dg2-8: NOTRUN -> [SKIP][18] ([i915#6621])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@i915_pm_rps@basic-api.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-mtlp-8: NOTRUN -> [SKIP][19] ([i915#6645])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html
- bat-dg2-8: NOTRUN -> [SKIP][20] ([i915#6645])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-9: NOTRUN -> [SKIP][21] ([i915#5190])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
- bat-mtlp-8: NOTRUN -> [SKIP][22] ([i915#5190])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
- bat-dg2-8: NOTRUN -> [SKIP][23] ([i915#5190])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg2-9: NOTRUN -> [SKIP][24] ([i915#4215] / [i915#5190])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html
- bat-mtlp-8: NOTRUN -> [SKIP][25] ([i915#4212]) +8 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html
- bat-dg2-8: NOTRUN -> [SKIP][26] ([i915#4215] / [i915#5190])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@framebuffer-vs-set-tiling:
- bat-dg2-9: NOTRUN -> [SKIP][27] ([i915#4212]) +7 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
- bat-dg2-8: NOTRUN -> [SKIP][28] ([i915#4212]) +7 other tests skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-dg2-9: NOTRUN -> [SKIP][29] ([i915#4103] / [i915#4213]) +1 other test skip
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
- bat-mtlp-8: NOTRUN -> [SKIP][30] ([i915#4213]) +1 other test skip
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
- bat-dg2-8: NOTRUN -> [SKIP][31] ([i915#4103] / [i915#4213]) +1 other test skip
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- bat-mtlp-8: NOTRUN -> [SKIP][32] ([i915#3555] / [i915#3840] / [i915#9159])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg2-9: NOTRUN -> [SKIP][33] ([fdo#109285])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html
- bat-mtlp-8: NOTRUN -> [SKIP][34] ([fdo#109285])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@kms_force_connector_basic@force-load-detect.html
- bat-dg2-8: NOTRUN -> [SKIP][35] ([fdo#109285])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-9: NOTRUN -> [SKIP][36] ([i915#5274])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html
- bat-mtlp-8: NOTRUN -> [SKIP][37] ([i915#5274])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@kms_force_connector_basic@prune-stale-modes.html
- bat-dg2-8: NOTRUN -> [SKIP][38] ([i915#5274])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pm_backlight@basic-brightness:
- bat-dg2-8: NOTRUN -> [SKIP][39] ([i915#5354])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@kms_pm_backlight@basic-brightness.html
- bat-dg2-9: NOTRUN -> [SKIP][40] ([i915#5354])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg2-9: NOTRUN -> [SKIP][41] ([i915#3555])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html
- bat-mtlp-8: NOTRUN -> [SKIP][42] ([i915#3555] / [i915#8809])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@kms_setmode@basic-clone-single-crtc.html
- bat-dg2-8: NOTRUN -> [SKIP][43] ([i915#3555])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-dg2-9: NOTRUN -> [SKIP][44] ([i915#3708])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html
- bat-dg2-8: NOTRUN -> [SKIP][45] ([i915#3708])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-dg2-8: NOTRUN -> [SKIP][46] ([i915#3708] / [i915#4077]) +1 other test skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@prime_vgem@basic-fence-mmap.html
- bat-dg2-9: NOTRUN -> [SKIP][47] ([i915#3708] / [i915#4077]) +1 other test skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html
- bat-mtlp-8: NOTRUN -> [SKIP][48] ([i915#3708] / [i915#4077]) +1 other test skip
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-fence-read:
- bat-mtlp-8: NOTRUN -> [SKIP][49] ([i915#3708]) +2 other tests skip
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-write:
- bat-dg2-9: NOTRUN -> [SKIP][50] ([i915#3291] / [i915#3708]) +2 other tests skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-9/igt@prime_vgem@basic-write.html
- bat-dg2-8: NOTRUN -> [SKIP][51] ([i915#3291] / [i915#3708]) +2 other tests skip
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-dg2-8/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- bat-jsl-3: [INCOMPLETE][52] ([i915#9883]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14145/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_pm_rpm@module-reload:
- bat-atsm-1: [SKIP][54] -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14145/bat-atsm-1/igt@i915_pm_rpm@module-reload.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-atsm-1/igt@i915_pm_rpm@module-reload.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-jsl-3: [FAIL][56] ([i915#10031]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14145/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#10031]: https://gitlab.freedesktop.org/drm/intel/issues/10031
[i915#10054]: https://gitlab.freedesktop.org/drm/intel/issues/10054
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
[i915#9159]: https://gitlab.freedesktop.org/drm/intel/issues/9159
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
[i915#9688]: https://gitlab.freedesktop.org/drm/intel/issues/9688
[i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732
[i915#9883]: https://gitlab.freedesktop.org/drm/intel/issues/9883
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7683 -> IGTPW_10562
CI-20190529: 20190529
CI_DRM_14145: ad8fc2d4a396b1123c48340004d8c35dd0320817 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10562: 10562
IGT_7683: 7683
Testlist changes
----------------
+igt@xe_pm@d3-mmap-system
+igt@xe_pm@d3-mmap-vram
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10562/index.html
[-- Attachment #2: Type: text/html, Size: 18669 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH i-g-t v5 3/4] tests/xe_pm: Add d3-mmap IGT test
2024-01-19 14:28 [PATCH i-g-t v5 0/4] Add d3 mmap test Anshuman Gupta
@ 2024-01-19 14:28 ` Anshuman Gupta
2024-01-19 15:33 ` Nilawar, Badal
0 siblings, 1 reply; 9+ messages in thread
From: Anshuman Gupta @ 2024-01-19 14:28 UTC (permalink / raw)
To: igt-dev; +Cc: Rodrigo Vivi
Adding a test to validate mmap memory mappings along with runtime
suspend and resume for both xe device and it's pci parent bridge
in device hierarchy.
v2:
- Use 0xc00fee pattern. [Rodrigo]
- Test the pagefault case on read and write the mapping. [Rodrigo]
v3:
- Cosmetic comment. [Kamil]
- Use MAGIC macro for 0xc0ffe and 0xdeadbeef. [Kamil]
- Fix xe_bo_create() with respect to Xe uapi.
- Set auto_suspend delay to 1000ms and restore it.
v4:
- Set autosuspend delay to 1 sec for entire test. [Badal]
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
tests/intel/xe_pm.c | 99 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c
index f793fd24e..9cb25d47c 100644
--- a/tests/intel/xe_pm.c
+++ b/tests/intel/xe_pm.c
@@ -30,6 +30,8 @@
#define NO_RPM -1
#define SIZE (4096 * 1024)
+#define MAGIC_1 0xc0ffee
+#define MAGIC_2 0xdeadbeef
typedef struct {
int fd_xe;
@@ -476,6 +478,79 @@ static void test_vram_d3cold_threshold(device_t device, int sysfs_fd)
igt_assert(in_d3(device, IGT_ACPI_D3Cold));
}
+/**
+ * SUBTEST: d3-mmap-%s
+ * Description:
+ * Validate mmap memory mapping with d3 state, for %arg[1] region,
+ * if supported by device.
+ * arg[1]:
+ *
+ * @vram: vram region
+ * @system: system region
+ *
+ * Functionality: pm-d3
+ * Run type: FULL
+ */
+static void test_mmap(device_t device, uint32_t placement, uint32_t flags)
+{
+ size_t bo_size = 8192;
+ uint32_t *map = NULL;
+ uint32_t bo;
+ int i;
+
+ igt_require_f(placement, "Device doesn't support such memory region\n");
+
+ bo_size = ALIGN(bo_size, xe_get_default_alignment(device.fd_xe));
+
+ bo = xe_bo_create(device.fd_xe, 0, bo_size, placement, flags);
+ map = xe_bo_map(device.fd_xe, bo, bo_size);
+ igt_assert(map);
+ memset(map, 0, bo_size);
+
+ fw_handle = igt_debugfs_open(device.fd_xe, "forcewake_all", O_RDONLY);
+
+ igt_assert(fw_handle >= 0);
+ igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
+
+ for (i = 0; i < bo_size / sizeof(*map); i++)
+ map[i] = MAGIC_1;
+
+ for (i = 0; i < bo_size / sizeof(*map); i++)
+ igt_assert(map[i] == MAGIC_1);
+
+ /* Runtime suspend and validate the pattern and changed the pattern */
+ close(fw_handle);
+ igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+
+ for (i = 0; i < bo_size / sizeof(*map); i++)
+ igt_assert(map[i] == MAGIC_1);
+
+ /* dgfx page-fault on mmaping should wake the gpu */
+ if (xe_has_vram(device.fd_xe))
+ igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
+
+ igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+
+ for (i = 0; i < bo_size / sizeof(*map); i++)
+ map[i] = MAGIC_2;
+
+ if (xe_has_vram(device.fd_xe))
+ igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
+
+ igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+
+ /* Runtime resume and check the pattern */
+ fw_handle = igt_debugfs_open(device.fd_xe, "forcewake_all", O_RDONLY);
+ igt_assert(fw_handle >= 0);
+ igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
+ for (i = 0; i < bo_size / sizeof(*map); i++)
+ igt_assert(map[i] == MAGIC_2);
+
+ igt_assert(munmap(map, bo_size) == 0);
+ gem_close(device.fd_xe, bo);
+ close(fw_handle);
+}
+
igt_main
{
struct drm_xe_engine_class_instance *hwe;
@@ -591,6 +666,30 @@ igt_main
igt_install_exit_handler(vram_d3cold_threshold_restore);
test_vram_d3cold_threshold(device, sysfs_fd);
}
+
+ igt_describe("Validate mmap memory mappings with system region,"
+ "when device along with parent bridge in d3");
+ igt_subtest("d3-mmap-system") {
+ test_mmap(device, system_memory(device.fd_xe), 0);
+ }
+
+ igt_describe("Validate mmap memory mappings with vram region,"
+ "when device along with parent bridge in d3");
+ igt_subtest("d3-mmap-vram") {
+ int delay_ms;
+
+ if (device.pci_root != device.pci_xe) {
+ igt_pm_enable_pci_card_runtime_pm(device.pci_root, NULL);
+ igt_pm_set_d3cold_allowed(device.pci_slot_name, 1);
+ }
+
+ delay_ms = igt_pm_get_autosuspend_delay(device.pci_xe);
+
+ /* Give some auto suspend delay to validate rpm active during page fault */
+ igt_pm_set_autosuspend_delay(device.pci_xe, 1000);
+ test_mmap(device, vram_memory(device.fd_xe, 0), DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
+ igt_pm_set_autosuspend_delay(device.pci_xe, delay_ms);
+ }
}
igt_fixture {
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH i-g-t v5 3/4] tests/xe_pm: Add d3-mmap IGT test
2024-01-19 14:28 ` [PATCH i-g-t v5 3/4] tests/xe_pm: Add d3-mmap IGT test Anshuman Gupta
@ 2024-01-19 15:33 ` Nilawar, Badal
0 siblings, 0 replies; 9+ messages in thread
From: Nilawar, Badal @ 2024-01-19 15:33 UTC (permalink / raw)
To: Anshuman Gupta, igt-dev; +Cc: Rodrigo Vivi
On 19-01-2024 19:58, Anshuman Gupta wrote:
> Adding a test to validate mmap memory mappings along with runtime
> suspend and resume for both xe device and it's pci parent bridge
> in device hierarchy.
>
> v2:
> - Use 0xc00fee pattern. [Rodrigo]
> - Test the pagefault case on read and write the mapping. [Rodrigo]
>
> v3:
> - Cosmetic comment. [Kamil]
> - Use MAGIC macro for 0xc0ffe and 0xdeadbeef. [Kamil]
> - Fix xe_bo_create() with respect to Xe uapi.
> - Set auto_suspend delay to 1000ms and restore it.
>
> v4:
> - Set autosuspend delay to 1 sec for entire test. [Badal]
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> tests/intel/xe_pm.c | 99 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 99 insertions(+)
>
> diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c
> index f793fd24e..9cb25d47c 100644
> --- a/tests/intel/xe_pm.c
> +++ b/tests/intel/xe_pm.c
> @@ -30,6 +30,8 @@
> #define NO_RPM -1
>
> #define SIZE (4096 * 1024)
> +#define MAGIC_1 0xc0ffee
> +#define MAGIC_2 0xdeadbeef
>
> typedef struct {
> int fd_xe;
> @@ -476,6 +478,79 @@ static void test_vram_d3cold_threshold(device_t device, int sysfs_fd)
> igt_assert(in_d3(device, IGT_ACPI_D3Cold));
> }
>
> +/**
> + * SUBTEST: d3-mmap-%s
> + * Description:
> + * Validate mmap memory mapping with d3 state, for %arg[1] region,
> + * if supported by device.
> + * arg[1]:
> + *
> + * @vram: vram region
> + * @system: system region
> + *
> + * Functionality: pm-d3
> + * Run type: FULL
> + */
> +static void test_mmap(device_t device, uint32_t placement, uint32_t flags)
> +{
> + size_t bo_size = 8192;
> + uint32_t *map = NULL;
> + uint32_t bo;
> + int i;
> +
> + igt_require_f(placement, "Device doesn't support such memory region\n");
> +
> + bo_size = ALIGN(bo_size, xe_get_default_alignment(device.fd_xe));
> +
> + bo = xe_bo_create(device.fd_xe, 0, bo_size, placement, flags);
> + map = xe_bo_map(device.fd_xe, bo, bo_size);
> + igt_assert(map);
> + memset(map, 0, bo_size);
> +
> + fw_handle = igt_debugfs_open(device.fd_xe, "forcewake_all", O_RDONLY);
> +
> + igt_assert(fw_handle >= 0);
> + igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
> +
> + for (i = 0; i < bo_size / sizeof(*map); i++)
> + map[i] = MAGIC_1;
> +
> + for (i = 0; i < bo_size / sizeof(*map); i++)
> + igt_assert(map[i] == MAGIC_1);
> +
> + /* Runtime suspend and validate the pattern and changed the pattern */
> + close(fw_handle);
> + igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
> +
> + for (i = 0; i < bo_size / sizeof(*map); i++)
> + igt_assert(map[i] == MAGIC_1);
> +
> + /* dgfx page-fault on mmaping should wake the gpu */
> + if (xe_has_vram(device.fd_xe))
> + igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
> +
> + igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
> +
> + for (i = 0; i < bo_size / sizeof(*map); i++)
> + map[i] = MAGIC_2;
> +
> + if (xe_has_vram(device.fd_xe))
> + igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
> +
> + igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
> +
> + /* Runtime resume and check the pattern */
> + fw_handle = igt_debugfs_open(device.fd_xe, "forcewake_all", O_RDONLY);
> + igt_assert(fw_handle >= 0);
> + igt_assert(igt_get_runtime_pm_status() == IGT_RUNTIME_PM_STATUS_ACTIVE);
> + for (i = 0; i < bo_size / sizeof(*map); i++)
> + igt_assert(map[i] == MAGIC_2);
> +
> + igt_assert(munmap(map, bo_size) == 0);
> + gem_close(device.fd_xe, bo);
> + close(fw_handle);
> +}
> +
> igt_main
> {
> struct drm_xe_engine_class_instance *hwe;
> @@ -591,6 +666,30 @@ igt_main
> igt_install_exit_handler(vram_d3cold_threshold_restore);
> test_vram_d3cold_threshold(device, sysfs_fd);
> }
> +
> + igt_describe("Validate mmap memory mappings with system region,"
> + "when device along with parent bridge in d3");
> + igt_subtest("d3-mmap-system") {
> + test_mmap(device, system_memory(device.fd_xe), 0);
> + }
> +
> + igt_describe("Validate mmap memory mappings with vram region,"
> + "when device along with parent bridge in d3");
> + igt_subtest("d3-mmap-vram") {
> + int delay_ms;
> +
> + if (device.pci_root != device.pci_xe) {
> + igt_pm_enable_pci_card_runtime_pm(device.pci_root, NULL);
> + igt_pm_set_d3cold_allowed(device.pci_slot_name, 1);
> + }
> +
> + delay_ms = igt_pm_get_autosuspend_delay(device.pci_xe);
> +
> + /* Give some auto suspend delay to validate rpm active during page fault */
> + igt_pm_set_autosuspend_delay(device.pci_xe, 1000);
> + test_mmap(device, vram_memory(device.fd_xe, 0), DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
> + igt_pm_set_autosuspend_delay(device.pci_xe, delay_ms);
LGTM:
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
Thanks,
Badal
> + }
> }
>
> igt_fixture {
^ permalink raw reply [flat|nested] 9+ messages in thread