From: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v4 1/3] tests/xe_waitfence: remove invalid_engine subtest from xe_waitfence
Date: Mon, 22 Jan 2024 08:15:41 +0530 [thread overview]
Message-ID: <20240122024543.456795-2-krishnaiah.bommu@intel.com> (raw)
In-Reply-To: <20240122024543.456795-1-krishnaiah.bommu@intel.com>
engine and instance members are removed from drm_xe_wait_user_fence,
hence invalid_engine subtest is invalid and removing it.
kernel implementation:
https://patchwork.freedesktop.org/series/127365/
Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
tests/intel/xe_waitfence.c | 30 ------------------------------
1 file changed, 30 deletions(-)
diff --git a/tests/intel/xe_waitfence.c b/tests/intel/xe_waitfence.c
index 7ba20764c..dfdb97fb5 100644
--- a/tests/intel/xe_waitfence.c
+++ b/tests/intel/xe_waitfence.c
@@ -151,9 +151,6 @@ waitfence(int fd, enum waittype wt)
* SUBTEST: invalid-ops
* Description: Check query with invalid ops returns expected error code
*
- * SUBTEST: invalid-engine
- * Description: Check query with invalid engine info returns expected error code
- *
* SUBTEST: exec_queue-reset-wait
* Description: Don’t wait till timeout on user fence when exec_queue reset is detected and return return proper error
*/
@@ -206,30 +203,6 @@ invalid_ops(int fd)
do_ioctl_err(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait, EINVAL);
}
-static void
-invalid_engine(int fd)
-{
- uint32_t bo;
-
- struct drm_xe_wait_user_fence wait = {
- .addr = to_user_pointer(&wait_fence),
- .op = DRM_XE_UFENCE_WAIT_OP_EQ,
- .flags = 0,
- .value = 1,
- .mask = DRM_XE_UFENCE_WAIT_MASK_U64,
- .timeout = -1,
- .exec_queue_id = 0,
- };
-
- uint32_t vm = xe_vm_create(fd, 0, 0);
-
- bo = xe_bo_create(fd, vm, 0x40000, vram_if_possible(fd, 0), 0);
-
- do_bind(fd, vm, bo, 0, 0x200000, 0x40000, 1);
-
- do_ioctl_err(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait, EFAULT);
-}
-
static void
exec_queue_reset_wait(int fd)
{
@@ -329,9 +302,6 @@ igt_main
igt_subtest("invalid-ops")
invalid_ops(fd);
- igt_subtest("invalid-engine")
- invalid_engine(fd);
-
igt_subtest("exec_queue-reset-wait")
exec_queue_reset_wait(fd);
--
2.25.1
next prev parent reply other threads:[~2024-01-22 2:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 2:45 [PATCH v4 0/3] tests/xe_waitfence: removed invalid_engine subtest Bommu Krishnaiah
2024-01-22 2:45 ` Bommu Krishnaiah [this message]
2024-01-22 20:53 ` [PATCH v4 1/3] tests/xe_waitfence: remove invalid_engine subtest from xe_waitfence Rodrigo Vivi
2024-01-22 2:45 ` [PATCH v4 2/3] tests/xe_waitfence: Removed drm_xe_sync data in exec_queue_reset_wait Bommu Krishnaiah
2024-01-22 20:53 ` Rodrigo Vivi
2024-01-22 2:45 ` [PATCH v4 3/3] tests/xe_waitfence: Removed duplicate code in waitfence Bommu Krishnaiah
2024-01-22 20:54 ` Rodrigo Vivi
2024-01-22 3:13 ` ✓ CI.xeBAT: success for tests/xe_waitfence: removed invalid_engine subtest (rev4) Patchwork
2024-01-22 3:33 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122024543.456795-2-krishnaiah.bommu@intel.com \
--to=krishnaiah.bommu@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox