From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t v2 2/7] lib/xe_spin: account for prefetch
Date: Thu, 25 Jan 2024 10:56:40 +0000 [thread overview]
Message-ID: <20240125105646.313561-2-matthew.auld@intel.com> (raw)
In-Reply-To: <20240125105646.313561-1-matthew.auld@intel.com>
Xe2 expects an extra page after the batch to avoid prefetch hitting an
invalid page. Not doing so can result in CAT errors.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/xe/xe_spin.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/xe/xe_spin.c b/lib/xe/xe_spin.c
index 243e97047..2c531e85e 100644
--- a/lib/xe/xe_spin.c
+++ b/lib/xe/xe_spin.c
@@ -186,7 +186,7 @@ void xe_spin_end(struct xe_spin *spin)
igt_spin_t *
xe_spin_create(int fd, const struct igt_spin_factory *opt)
{
- size_t bo_size = xe_get_default_alignment(fd);
+ size_t bo_size = xe_bb_size(fd, SZ_4K);
uint64_t ahnd = opt->ahnd, addr;
struct igt_spin *spin;
struct xe_spin *xe_spin;
@@ -285,7 +285,7 @@ void xe_cork_init(int fd, struct drm_xe_engine_class_instance *hwe,
struct xe_cork *cork)
{
uint64_t addr = xe_get_default_alignment(fd);
- size_t bo_size = xe_get_default_alignment(fd);
+ size_t bo_size = xe_bb_size(fd, SZ_4K);
uint32_t vm, bo, exec_queue, syncobj;
struct xe_spin *spin;
struct drm_xe_sync sync = {
--
2.43.0
next prev parent reply other threads:[~2024-01-25 10:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 10:56 [PATCH i-g-t v2 1/7] lib/xe/ioctl: introduce xe_bb_size() helper Matthew Auld
2024-01-25 10:56 ` Matthew Auld [this message]
2024-01-26 6:20 ` [PATCH i-g-t v2 2/7] lib/xe_spin: account for prefetch Zbigniew Kempczyński
2024-01-25 10:56 ` [PATCH i-g-t v2 3/7] tests/intel/xe: " Matthew Auld
2024-01-25 10:56 ` [PATCH i-g-t v2 4/7] benchmarks/gem_wsim: use xe_bb_size() helper Matthew Auld
2024-01-25 10:56 ` [PATCH i-g-t v2 5/7] lib/igt_fb: " Matthew Auld
2024-01-25 10:56 ` [PATCH i-g-t v2 6/7] tests/intel/xe: " Matthew Auld
2024-01-25 10:56 ` [PATCH i-g-t v2 7/7] lib/intel_blt: use BYTE_COPY mode on xe2 Matthew Auld
2024-01-25 11:43 ` ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v2,1/7] lib/xe/ioctl: introduce xe_bb_size() helper Patchwork
2024-01-26 10:06 ` Kamil Konieczny
2024-01-29 7:16 ` Illipilli, TejasreeX
2024-01-25 12:05 ` ✓ CI.xeBAT: success " Patchwork
2024-01-29 7:14 ` ✓ Fi.CI.BAT: " Patchwork
2024-01-29 8:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-01-29 10:05 ` Kamil Konieczny
2024-02-01 8:14 ` Illipilli, TejasreeX
2024-02-01 5:51 ` ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125105646.313561-2-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox