Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t v2 7/7] lib/intel_blt: use BYTE_COPY mode on xe2
Date: Thu, 25 Jan 2024 10:56:45 +0000	[thread overview]
Message-ID: <20240125105646.313561-7-matthew.auld@intel.com> (raw)
In-Reply-To: <20240125105646.313561-1-matthew.auld@intel.com>

Currently we see various CAT errors and timeouts on xe2 when running
xe_copy_basic. If selecting PAGE_COPY mode for MEM_COPY, the page size
is defined as 256B block on xe2. Also the width should be defined in
number of pages, and not bytes, which likely explains the CAT errors.
However the caller in xe_copy_basic is not using a size that is aligned
to 256B, so rather just select the more general BYTE_COPY mode instead,
which should work for any reasonable number of bytes. Also bit 19
doesn't look to be supported on PVC, where byte copy is all we seem to
have. In addition the matrix copy also expects byte copy.

BSpec: 57561
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/intel_blt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/intel_blt.c b/lib/intel_blt.c
index e41e261ea..25d251c4f 100644
--- a/lib/intel_blt.c
+++ b/lib/intel_blt.c
@@ -1613,7 +1613,7 @@ static void emit_blt_mem_copy(int fd, uint64_t ahnd, const struct blt_mem_data *
 	optype = mem->src.type == M_MATRIX ? 1 << 17 : 0;
 
 	i = 0;
-	batch[i++] = MEM_COPY_CMD | (1 << 19) | optype;
+	batch[i++] = MEM_COPY_CMD | optype;
 	batch[i++] = mem->src.width - 1;
 	batch[i++] = mem->src.height - 1;
 	batch[i++] = mem->src.pitch - 1;
-- 
2.43.0


  parent reply	other threads:[~2024-01-25 10:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 10:56 [PATCH i-g-t v2 1/7] lib/xe/ioctl: introduce xe_bb_size() helper Matthew Auld
2024-01-25 10:56 ` [PATCH i-g-t v2 2/7] lib/xe_spin: account for prefetch Matthew Auld
2024-01-26  6:20   ` Zbigniew Kempczyński
2024-01-25 10:56 ` [PATCH i-g-t v2 3/7] tests/intel/xe: " Matthew Auld
2024-01-25 10:56 ` [PATCH i-g-t v2 4/7] benchmarks/gem_wsim: use xe_bb_size() helper Matthew Auld
2024-01-25 10:56 ` [PATCH i-g-t v2 5/7] lib/igt_fb: " Matthew Auld
2024-01-25 10:56 ` [PATCH i-g-t v2 6/7] tests/intel/xe: " Matthew Auld
2024-01-25 10:56 ` Matthew Auld [this message]
2024-01-25 11:43 ` ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v2,1/7] lib/xe/ioctl: introduce " Patchwork
2024-01-26 10:06   ` Kamil Konieczny
2024-01-29  7:16     ` Illipilli, TejasreeX
2024-01-25 12:05 ` ✓ CI.xeBAT: success " Patchwork
2024-01-29  7:14 ` ✓ Fi.CI.BAT: " Patchwork
2024-01-29  8:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-01-29 10:05   ` Kamil Konieczny
2024-02-01  8:14     ` Illipilli, TejasreeX
2024-02-01  5:51 ` ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240125105646.313561-7-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox