Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>
Subject: [PATCH i-g-t v2] tests/intel/xe_exec_atomic: Skip on unsupported config
Date: Mon, 29 Jan 2024 09:01:55 +0100	[thread overview]
Message-ID: <20240129080155.31648-1-nirmoy.das@intel.com> (raw)

Atomics on system memory for dGPU is not functional
at this moment hence skip on such configuration.

v2: remove the skip_on.

Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 tests/intel/xe_exec_atomic.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/intel/xe_exec_atomic.c b/tests/intel/xe_exec_atomic.c
index 7ee80816c..48c70ec72 100644
--- a/tests/intel/xe_exec_atomic.c
+++ b/tests/intel/xe_exec_atomic.c
@@ -112,9 +112,8 @@ static void basic_inst(int fd, int inst_type, struct drm_xe_engine_class_instanc
 
 static bool has_atomics(int fd, uint32_t region)
 {
-	/* System memory atomics on PVC doesn't work */
-	if (region == system_memory(fd) &&
-	    IS_PONTEVECCHIO(intel_get_drm_devid(fd)))
+	/* System memory atomics on dGPU is not functional as of now */
+	if (region == system_memory(fd) && xe_has_vram(fd))
 		return false;
 
 	return true;
@@ -135,8 +134,8 @@ igt_main
 			uint64_t memreg = all_memory_regions(fd), region;
 
 			xe_for_each_mem_region(fd, memreg, region) {
-
-				igt_skip_on(!has_atomics(fd, region));
+				if (!has_atomics(fd, region))
+					continue;
 
 				igt_dynamic_f("Engine-%s-Instance-%d-Tile-%d-%s-memory",
 					      xe_engine_class_string(hwe->engine_class),
-- 
2.42.0


             reply	other threads:[~2024-01-29  8:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29  8:01 Nirmoy Das [this message]
2024-01-29  8:47 ` [PATCH i-g-t v2] tests/intel/xe_exec_atomic: Skip on unsupported config Kamil Konieczny
2024-01-29  9:09   ` Nirmoy Das
2024-01-29 10:55     ` Kamil Konieczny
2024-01-29 11:03       ` Nirmoy Das
2024-01-29 11:12         ` Kamil Konieczny
2024-01-29 11:28           ` Nirmoy Das
2024-01-29 12:04 ` ✓ Fi.CI.BAT: success for tests/intel/xe_exec_atomic: Skip on unsupported config (rev2) Patchwork
2024-01-29 12:14 ` ✓ CI.xeBAT: " Patchwork
2024-01-30  0:47 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240129080155.31648-1-nirmoy.das@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox