Re: [PATCH i-g-t v2] tests/intel/xe_exec_atomic: Skip on unsupported config

[Nirmoy Das <nirmoy.das@intel.com>]

On 1/29/2024 2:17 PM, Kamil Konieczny wrote:
> Hi Nirmoy,
> On 2024-01-29 at 09:01:55 +0100, Nirmoy Das wrote:
>> Atomics on system memory for dGPU is not functional
>> at this moment hence skip on such configuration.
>>
>> v2: remove the skip_on.
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Thanks, Kamil. Please also help me  merge this one. Currently I don't 
have access to my devel machine.


Nirmoy

>
>> ---
>>   tests/intel/xe_exec_atomic.c | 9 ++++-----
>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/tests/intel/xe_exec_atomic.c b/tests/intel/xe_exec_atomic.c
>> index 7ee80816c..48c70ec72 100644
>> --- a/tests/intel/xe_exec_atomic.c
>> +++ b/tests/intel/xe_exec_atomic.c
>> @@ -112,9 +112,8 @@ static void basic_inst(int fd, int inst_type, struct drm_xe_engine_class_instanc
>>   
>>   static bool has_atomics(int fd, uint32_t region)
>>   {
>> -	/* System memory atomics on PVC doesn't work */
>> -	if (region == system_memory(fd) &&
>> -	    IS_PONTEVECCHIO(intel_get_drm_devid(fd)))
>> +	/* System memory atomics on dGPU is not functional as of now */
>> +	if (region == system_memory(fd) && xe_has_vram(fd))
>>   		return false;
>>   
>>   	return true;
>> @@ -135,8 +134,8 @@ igt_main
>>   			uint64_t memreg = all_memory_regions(fd), region;
>>   
>>   			xe_for_each_mem_region(fd, memreg, region) {
>> -
>> -				igt_skip_on(!has_atomics(fd, region));
>> +				if (!has_atomics(fd, region))
>> +					continue;
>>   
>>   				igt_dynamic_f("Engine-%s-Instance-%d-Tile-%d-%s-memory",
>>   					      xe_engine_class_string(hwe->engine_class),
>> -- 
>> 2.42.0
>>