Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: igt-dev@lists.freedesktop.org
Cc: Louis Chauvet <louis.chauvet@bootlin.com>,
	thomas.petazzoni@bootlin.com,  miquel.raynal@bootlin.com
Subject: [PATCH i-g-t 3/3] tests/kms_rotation_crc: Remove intel guards
Date: Thu, 01 Feb 2024 17:35:55 +0100	[thread overview]
Message-ID: <20240201-kms_tests-v1-3-bc34c5d28b3f@bootlin.com> (raw)
In-Reply-To: <20240201-kms_tests-v1-0-bc34c5d28b3f@bootlin.com>

Remove a lot of intel guards on multiple tests.
The only guard keep is bad-pixel-format because it seems very
intel-specific.

Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
 tests/kms_rotation_crc.c | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 8d8c53b5ff84..1ab2dc68663b 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -634,7 +634,8 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
 		plane = igt_output_get_plane_type(output, plane_type);
 		igt_require(igt_plane_has_prop(plane, IGT_PLANE_ROTATION));
 		igt_require(igt_plane_has_rotation(plane, data->rotation));
-		/* CHV can't rotate and reflect simultaneously */
+		/* When using CHERRYVIEW intel device, simultaneous rotation and reflection are not supported at the
+		 * same time, so skip this test */
 		igt_require(!is_intel_device(data->gfx_fd) ||
 			    !IS_CHERRYVIEW(data->devid) ||
 			    data->rotation != (IGT_ROTATION_180 | IGT_REFLECT_X));
@@ -1250,12 +1251,13 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	data.pos_x = 0,
 	data.pos_y = 0;
 
-	igt_describe("Checking unsupported pixel format for gen9+ with 90 degree of rotation");
+	igt_describe("Checking unsupported pixel format for Intel gen9+ with 90 degree of rotation");
 	igt_subtest_f("bad-pixel-format") {
 		 /* gen11 enables RGB565 rotation for 90/270 degrees.
 		  * so apart from this, any other gen11+ pixel format
 		  * can be used which doesn't support 90/270 degree
 		  * rotation */
+		igt_require(is_intel_device(data.gfx_fd));
 		data.rotation = IGT_ROTATION_90;
 		data.override_fmt = gen < 11 ? DRM_FORMAT_RGB565 : DRM_FORMAT_Y212;
 		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, true);
@@ -1270,11 +1272,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	}
 	data.override_modifier = 0;
 
-	igt_describe("Tiling and Rotation test for gen 10+ for primary plane");
+	igt_describe("Tiling and Rotation test for primary plane");
 	for (reflect_x = reflect_x_subtests; reflect_x->modifier; reflect_x++) {
-		igt_fixture
-			igt_require_intel(data.gfx_fd);
-
 		igt_subtest_f("primary-%s-tiled-reflect-x-%s",
 			      igt_fb_modifier_name(reflect_x->modifier),
 			      igt_plane_rotation_name(reflect_x->rot)) {
@@ -1286,7 +1285,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 
 	igt_describe("Rotation test on both planes by making them fully visible");
 	igt_subtest_f("multiplane-rotation") {
-		igt_require(gen >= 9);
+		/* This feature is only supported for Intel device >= 9 */
+		if (is_intel_device(data.gfx_fd))
+			igt_require(gen > 9);
 		cleanup_crtc(&data);
 		data.planepos[0].origo = p_top | p_left;
 		data.planepos[0].x = .2f;
@@ -1300,7 +1301,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	igt_describe("Rotation test on both planes by cropping left/top corner of primary plane and"
 			"right/top corner of sprite plane");
 	igt_subtest_f("multiplane-rotation-cropping-top") {
-		igt_require(gen >= 9);
+/* This feature is only supported for Intel device >= 9 */
+		if (is_intel_device(data.gfx_fd))
+			igt_require(gen > 9);
 		cleanup_crtc(&data);
 		data.planepos[0].origo = p_top | p_left;
 		data.planepos[0].x = -.05f;
@@ -1314,7 +1317,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	igt_describe("Rotation test on both planes by cropping left/bottom corner of primary plane"
 			"and right/bottom corner of sprite plane");
 	igt_subtest_f("multiplane-rotation-cropping-bottom") {
-		igt_require(gen >= 9);
+/* This feature is only supported for Intel device >= 9 */
+		if (is_intel_device(data.gfx_fd))
+			igt_require(gen > 9);
 		cleanup_crtc(&data);
 		data.planepos[0].origo = p_bottom | p_left;
 		data.planepos[0].x = -.05f;

-- 
2.43.0


  parent reply	other threads:[~2024-02-01 16:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01 16:35 [PATCH i-g-t 0/3] Add tests for kms_plane and kms_rotation Louis Chauvet
2024-02-01 16:35 ` [PATCH i-g-t 1/3] tests/kms/plane: Rename test_planar_settings to test_odd_size_with_yuv Louis Chauvet
2024-02-01 16:35 ` [PATCH i-g-t 2/3] tests/kms/plane: Use a complex pattern to test plane color conversion Louis Chauvet
2024-02-01 16:35 ` Louis Chauvet [this message]
2024-02-01 17:16   ` [PATCH i-g-t 3/3] tests/kms_rotation_crc: Remove intel guards Louis Chauvet
2024-02-01 18:08 ` ✓ CI.xeBAT: success for Add tests for kms_plane and kms_rotation Patchwork
2024-02-01 18:22 ` ✓ Fi.CI.BAT: " Patchwork
2024-02-01 20:07 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240201-kms_tests-v1-3-bc34c5d28b3f@bootlin.com \
    --to=louis.chauvet@bootlin.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox