From: Louis Chauvet <louis.chauvet@bootlin.com>
To: igt-dev@lists.freedesktop.org
Cc: thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com
Subject: Re: [PATCH i-g-t 3/3] tests/kms_rotation_crc: Remove intel guards
Date: Thu, 1 Feb 2024 18:16:32 +0100 [thread overview]
Message-ID: <ZbvR8B_yuSTQ2KmB@localhost.localdomain> (raw)
In-Reply-To: <20240201-kms_tests-v1-3-bc34c5d28b3f@bootlin.com>
In this patch I forgot to remove this modifier if the device is not an
intel GPU:
modifier = data->override_modifier ?: I915_FORMAT_MOD_Y_TILED;
line 389 in tests/kms_rotation_crc.c
I will add it in my v2 when the rest of the series is reviewed:
if (is_intel_device(data->gfx_fd)) {
modifier = data->override_modifier ?: I915_FORMAT_MOD_Y_TILED;
}
This way the rotation tests can be run for vkms too.
next prev parent reply other threads:[~2024-02-01 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 16:35 [PATCH i-g-t 0/3] Add tests for kms_plane and kms_rotation Louis Chauvet
2024-02-01 16:35 ` [PATCH i-g-t 1/3] tests/kms/plane: Rename test_planar_settings to test_odd_size_with_yuv Louis Chauvet
2024-02-01 16:35 ` [PATCH i-g-t 2/3] tests/kms/plane: Use a complex pattern to test plane color conversion Louis Chauvet
2024-02-01 16:35 ` [PATCH i-g-t 3/3] tests/kms_rotation_crc: Remove intel guards Louis Chauvet
2024-02-01 17:16 ` Louis Chauvet [this message]
2024-02-01 18:08 ` ✓ CI.xeBAT: success for Add tests for kms_plane and kms_rotation Patchwork
2024-02-01 18:22 ` ✓ Fi.CI.BAT: " Patchwork
2024-02-01 20:07 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbvR8B_yuSTQ2KmB@localhost.localdomain \
--to=louis.chauvet@bootlin.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=miquel.raynal@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox