From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Subject: [PATCH i-g-t v2 2/6] lib/gpu_cmds: default to uc MOCS index
Date: Tue, 5 Mar 2024 12:17:50 +0000 [thread overview]
Message-ID: <20240305121754.182425-2-matthew.auld@intel.com> (raw)
In-Reply-To: <20240305121754.182425-1-matthew.auld@intel.com>
Currently we just default to index=0, but that can have different
meaning between HW versions. Rather just default to UC mocs index.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/gpu_cmds.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
index 49ba364f9..d909efde8 100644
--- a/lib/gpu_cmds.c
+++ b/lib/gpu_cmds.c
@@ -214,10 +214,10 @@ gen9_fill_surface_state(struct intel_bb *ibb,
ss->ss0.vertical_alignment = 1; /* align 4 */
ss->ss0.horizontal_alignment = 1; /* align 4 */
- if (mocs == INTEL_BUF_MOCS_UC)
- ss->ss1.mocs_index = intel_get_uc_mocs_index(ibb->fd);
- else if (mocs == INTEL_BUF_MOCS_WB)
+ if (mocs == INTEL_BUF_MOCS_WB)
ss->ss1.mocs_index = intel_get_wb_mocs_index(ibb->fd);
+ else
+ ss->ss1.mocs_index = intel_get_uc_mocs_index(ibb->fd);
if (buf->tiling == I915_TILING_X)
ss->ss0.tiled_mode = 2;
@@ -275,10 +275,10 @@ gen11_fill_surface_state(struct intel_bb *ibb,
ss->ss0.vertical_alignment = vertical_alignment; /* align 4 */
ss->ss0.horizontal_alignment = horizontal_alignment; /* align 4 */
- if (mocs == INTEL_BUF_MOCS_UC)
- ss->ss1.mocs_index = intel_get_uc_mocs_index(ibb->fd);
- else if (mocs == INTEL_BUF_MOCS_WB)
+ if (mocs == INTEL_BUF_MOCS_WB)
ss->ss1.mocs_index = intel_get_wb_mocs_index(ibb->fd);
+ else
+ ss->ss1.mocs_index = intel_get_uc_mocs_index(ibb->fd);
if (buf->tiling == I915_TILING_X)
ss->ss0.tiled_mode = 2;
@@ -931,10 +931,10 @@ xehp_fill_surface_state(struct intel_bb *ibb,
ss->ss0.vertical_alignment = 1; /* align 4 */
ss->ss0.horizontal_alignment = 1; /* align 4 */
- if (mocs == INTEL_BUF_MOCS_UC)
- ss->ss1.mocs_index = intel_get_uc_mocs_index(ibb->fd);
- else if (mocs == INTEL_BUF_MOCS_WB)
+ if (mocs == INTEL_BUF_MOCS_WB)
ss->ss1.mocs_index = intel_get_wb_mocs_index(ibb->fd);
+ else
+ ss->ss1.mocs_index = intel_get_uc_mocs_index(ibb->fd);
if (buf->tiling == I915_TILING_X)
ss->ss0.tiled_mode = 2;
--
2.43.2
next prev parent reply other threads:[~2024-03-05 12:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 12:17 [PATCH i-g-t v2 1/6] lib/rendercopy_gen9: use MOCS index helper Matthew Auld
2024-03-05 12:17 ` Matthew Auld [this message]
2024-03-06 6:01 ` [PATCH i-g-t v2 2/6] lib/gpu_cmds: default to uc MOCS index Zbigniew Kempczyński
2024-03-05 12:17 ` [PATCH i-g-t v2 3/6] lib/intel_buf: revamp MOCS usage Matthew Auld
2024-03-06 6:29 ` Zbigniew Kempczyński
2024-03-05 12:17 ` [PATCH i-g-t v2 4/6] lib/intel_buf: expose mocs_index Matthew Auld
2024-03-06 6:32 ` Zbigniew Kempczyński
2024-03-05 12:17 ` [PATCH i-g-t v2 5/6] lib/intel_mocs: add defer-to-pat-index Matthew Auld
2024-03-06 14:11 ` Zbigniew Kempczyński
2024-03-05 12:17 ` [PATCH i-g-t v2 6/6] tests/intel/xe_pat: verify wb-transient with pipe crc Matthew Auld
2024-03-05 13:40 ` ✓ CI.xeBAT: success for series starting with [i-g-t,v2,1/6] lib/rendercopy_gen9: use MOCS index helper Patchwork
2024-03-05 14:04 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305121754.182425-2-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox