Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 09/13] tools/intel_vbt_decode: Add version checks for backlight decoding
Date: Fri, 22 Mar 2024 22:41:21 +0200	[thread overview]
Message-ID: <20240322204125.17212-10-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240322204125.17212-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Decode stuff from the backlight block based on the version
number.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tools/intel_vbt_decode.c | 39 +++++++++++++++++++++++++--------------
 1 file changed, 25 insertions(+), 14 deletions(-)

diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
index fa9c45920853..642cb84a56b6 100644
--- a/tools/intel_vbt_decode.c
+++ b/tools/intel_vbt_decode.c
@@ -650,27 +650,38 @@ static void dump_backlight_info(struct context *context,
 			printf("\t\tI2C command: 0x%02x\n", blc->i2c_command);
 		}
 
+		if (context->bdb->version < 162)
+			continue;
+
 		printf("\t\tLevel: %u\n", backlight->level[i]);
 
+		if (context->bdb->version < 191)
+			continue;
+
 		control = &backlight->backlight_control[i];
 
 		printf("\t\tControl type: %u\n", control->type);
 		printf("\t\tController: %u\n", control->controller);
 
-		if (context->bdb->version >= 234) {
-			printf("\t\tBrightness level: %u\n",
-			       backlight->brightness_level[i].level);
-			printf("\t\tBrightness min level: %u\n",
-			       backlight->brightness_min_level[i].level);
-		}
-
-		if (context->bdb->version >= 236)
-			printf("\t\tBrigthness precision bits: %u\n",
-			       backlight->brightness_precision_bits[i]);
-
-		if (context->bdb->version >= 239)
-			printf("\t\tHDR DPCD refresh timeout: %.2f ms\n",
-			       backlight->hdr_dpcd_refresh_timeout[i] / 100.0);
+		if (context->bdb->version < 234)
+			continue;
+
+		printf("\t\tBrightness level: %u\n",
+		       backlight->brightness_level[i].level);
+		printf("\t\tBrightness min level: %u\n",
+		       backlight->brightness_min_level[i].level);
+
+		if (context->bdb->version < 236)
+			continue;
+
+		printf("\t\tBrigthness precision bits: %u\n",
+		       backlight->brightness_precision_bits[i]);
+
+		if (context->bdb->version < 239)
+			continue;
+
+		printf("\t\tHDR DPCD refresh timeout: %.2f ms\n",
+		       backlight->hdr_dpcd_refresh_timeout[i] / 100.0);
 	}
 }
 
-- 
2.43.2


  parent reply	other threads:[~2024-03-22 20:41 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22 20:41 [PATCH i-g-t 00/13] tools/intel_vbt_decode: Various improvement Ville Syrjala
2024-03-22 20:41 ` [PATCH i-g-t 01/13] tools/intel_vbt_decode: update vbt defs from kernel Ville Syrjala
2024-04-11 12:20   ` Jani Nikula
2024-03-22 20:41 ` [PATCH i-g-t 02/13] tools/intel_vbt_decode: Extract default_algorithm() Ville Syrjala
2024-04-11 12:20   ` Jani Nikula
2024-03-22 20:41 ` [PATCH i-g-t 03/13] tools/intel_vbt_decode: Allow blocks to be named without full decoding Ville Syrjala
2024-04-11 12:22   ` Jani Nikula
2024-04-11 13:12     ` Jani Nikula
2024-04-11 13:15       ` Ville Syrjälä
2024-03-22 20:41 ` [PATCH i-g-t 04/13] tools/intel_vbt_decode: Print the block min size Ville Syrjala
2024-04-11 12:24   ` Jani Nikula
2024-03-22 20:41 ` [PATCH i-g-t 05/13] tools/intel_vbt_decode: Dump AIM offsets Ville Syrjala
2024-04-11 12:25   ` Jani Nikula
2024-03-22 20:41 ` [PATCH i-g-t 06/13] tools/intel_vbt_decode: Decode the backlight i2c stuff Ville Syrjala
2024-04-11 12:44   ` Jani Nikula
2024-03-22 20:41 ` [PATCH i-g-t 07/13] tools/intel_vbt_decode: Decode the obsolote DPST supported field Ville Syrjala
2024-04-11 12:46   ` Jani Nikula
2024-03-22 20:41 ` [PATCH i-g-t 08/13] tools/intel_vbt_decode: Check version before decoding lace_aggressiveness_profile Ville Syrjala
2024-04-11 13:03   ` Jani Nikula
2024-03-22 20:41 ` Ville Syrjala [this message]
2024-04-11 13:06   ` [PATCH i-g-t 09/13] tools/intel_vbt_decode: Add version checks for backlight decoding Jani Nikula
2024-03-22 20:41 ` [PATCH i-g-t 10/13] tools/intel_vbt_decode: Dump out the backlight entry size Ville Syrjala
2024-04-11 13:06   ` Jani Nikula
2024-03-22 20:41 ` [PATCH i-g-t 11/13] tools/intel_vbt_decode: Dump MIPI sequences in the order they appear in VBT Ville Syrjala
2024-04-11 13:08   ` Jani Nikula
2024-03-22 20:41 ` [PATCH i-g-t 12/13] tools/intel_vbt_decode: Decode all the driver feature bits Ville Syrjala
2024-04-11 13:10   ` Jani Nikula
2024-03-22 20:41 ` [PATCH i-g-t 13/13] tools/intel_vbt_decode: Decode the EFP index Ville Syrjala
2024-04-11 13:11   ` Jani Nikula
2024-03-22 23:39 ` ✓ CI.xeBAT: success for tools/intel_vbt_decode: Various improvement Patchwork
2024-03-22 23:56 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-23 22:43 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-13 13:13 ` [PATCH i-g-t 00/13] " Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240322204125.17212-10-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox