Re: [PATCH i-g-t 11/13] tools/intel_vbt_decode: Dump MIPI sequences in the order they appear in VBT

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 22 Mar 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Dump the MIPI sequence blocks in the order they appear
> in the VBT (as opposed to being ordered by the sequence type).
>
> This makes it easier to compare the hexdump vs. the decoded
> output, which is what I tend to do occasionally when trying to
> check whether we are decoding things correctly or not.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  tools/intel_vbt_decode.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index b57d1e9602ae..aa15dbb5e3fd 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -2446,12 +2446,9 @@ static void dump_mipi_sequence(struct context *context,
>  				fprintf(stderr, "Invalid sequence %u\n", seq_id);
>  				return;
>  			}
> -		}
>  
> -		/* Dump the sequences. Corresponds to sequence execution in kernel. */
> -		for (int j = 0; j < ARRAY_SIZE(sequence_ptrs); j++)
> -			if (sequence_ptrs[j])
> -				dump_sequence(sequence_ptrs[j], sequence->version);
> +			dump_sequence(sequence_ptrs[seq_id], sequence->version);
> +		}
>  	}
>  }

-- 
Jani Nikula, Intel