Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [PATCH i-g-t] tests/xe_vm: DRM_XE_VM_BIND_FLAG_DUMPABLE is now a valid flag
Date: Fri, 22 Mar 2024 13:53:27 -0700	[thread overview]
Message-ID: <20240322205327.850864-1-matthew.d.roper@intel.com> (raw)

igt@xe_vm@bind-flag-invalid should no longer consider BIT(3) an invalid
flag and expect failure since that is now used by
DRM_XE_VM_BIND_FLAG_DUMPABLE.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1285
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 tests/intel/xe_vm.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
index 7c061c497..00c428bb5 100644
--- a/tests/intel/xe_vm.c
+++ b/tests/intel/xe_vm.c
@@ -1805,6 +1805,11 @@ static void bind_flag_invalid(int fd)
 	syncobj_reset(fd, &sync[0].handle, 1);
 	bind.bind.obj = bo;
 
+	bind.bind.flags = DRM_XE_VM_BIND_FLAG_DUMPABLE;
+	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
+	igt_assert(syncobj_wait(fd, &sync[0].handle, 1, INT64_MAX, 0, NULL));
+	syncobj_reset(fd, &sync[0].handle, 1);
+
 	/* Using invalid flags should not work */
 	bind.bind.flags = 1 << 0;
 	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
@@ -1814,10 +1819,6 @@ static void bind_flag_invalid(int fd)
 	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
 	do_ioctl_err(fd, DRM_IOCTL_XE_VM_BIND, &bind, EINVAL);
 
-	bind.bind.flags = 1 << 3;
-	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
-	do_ioctl_err(fd, DRM_IOCTL_XE_VM_BIND, &bind, EINVAL);
-
 	/* Using valid flags should still work */
 	bind.bind.flags = 0;
 	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
-- 
2.43.0


             reply	other threads:[~2024-03-22 20:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22 20:53 Matt Roper [this message]
2024-03-22 23:18 ` [PATCH i-g-t] tests/xe_vm: DRM_XE_VM_BIND_FLAG_DUMPABLE is now a valid flag Randhawa, Jagmeet
2024-03-23  0:19 ` ✓ CI.xeBAT: success for " Patchwork
2024-03-25 15:51   ` Matt Roper
2024-03-23  0:32 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-23 22:50 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240322205327.850864-1-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox