Re: [PATCH i-g-t] tests/xe_vm: DRM_XE_VM_BIND_FLAG_DUMPABLE is now a valid flag

["Randhawa, Jagmeet" <jagmeet.randhawa@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1655 bytes --]


On 3/22/2024 1:53 PM, Matt Roper wrote:
> igt@xe_vm@bind-flag-invalid should no longer consider BIT(3) an invalid
> flag and expect failure since that is now used by
> DRM_XE_VM_BIND_FLAG_DUMPABLE.
>
> Closes:https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1285
> Signed-off-by: Matt Roper<matthew.d.roper@intel.com>
> ---
>   tests/intel/xe_vm.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
> index 7c061c497..00c428bb5 100644
> --- a/tests/intel/xe_vm.c
> +++ b/tests/intel/xe_vm.c
> @@ -1805,6 +1805,11 @@ static void bind_flag_invalid(int fd)
>   	syncobj_reset(fd, &sync[0].handle, 1);
>   	bind.bind.obj = bo;
>   
> +	bind.bind.flags = DRM_XE_VM_BIND_FLAG_DUMPABLE;
> +	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
> +	igt_assert(syncobj_wait(fd, &sync[0].handle, 1, INT64_MAX, 0, NULL));
> +	syncobj_reset(fd, &sync[0].handle, 1);
> +
>   	/* Using invalid flags should not work */
>   	bind.bind.flags = 1 << 0;
>   	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
> @@ -1814,10 +1819,6 @@ static void bind_flag_invalid(int fd)
>   	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
>   	do_ioctl_err(fd, DRM_IOCTL_XE_VM_BIND, &bind, EINVAL);
>   
> -	bind.bind.flags = 1 << 3;
> -	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
> -	do_ioctl_err(fd, DRM_IOCTL_XE_VM_BIND, &bind, EINVAL);
> -
>   	/* Using valid flags should still work */
>   	bind.bind.flags = 0;
>   	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);

This patch provides a partial fix for VLK-54352, and together with my 
patch it solves the issue.

Reviewed-by: Jagmeet Randhawa <jagmeet.randhawa@intel.com>

[-- Attachment #2: Type: text/html, Size: 3177 bytes --]