Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/xe_vm: DRM_XE_VM_BIND_FLAG_DUMPABLE is now a valid flag
@ 2024-03-22 20:53 Matt Roper
  2024-03-22 23:18 ` Randhawa, Jagmeet
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Matt Roper @ 2024-03-22 20:53 UTC (permalink / raw)
  To: igt-dev; +Cc: matthew.d.roper

igt@xe_vm@bind-flag-invalid should no longer consider BIT(3) an invalid
flag and expect failure since that is now used by
DRM_XE_VM_BIND_FLAG_DUMPABLE.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1285
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 tests/intel/xe_vm.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
index 7c061c497..00c428bb5 100644
--- a/tests/intel/xe_vm.c
+++ b/tests/intel/xe_vm.c
@@ -1805,6 +1805,11 @@ static void bind_flag_invalid(int fd)
 	syncobj_reset(fd, &sync[0].handle, 1);
 	bind.bind.obj = bo;
 
+	bind.bind.flags = DRM_XE_VM_BIND_FLAG_DUMPABLE;
+	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
+	igt_assert(syncobj_wait(fd, &sync[0].handle, 1, INT64_MAX, 0, NULL));
+	syncobj_reset(fd, &sync[0].handle, 1);
+
 	/* Using invalid flags should not work */
 	bind.bind.flags = 1 << 0;
 	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
@@ -1814,10 +1819,6 @@ static void bind_flag_invalid(int fd)
 	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
 	do_ioctl_err(fd, DRM_IOCTL_XE_VM_BIND, &bind, EINVAL);
 
-	bind.bind.flags = 1 << 3;
-	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
-	do_ioctl_err(fd, DRM_IOCTL_XE_VM_BIND, &bind, EINVAL);
-
 	/* Using valid flags should still work */
 	bind.bind.flags = 0;
 	igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-03-25 15:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-22 20:53 [PATCH i-g-t] tests/xe_vm: DRM_XE_VM_BIND_FLAG_DUMPABLE is now a valid flag Matt Roper
2024-03-22 23:18 ` Randhawa, Jagmeet
2024-03-23  0:19 ` ✓ CI.xeBAT: success for " Patchwork
2024-03-25 15:51   ` Matt Roper
2024-03-23  0:32 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-23 22:50 ` ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox