From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Tvrtko Ursulin <tursulin@ursulin.net>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t 5/8] lib/igt_drm_fdinfo: Simplify find_kv()
Date: Tue, 2 Apr 2024 15:17:13 -0700 [thread overview]
Message-ID: <20240402221716.1840148-6-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20240402221716.1840148-1-lucas.demarchi@intel.com>
index() is deprecate from libc and strchr() should rather be used.
Moreover the return value is NULL or a pointer to the occurrence, never
the initial string and `(p - buf) != keylen` can only be true if ':' is
the next char after the key.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
lib/igt_drm_fdinfo.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c
index 17cac4009..15f71e172 100644
--- a/lib/igt_drm_fdinfo.c
+++ b/lib/igt_drm_fdinfo.c
@@ -106,20 +106,17 @@ static int parse_engine(char *line, struct drm_client_fdinfo *info,
static const char *find_kv(const char *buf, const char *key, size_t keylen)
{
- const char *p = buf;
+ const char *p;
if (strncmp(buf, key, keylen))
return NULL;
- p = index(buf, ':');
- if (!p || p == buf)
- return NULL;
- if ((p - buf) != keylen)
+ p = buf + keylen;
+ if (*p != ':')
return NULL;
- p++;
- while (*p && isspace(*p))
- p++;
+ for (p++; *p && isspace(*p); p++)
+ ;
return *p ? p : NULL;
}
@@ -233,8 +230,7 @@ __igt_parse_drm_fdinfo(int dir, const char *fd, struct drm_client_fdinfo *info,
if ((v = find_kv(l, "drm-driver", strlen("drm-driver")))) {
strncpy(info->driver, v, sizeof(info->driver) - 1);
good++;
- } else if ((v = find_kv(l, "drm-client-id",
- strlen("drm-client-id")))) {
+ } else if ((v = find_kv(l, "drm-client-id", strlen("drm-client-id")))) {
info->id = atol(v);
good++;
} else if ((v = find_kv(l, "drm-pdev", strlen("drm-pdev")))) {
--
2.43.0
next prev parent reply other threads:[~2024-04-02 22:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 22:17 [PATCH i-g-t 0/8] Refactors and fixes for drm_clients Lucas De Marchi
2024-04-02 22:17 ` [PATCH i-g-t 1/8] lib/igt_drm_clients: Use calloc Lucas De Marchi
2024-04-03 15:27 ` Umesh Nerlige Ramappa
2024-04-03 17:23 ` Kamil Konieczny
2024-04-02 22:17 ` [PATCH i-g-t 2/8] lib/igt_drm_clients: Fix sizeof calculation Lucas De Marchi
2024-04-03 15:28 ` Umesh Nerlige Ramappa
2024-04-03 17:25 ` Kamil Konieczny
2024-04-02 22:17 ` [PATCH i-g-t 3/8] lib/igt_drm_clients: Fix leaks Lucas De Marchi
2024-04-03 15:39 ` Umesh Nerlige Ramappa
2024-04-03 16:09 ` Tvrtko Ursulin
2024-04-03 17:26 ` Kamil Konieczny
2024-04-02 22:17 ` [PATCH i-g-t 4/8] gputop: Free clients on exit Lucas De Marchi
2024-04-03 16:03 ` Umesh Nerlige Ramappa
2024-04-03 16:13 ` Tvrtko Ursulin
2024-04-03 17:28 ` Kamil Konieczny
2024-04-02 22:17 ` Lucas De Marchi [this message]
2024-04-03 17:48 ` [PATCH i-g-t 5/8] lib/igt_drm_fdinfo: Simplify find_kv() Kamil Konieczny
2024-04-02 22:17 ` [PATCH i-g-t 6/8] lib/igt_drm_fdinfo: Stop passing key twice Lucas De Marchi
2024-04-03 17:56 ` Kamil Konieczny
2024-04-02 22:17 ` [PATCH i-g-t 7/8] lib/igt_drm_fdinfo: Remove prefix arg from parse functions Lucas De Marchi
2024-04-03 23:53 ` Umesh Nerlige Ramappa
2024-04-02 22:17 ` [PATCH i-g-t 8/8] lib/igt_drm_clients: lazy stat process Lucas De Marchi
2024-04-03 16:24 ` Tvrtko Ursulin
2024-04-02 23:59 ` ✗ Fi.CI.BAT: failure for Refactors and fixes for drm_clients Patchwork
2024-04-03 0:31 ` ✓ CI.xeBAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402221716.1840148-6-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox