Re: [PATCH i-g-t 1/8] lib/igt_drm_clients: Use calloc

[Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>]

On Tue, Apr 02, 2024 at 03:17:09PM -0700, Lucas De Marchi wrote:
>Replace malloc + memset with a single calloc as it's shorter and there's
>no point keeping them separate.
>
>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

LGTM,
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

>---
> lib/igt_drm_clients.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
>diff --git a/lib/igt_drm_clients.c b/lib/igt_drm_clients.c
>index 025d60c51..90ca6d61c 100644
>--- a/lib/igt_drm_clients.c
>+++ b/lib/igt_drm_clients.c
>@@ -35,12 +35,10 @@ struct igt_drm_clients *igt_drm_clients_init(void *private_data)
> {
> 	struct igt_drm_clients *clients;
>
>-	clients = malloc(sizeof(*clients));
>+	clients = calloc(1, sizeof(*clients));
> 	if (!clients)
> 		return NULL;
>
>-	memset(clients, 0, sizeof(*clients));
>-
> 	clients->private_data = private_data;
>
> 	return clients;
>@@ -165,9 +163,8 @@ igt_drm_client_add(struct igt_drm_clients *clients,
> 	c->clients = clients;
>
> 	/* Engines */
>-	c->engines = malloc(sizeof(*c->engines));
>+	c->engines = calloc(1, sizeof(*c->engines));
> 	assert(c->engines);
>-	memset(c->engines, 0, sizeof(*c->engines));
> 	c->engines->capacity = calloc(info->last_engine_index + 1,
> 				      sizeof(*c->engines->capacity));
> 	assert(c->engines->capacity);
>@@ -190,9 +187,8 @@ igt_drm_client_add(struct igt_drm_clients *clients,
> 	assert(c->val && c->last);
>
> 	/* Memory regions */
>-	c->regions = malloc(sizeof(*c->regions));
>+	c->regions = calloc(1, sizeof(*c->regions));
> 	assert(c->regions);
>-	memset(c->regions, 0, sizeof(*c->regions));
> 	c->regions->names = calloc(info->last_region_index + 1,
> 				   sizeof(*c->regions->names));
> 	assert(c->regions->names);
>-- 
>2.43.0
>