From: Matthew Brost <matthew.brost@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH v2] tests/intel/xe_vm: Always have at least 2 pages bound in hammer sections
Date: Tue, 9 Apr 2024 18:21:48 -0700 [thread overview]
Message-ID: <20240410012148.409170-1-matthew.brost@intel.com> (raw)
If the prefetch buffer is 2k or larger the hammer sections will prefetch
the next page, if the page is unbound a fault will occur. Account for
larger prefetchs by always having at least 2 pages bound for the hammer
thread.
v2:
- Missed table entry
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
tests/intel/xe_vm.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
index bd4973cc38..9f9f61b7ef 100644
--- a/tests/intel/xe_vm.c
+++ b/tests/intel/xe_vm.c
@@ -1843,12 +1843,12 @@ igt_main
{ "all", 4, 2, 0, 4, 0 },
{ "one-partial", 4, 1, 1, 2, 0 },
{ "either-side-partial", 4, 2, 1, 2, 0 },
- { "either-side-partial-hammer", 4, 2, 1, 2,
+ { "either-side-partial-hammer", 6, 2, 2, 2,
MAP_FLAG_HAMMER_FIRST_PAGE },
- { "either-side-partial-split-page-hammer", 4, 2, 1, 2,
+ { "either-side-partial-split-page-hammer", 6, 2, 2, 2,
MAP_FLAG_HAMMER_FIRST_PAGE |
MAP_FLAG_LARGE_PAGE },
- { "either-side-partial-large-page-hammer", 4, 2, 1, 2,
+ { "either-side-partial-large-page-hammer", 6, 2, 2, 2,
MAP_FLAG_HAMMER_FIRST_PAGE |
MAP_FLAG_LARGE_PAGE |
MAP_FLAG_LARGE_PAGE_NO_SPLIT },
@@ -1857,7 +1857,7 @@ igt_main
{ "front", 4, 2, 1, 3, 0 },
{ "many-all", 4 * 8, 2 * 8, 0 * 8, 4 * 8, 0 },
{ "many-either-side-partial", 4 * 8, 2 * 8, 1, 4 * 8 - 2, 0 },
- { "many-either-side-partial-hammer", 4 * 8, 2 * 8, 1, 4 * 8 - 2,
+ { "many-either-side-partial-hammer", 4 * 8, 2 * 8, 2, 4 * 8 - 4,
MAP_FLAG_HAMMER_FIRST_PAGE },
{ "many-either-side-full", 4 * 8, 4 * 8, 1 * 8, 2 * 8, 0 },
{ "many-end", 4 * 8, 4, 0 * 8, 3 * 8 + 2, 0 },
@@ -1902,12 +1902,12 @@ igt_main
{ "one-partial", 4, 1, 1, 2, 0 },
{ "either-side-partial", 4, 2, 1, 2, 0 },
{ "either-side-full", 4, 4, 1, 2, 0 },
- { "either-side-partial-hammer", 4, 2, 1, 2,
+ { "either-side-partial-hammer", 6, 2, 2, 2,
MAP_FLAG_HAMMER_FIRST_PAGE },
- { "either-side-partial-split-page-hammer", 4, 2, 1, 2,
+ { "either-side-partial-split-page-hammer", 6, 2, 2, 2,
MAP_FLAG_HAMMER_FIRST_PAGE |
MAP_FLAG_LARGE_PAGE },
- { "either-side-partial-large-page-hammer", 4, 2, 1, 2,
+ { "either-side-partial-large-page-hammer", 6, 2, 2, 2,
MAP_FLAG_HAMMER_FIRST_PAGE |
MAP_FLAG_LARGE_PAGE |
MAP_FLAG_LARGE_PAGE_NO_SPLIT },
@@ -1915,7 +1915,7 @@ igt_main
{ "front", 4, 2, 1, 3, 0 },
{ "many-all", 4 * 8, 2 * 8, 0 * 8, 4 * 8, 0 },
{ "many-either-side-partial", 4 * 8, 2 * 8, 1, 4 * 8 - 2, 0 },
- { "many-either-side-partial-hammer", 4 * 8, 2 * 8, 1, 4 * 8 - 2,
+ { "many-either-side-partial-hammer", 4 * 8, 2 * 8, 2, 4 * 8 - 4,
MAP_FLAG_HAMMER_FIRST_PAGE },
{ "userptr-all", 4, 2, 0, 4, MAP_FLAG_USERPTR },
{ "userptr-one-partial", 4, 1, 1, 2, MAP_FLAG_USERPTR },
--
2.34.1
next reply other threads:[~2024-04-10 1:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 1:21 Matthew Brost [this message]
2024-04-10 1:59 ` ✓ CI.xeBAT: success for tests/intel/xe_vm: Always have at least 2 pages bound in hammer sections (rev2) Patchwork
2024-04-10 2:25 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-10 8:42 ` [PATCH v2] tests/intel/xe_vm: Always have at least 2 pages bound in hammer sections Matthew Auld
2024-04-12 1:58 ` Matthew Brost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410012148.409170-1-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox