* [PATCH i-g-t] tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence
@ 2024-04-19 18:57 Brian Welty
2024-04-19 19:33 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Brian Welty @ 2024-04-19 18:57 UTC (permalink / raw)
To: igt-dev, Priyanka Dandamudi, Janga Rahul Kumar
When confirming that xe_exec() user_fences completed, this is performed
in a loop. When using __xe_wait_ufence(), it returns an updated timeout
value to reflect how much time was remaining. As side-effect, when calling
in a loop without resetting the timeout, the timeout value will get
progressively smaller over many iterations.
We don't want a smaller timeout to be used on each subsequent call to
__xe_wait_ufence(), so fix here is to reset the timeout inside the loop.
This issue is visible in simulation runs due to the slower execution time,
where later iterations of the wait are failing due to timeout being too
small.
Signed-off-by: Brian Welty <brian.welty@intel.com>
---
tests/intel/xe_exec_fault_mode.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/intel/xe_exec_fault_mode.c b/tests/intel/xe_exec_fault_mode.c
index 40fe1743e4..c0d082e7fa 100644
--- a/tests/intel/xe_exec_fault_mode.c
+++ b/tests/intel/xe_exec_fault_mode.c
@@ -273,11 +273,12 @@ test_exec(int fd, struct drm_xe_engine_class_instance *eci,
}
}
if (!(flags & INVALID_FAULT)) {
- int64_t timeout = ONE_SEC;
+ int64_t timeout;
j = flags & INVALIDATE ? n_execs - 1 : 0;
for (i = j; i < n_execs; i++) {
+ timeout = ONE_SEC;
if (flags & INVALID_VA && !(flags & ENABLE_SCRATCH))
igt_assert_eq(__xe_wait_ufence(fd, &data[i].exec_sync, USER_FENCE_VALUE,
exec_queues[i % n_exec_queues], &timeout), -EIO);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✗ Fi.CI.BAT: failure for tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence 2024-04-19 18:57 [PATCH i-g-t] tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence Brian Welty @ 2024-04-19 19:33 ` Patchwork 2024-04-23 19:54 ` Kamil Konieczny 2024-04-19 21:35 ` ✓ CI.xeBAT: success " Patchwork 2024-04-23 4:36 ` [PATCH i-g-t] " Matt Roper 2 siblings, 1 reply; 5+ messages in thread From: Patchwork @ 2024-04-19 19:33 UTC (permalink / raw) To: Brian Welty; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 21926 bytes --] == Series Details == Series: tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence URL : https://patchwork.freedesktop.org/series/132659/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14616 -> IGTPW_11046 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_11046 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_11046, please notify your bug team ("I915-ci-infra@lists.freedesktop.org") to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/index.html Participating hosts (34 -> 39) ------------------------------ Additional (7): bat-kbl-2 bat-mtlp-6 bat-dg2-8 fi-apl-guc fi-elk-e7500 bat-dg2-11 bat-arls-3 Missing (2): fi-cfl-8109u fi-bsw-n3050 Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_11046: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_gttfill@basic: - bat-arls-2: [PASS][1] -> [ABORT][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14616/bat-arls-2/igt@gem_exec_gttfill@basic.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-2/igt@gem_exec_gttfill@basic.html * igt@i915_pm_rpm@module-reload: - bat-adlm-1: [PASS][3] -> [INCOMPLETE][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14616/bat-adlm-1/igt@i915_pm_rpm@module-reload.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-adlm-1/igt@i915_pm_rpm@module-reload.html Known issues ------------ Here are the changes found in IGTPW_11046 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@basic-hwmon: - bat-arls-3: NOTRUN -> [SKIP][5] ([i915#9318]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@debugfs_test@basic-hwmon.html - bat-mtlp-6: NOTRUN -> [SKIP][6] ([i915#9318]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@debugfs_test@basic-hwmon.html * igt@fbdev@info: - bat-kbl-2: NOTRUN -> [SKIP][7] ([i915#1849]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-kbl-2/igt@fbdev@info.html - bat-dg2-8: NOTRUN -> [SKIP][8] ([i915#1849] / [i915#2582]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@fbdev@info.html - bat-mtlp-6: NOTRUN -> [SKIP][9] ([i915#1849] / [i915#2582]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@fbdev@info.html * igt@fbdev@read: - bat-dg2-8: NOTRUN -> [SKIP][10] ([i915#2582]) +3 other tests skip [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@fbdev@read.html * igt@fbdev@write: - bat-mtlp-6: NOTRUN -> [SKIP][11] ([i915#2582]) +3 other tests skip [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@fbdev@write.html * igt@gem_lmem_swapping@basic: - fi-apl-guc: NOTRUN -> [SKIP][12] ([i915#4613]) +3 other tests skip [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/fi-apl-guc/igt@gem_lmem_swapping@basic.html * igt@gem_lmem_swapping@parallel-random-engines: - bat-kbl-2: NOTRUN -> [SKIP][13] +39 other tests skip [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-kbl-2/igt@gem_lmem_swapping@parallel-random-engines.html - bat-arls-3: NOTRUN -> [SKIP][14] ([i915#10213]) +3 other tests skip [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@gem_lmem_swapping@parallel-random-engines.html * igt@gem_lmem_swapping@verify-random: - bat-mtlp-6: NOTRUN -> [SKIP][15] ([i915#4613]) +3 other tests skip [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@gem_lmem_swapping@verify-random.html * igt@gem_mmap@basic: - bat-dg2-11: NOTRUN -> [SKIP][16] ([i915#4083]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@gem_mmap@basic.html - bat-dg2-8: NOTRUN -> [SKIP][17] ([i915#4083]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@gem_mmap@basic.html - bat-arls-3: NOTRUN -> [SKIP][18] ([i915#4083]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@gem_mmap@basic.html - bat-mtlp-6: NOTRUN -> [SKIP][19] ([i915#4083]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@gem_mmap@basic.html * igt@gem_render_tiled_blits@basic: - bat-dg2-11: NOTRUN -> [SKIP][20] ([i915#4079]) +1 other test skip [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@gem_render_tiled_blits@basic.html - bat-dg2-8: NOTRUN -> [SKIP][21] ([i915#4079]) +1 other test skip [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@gem_render_tiled_blits@basic.html - bat-arls-3: NOTRUN -> [SKIP][22] ([i915#10197] / [i915#10211] / [i915#4079]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@gem_render_tiled_blits@basic.html * igt@gem_tiled_blits@basic: - bat-arls-3: NOTRUN -> [SKIP][23] ([i915#10196] / [i915#4077]) +2 other tests skip [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@gem_tiled_blits@basic.html - bat-mtlp-6: NOTRUN -> [SKIP][24] ([i915#4077]) +2 other tests skip [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@gem_tiled_blits@basic.html * igt@gem_tiled_fence_blits@basic: - bat-dg2-11: NOTRUN -> [SKIP][25] ([i915#4077]) +2 other tests skip [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@gem_tiled_fence_blits@basic.html - bat-dg2-8: NOTRUN -> [SKIP][26] ([i915#4077]) +2 other tests skip [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@gem_tiled_fence_blits@basic.html * igt@gem_tiled_pread_basic: - bat-mtlp-6: NOTRUN -> [SKIP][27] ([i915#4079]) +1 other test skip [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@gem_tiled_pread_basic.html - bat-arls-3: NOTRUN -> [SKIP][28] ([i915#10206] / [i915#4079]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@gem_tiled_pread_basic.html * igt@i915_pm_rps@basic-api: - bat-dg2-11: NOTRUN -> [SKIP][29] ([i915#6621]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@i915_pm_rps@basic-api.html - bat-dg2-8: NOTRUN -> [SKIP][30] ([i915#6621]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@i915_pm_rps@basic-api.html - bat-arls-3: NOTRUN -> [SKIP][31] ([i915#10209]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@i915_pm_rps@basic-api.html - bat-mtlp-6: NOTRUN -> [SKIP][32] ([i915#6621]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@i915_pm_rps@basic-api.html * igt@kms_addfb_basic@addfb25-x-tiled-legacy: - bat-mtlp-6: NOTRUN -> [SKIP][33] ([i915#4212] / [i915#9792]) +8 other tests skip [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html * igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy: - bat-dg2-11: NOTRUN -> [SKIP][34] ([i915#4212]) +7 other tests skip [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy: - bat-mtlp-6: NOTRUN -> [SKIP][35] ([i915#5190] / [i915#9792]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html - bat-dg2-11: NOTRUN -> [SKIP][36] ([i915#5190]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html - bat-dg2-8: NOTRUN -> [SKIP][37] ([i915#5190]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html * igt@kms_addfb_basic@basic-y-tiled-legacy: - bat-dg2-8: NOTRUN -> [SKIP][38] ([i915#4215] / [i915#5190]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html - bat-arls-3: NOTRUN -> [SKIP][39] ([i915#10200]) +9 other tests skip [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@kms_addfb_basic@basic-y-tiled-legacy.html - bat-dg2-11: NOTRUN -> [SKIP][40] ([i915#4215] / [i915#5190]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@kms_addfb_basic@basic-y-tiled-legacy.html * igt@kms_addfb_basic@tile-pitch-mismatch: - bat-dg2-8: NOTRUN -> [SKIP][41] ([i915#4212]) +7 other tests skip [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@kms_addfb_basic@tile-pitch-mismatch.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - bat-dg2-11: NOTRUN -> [SKIP][42] ([i915#4103] / [i915#4213]) +1 other test skip [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html - bat-arls-3: NOTRUN -> [SKIP][43] ([i915#10202]) +1 other test skip [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy: - bat-mtlp-6: NOTRUN -> [SKIP][44] ([i915#9792]) +17 other tests skip [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html * igt@kms_cursor_legacy@basic-flip-before-cursor-legacy: - bat-dg2-8: NOTRUN -> [SKIP][45] ([i915#9197]) +16 other tests skip [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html * igt@kms_dsc@dsc-basic: - bat-dg2-11: NOTRUN -> [SKIP][46] ([i915#3555] / [i915#3840]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@kms_dsc@dsc-basic.html - bat-arls-3: NOTRUN -> [SKIP][47] ([i915#9886]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@kms_dsc@dsc-basic.html * igt@kms_flip@basic-flip-vs-dpms: - bat-mtlp-6: NOTRUN -> [SKIP][48] ([i915#3637] / [i915#9792]) +3 other tests skip [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@kms_flip@basic-flip-vs-dpms.html * igt@kms_force_connector_basic@force-load-detect: - bat-arls-3: NOTRUN -> [SKIP][49] ([i915#10207]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@kms_force_connector_basic@force-load-detect.html - bat-dg2-8: NOTRUN -> [SKIP][50] [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@kms_force_connector_basic@force-load-detect.html - bat-dg2-11: NOTRUN -> [SKIP][51] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_force_connector_basic@prune-stale-modes: - bat-mtlp-6: NOTRUN -> [SKIP][52] ([i915#5274] / [i915#9792]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@kms_force_connector_basic@prune-stale-modes.html - bat-dg2-11: NOTRUN -> [SKIP][53] ([i915#5274]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@kms_force_connector_basic@prune-stale-modes.html - bat-dg2-8: NOTRUN -> [SKIP][54] ([i915#5274]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@kms_force_connector_basic@prune-stale-modes.html * igt@kms_frontbuffer_tracking@basic: - bat-mtlp-6: NOTRUN -> [SKIP][55] ([i915#4342] / [i915#5354] / [i915#9792]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@kms_frontbuffer_tracking@basic.html * igt@kms_hdmi_inject@inject-audio: - fi-apl-guc: NOTRUN -> [SKIP][56] +17 other tests skip [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/fi-apl-guc/igt@kms_hdmi_inject@inject-audio.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-1: - fi-elk-e7500: NOTRUN -> [SKIP][57] +24 other tests skip [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/fi-elk-e7500/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-1.html * igt@kms_pm_backlight@basic-brightness: - bat-dg2-11: NOTRUN -> [SKIP][58] ([i915#5354]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@kms_pm_backlight@basic-brightness.html - bat-dg2-8: NOTRUN -> [SKIP][59] ([i915#5354]) +5 other tests skip [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@kms_pm_backlight@basic-brightness.html - bat-arls-3: NOTRUN -> [SKIP][60] ([i915#9812]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@kms_pm_backlight@basic-brightness.html - bat-mtlp-6: NOTRUN -> [SKIP][61] ([i915#5354] / [i915#9792]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@kms_pm_backlight@basic-brightness.html * igt@kms_psr@psr-cursor-plane-move: - bat-mtlp-6: NOTRUN -> [SKIP][62] ([i915#1072] / [i915#9673] / [i915#9732] / [i915#9792]) +3 other tests skip [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@kms_psr@psr-cursor-plane-move.html * igt@kms_psr@psr-primary-mmap-gtt: - bat-arls-3: NOTRUN -> [SKIP][63] ([i915#9732]) +3 other tests skip [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@kms_psr@psr-primary-mmap-gtt.html * igt@kms_psr@psr-sprite-plane-onoff: - bat-dg2-11: NOTRUN -> [SKIP][64] ([i915#1072] / [i915#9732]) +3 other tests skip [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@kms_psr@psr-sprite-plane-onoff.html - bat-dg2-8: NOTRUN -> [SKIP][65] ([i915#1072] / [i915#9673] / [i915#9732]) +3 other tests skip [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@kms_psr@psr-sprite-plane-onoff.html * igt@kms_setmode@basic-clone-single-crtc: - bat-mtlp-6: NOTRUN -> [SKIP][66] ([i915#3555] / [i915#8809] / [i915#9792]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@kms_setmode@basic-clone-single-crtc.html - bat-dg2-11: NOTRUN -> [SKIP][67] ([i915#3555]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@kms_setmode@basic-clone-single-crtc.html - bat-dg2-8: NOTRUN -> [SKIP][68] ([i915#3555]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@kms_setmode@basic-clone-single-crtc.html - bat-arls-3: NOTRUN -> [SKIP][69] ([i915#10208] / [i915#8809]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-fence-flip: - bat-dg2-11: NOTRUN -> [SKIP][70] ([i915#3708]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@prime_vgem@basic-fence-flip.html - bat-dg2-8: NOTRUN -> [SKIP][71] ([i915#3708] / [i915#9197]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@prime_vgem@basic-fence-flip.html - bat-mtlp-6: NOTRUN -> [SKIP][72] ([i915#3708] / [i915#9792]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@prime_vgem@basic-fence-flip.html * igt@prime_vgem@basic-fence-mmap: - bat-mtlp-6: NOTRUN -> [SKIP][73] ([i915#3708] / [i915#4077]) +1 other test skip [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@prime_vgem@basic-fence-mmap.html * igt@prime_vgem@basic-fence-read: - bat-arls-3: NOTRUN -> [SKIP][74] ([i915#10212] / [i915#3708]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@prime_vgem@basic-fence-read.html * igt@prime_vgem@basic-gtt: - bat-dg2-11: NOTRUN -> [SKIP][75] ([i915#3708] / [i915#4077]) +1 other test skip [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@prime_vgem@basic-gtt.html - bat-arls-3: NOTRUN -> [SKIP][76] ([i915#10196] / [i915#3708] / [i915#4077]) +1 other test skip [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@prime_vgem@basic-gtt.html - bat-dg2-8: NOTRUN -> [SKIP][77] ([i915#3708] / [i915#4077]) +1 other test skip [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@prime_vgem@basic-gtt.html * igt@prime_vgem@basic-read: - bat-mtlp-6: NOTRUN -> [SKIP][78] ([i915#3708]) +1 other test skip [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@prime_vgem@basic-read.html - bat-arls-3: NOTRUN -> [SKIP][79] ([i915#10214] / [i915#3708]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@prime_vgem@basic-read.html * igt@prime_vgem@basic-write: - bat-mtlp-6: NOTRUN -> [SKIP][80] ([i915#10216] / [i915#3708]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-mtlp-6/igt@prime_vgem@basic-write.html - bat-dg2-11: NOTRUN -> [SKIP][81] ([i915#3291] / [i915#3708]) +2 other tests skip [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-11/igt@prime_vgem@basic-write.html - bat-dg2-8: NOTRUN -> [SKIP][82] ([i915#3291] / [i915#3708]) +2 other tests skip [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-dg2-8/igt@prime_vgem@basic-write.html - bat-arls-3: NOTRUN -> [SKIP][83] ([i915#10216] / [i915#3708]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-3/igt@prime_vgem@basic-write.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#10196]: https://gitlab.freedesktop.org/drm/intel/issues/10196 [i915#10197]: https://gitlab.freedesktop.org/drm/intel/issues/10197 [i915#10200]: https://gitlab.freedesktop.org/drm/intel/issues/10200 [i915#10202]: https://gitlab.freedesktop.org/drm/intel/issues/10202 [i915#10206]: https://gitlab.freedesktop.org/drm/intel/issues/10206 [i915#10207]: https://gitlab.freedesktop.org/drm/intel/issues/10207 [i915#10208]: https://gitlab.freedesktop.org/drm/intel/issues/10208 [i915#10209]: https://gitlab.freedesktop.org/drm/intel/issues/10209 [i915#10211]: https://gitlab.freedesktop.org/drm/intel/issues/10211 [i915#10212]: https://gitlab.freedesktop.org/drm/intel/issues/10212 [i915#10213]: https://gitlab.freedesktop.org/drm/intel/issues/10213 [i915#10214]: https://gitlab.freedesktop.org/drm/intel/issues/10214 [i915#10216]: https://gitlab.freedesktop.org/drm/intel/issues/10216 [i915#10436]: https://gitlab.freedesktop.org/drm/intel/issues/10436 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809 [i915#9197]: https://gitlab.freedesktop.org/drm/intel/issues/9197 [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318 [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673 [i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732 [i915#9792]: https://gitlab.freedesktop.org/drm/intel/issues/9792 [i915#9812]: https://gitlab.freedesktop.org/drm/intel/issues/9812 [i915#9886]: https://gitlab.freedesktop.org/drm/intel/issues/9886 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7814 -> IGTPW_11046 CI-20190529: 20190529 CI_DRM_14616: 53dd7a2909139fb469db4423b79d8a2888a734c2 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_11046: 0390be0ee9226e8e53fe6c267e25aea641ec81ff @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git IGT_7814: 7814 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/index.html [-- Attachment #2: Type: text/html, Size: 28340 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence 2024-04-19 19:33 ` ✗ Fi.CI.BAT: failure for " Patchwork @ 2024-04-23 19:54 ` Kamil Konieczny 0 siblings, 0 replies; 5+ messages in thread From: Kamil Konieczny @ 2024-04-23 19:54 UTC (permalink / raw) To: igt-dev; +Cc: Brian Welty, I915-ci-infra Hi igt-dev, On 2024-04-19 at 19:33:45 -0000, Patchwork wrote: > == Series Details == > > Series: tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence > URL : https://patchwork.freedesktop.org/series/132659/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_14616 -> IGTPW_11046 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with IGTPW_11046 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in IGTPW_11046, please notify your bug team ("I915-ci-infra@lists.freedesktop.org") to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/index.html > > Participating hosts (34 -> 39) > ------------------------------ > > Additional (7): bat-kbl-2 bat-mtlp-6 bat-dg2-8 fi-apl-guc fi-elk-e7500 bat-dg2-11 bat-arls-3 > Missing (2): fi-cfl-8109u fi-bsw-n3050 > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in IGTPW_11046: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@gem_exec_gttfill@basic: > - bat-arls-2: [PASS][1] -> [ABORT][2] > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14616/bat-arls-2/igt@gem_exec_gttfill@basic.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-arls-2/igt@gem_exec_gttfill@basic.html > > * igt@i915_pm_rpm@module-reload: > - bat-adlm-1: [PASS][3] -> [INCOMPLETE][4] > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14616/bat-adlm-1/igt@i915_pm_rpm@module-reload.html > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/bat-adlm-1/igt@i915_pm_rpm@module-reload.html > Unrelated to Xe test, no need for respin (already merged). Regards, Kamil > > Known issues > ------------ > > Here are the changes found in IGTPW_11046 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > ...cut... > > > Build changes > ------------- > > * CI: CI-20190529 -> None > * IGT: IGT_7814 -> IGTPW_11046 > > CI-20190529: 20190529 > CI_DRM_14616: 53dd7a2909139fb469db4423b79d8a2888a734c2 @ git://anongit.freedesktop.org/gfx-ci/linux > IGTPW_11046: 0390be0ee9226e8e53fe6c267e25aea641ec81ff @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > IGT_7814: 7814 > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11046/index.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ CI.xeBAT: success for tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence 2024-04-19 18:57 [PATCH i-g-t] tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence Brian Welty 2024-04-19 19:33 ` ✗ Fi.CI.BAT: failure for " Patchwork @ 2024-04-19 21:35 ` Patchwork 2024-04-23 4:36 ` [PATCH i-g-t] " Matt Roper 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2024-04-19 21:35 UTC (permalink / raw) To: Brian Welty; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 8145 bytes --] == Series Details == Series: tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence URL : https://patchwork.freedesktop.org/series/132659/ State : success == Summary == CI Bug Log - changes from XEIGT_7814_BAT -> XEIGTPW_11046_BAT ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (5 -> 4) ------------------------------ Missing (1): bat-lnl-1 Known issues ------------ Here are the changes found in XEIGTPW_11046_BAT that come from known issues: ### IGT changes ### #### Issues hit #### * igt@core_hotunplug@unbind-rebind: - bat-dg2-oem2: [PASS][1] -> [SKIP][2] ([Intel XE#1136]) [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@core_hotunplug@unbind-rebind.html [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@core_hotunplug@unbind-rebind.html * igt@kms_addfb_basic@bad-pitch-128: - bat-dg2-oem2: [PASS][3] -> [SKIP][4] ([i915#2575]) +50 other tests skip [3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@kms_addfb_basic@bad-pitch-128.html [4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@kms_addfb_basic@bad-pitch-128.html * igt@kms_frontbuffer_tracking@basic: - bat-dg2-oem2: [PASS][5] -> [SKIP][6] ([Intel XE#1134]) [5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@kms_frontbuffer_tracking@basic.html [6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@kms_frontbuffer_tracking@basic.html * igt@xe_intel_bb@create-in-region: - bat-dg2-oem2: [PASS][7] -> [SKIP][8] ([Intel XE#1130]) +154 other tests skip [7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@xe_intel_bb@create-in-region.html [8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@xe_intel_bb@create-in-region.html * igt@xe_live_ktest@xe_bo@xe_ccs_migrate_kunit: - bat-dg2-oem2: [PASS][9] -> [SKIP][10] ([Intel XE#1575]) [9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@xe_live_ktest@xe_bo@xe_ccs_migrate_kunit.html [10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@xe_live_ktest@xe_bo@xe_ccs_migrate_kunit.html * igt@xe_live_ktest@xe_migrate: - bat-dg2-oem2: [PASS][11] -> [SKIP][12] ([Intel XE#455]) +5 other tests skip [11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@xe_live_ktest@xe_migrate.html [12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@xe_live_ktest@xe_migrate.html * igt@xe_module_load@load: - bat-dg2-oem2: [PASS][13] -> [FAIL][14] ([Intel XE#1574]) [13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@xe_module_load@load.html [14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@xe_module_load@load.html #### Warnings #### * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy: - bat-dg2-oem2: [SKIP][15] ([Intel XE#623]) -> [SKIP][16] ([i915#2575]) [15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html [16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html * igt@kms_dsc@dsc-basic: - bat-dg2-oem2: [SKIP][17] ([Intel XE#455]) -> [SKIP][18] ([Intel XE#1134]) [17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@kms_dsc@dsc-basic.html [18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@kms_dsc@dsc-basic.html * igt@kms_force_connector_basic@prune-stale-modes: - bat-dg2-oem2: [SKIP][19] ([i915#5274]) -> [SKIP][20] ([i915#2575]) [19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@kms_force_connector_basic@prune-stale-modes.html [20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@kms_force_connector_basic@prune-stale-modes.html * igt@kms_psr@psr-cursor-plane-move: - bat-dg2-oem2: [SKIP][21] ([Intel XE#929]) -> [SKIP][22] ([Intel XE#1134]) +2 other tests skip [21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@kms_psr@psr-cursor-plane-move.html [22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@kms_psr@psr-cursor-plane-move.html * igt@xe_evict@evict-beng-mixed-threads-small-multi-vm: - bat-dg2-oem2: [TIMEOUT][23] ([Intel XE#1259] / [Intel XE#1473]) -> [SKIP][24] ([Intel XE#1130]) [23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@xe_evict@evict-beng-mixed-threads-small-multi-vm.html [24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@xe_evict@evict-beng-mixed-threads-small-multi-vm.html * igt@xe_exec_fault_mode@twice-bindexecqueue-userptr-invalidate: - bat-dg2-oem2: [SKIP][25] ([Intel XE#288]) -> [SKIP][26] ([Intel XE#1130]) +22 other tests skip [25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@xe_exec_fault_mode@twice-bindexecqueue-userptr-invalidate.html [26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@xe_exec_fault_mode@twice-bindexecqueue-userptr-invalidate.html * igt@xe_huc_copy@huc_copy: - bat-dg2-oem2: [SKIP][27] ([Intel XE#255]) -> [SKIP][28] ([Intel XE#1130]) [27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@xe_huc_copy@huc_copy.html [28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@xe_huc_copy@huc_copy.html * igt@xe_pat@pat-index-xe2: - bat-dg2-oem2: [SKIP][29] ([Intel XE#977]) -> [SKIP][30] ([Intel XE#1130]) [29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@xe_pat@pat-index-xe2.html [30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@xe_pat@pat-index-xe2.html * igt@xe_pat@pat-index-xehpc: - bat-dg2-oem2: [SKIP][31] ([Intel XE#979]) -> [SKIP][32] ([Intel XE#1130]) +1 other test skip [31]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7814/bat-dg2-oem2/igt@xe_pat@pat-index-xehpc.html [32]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/bat-dg2-oem2/igt@xe_pat@pat-index-xehpc.html [Intel XE#1130]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1130 [Intel XE#1134]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1134 [Intel XE#1136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1136 [Intel XE#1259]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1259 [Intel XE#1473]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1473 [Intel XE#1574]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1574 [Intel XE#1575]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1575 [Intel XE#255]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/255 [Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288 [Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455 [Intel XE#623]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/623 [Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929 [Intel XE#977]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/977 [Intel XE#979]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/979 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274 Build changes ------------- * IGT: IGT_7814 -> IGTPW_11046 * Linux: xe-1120-915273abf8b69731107af5c86fc8c6014d2b4f21 -> xe-1128-1501acd2d215fa1cc15a93c5bedc40d4776ed696 IGTPW_11046: 0390be0ee9226e8e53fe6c267e25aea641ec81ff @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git IGT_7814: 7814 xe-1120-915273abf8b69731107af5c86fc8c6014d2b4f21: 915273abf8b69731107af5c86fc8c6014d2b4f21 xe-1128-1501acd2d215fa1cc15a93c5bedc40d4776ed696: 1501acd2d215fa1cc15a93c5bedc40d4776ed696 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11046/index.html [-- Attachment #2: Type: text/html, Size: 9761 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH i-g-t] tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence 2024-04-19 18:57 [PATCH i-g-t] tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence Brian Welty 2024-04-19 19:33 ` ✗ Fi.CI.BAT: failure for " Patchwork 2024-04-19 21:35 ` ✓ CI.xeBAT: success " Patchwork @ 2024-04-23 4:36 ` Matt Roper 2 siblings, 0 replies; 5+ messages in thread From: Matt Roper @ 2024-04-23 4:36 UTC (permalink / raw) To: Brian Welty; +Cc: igt-dev, Priyanka Dandamudi, Janga Rahul Kumar On Fri, Apr 19, 2024 at 11:57:39AM -0700, Brian Welty wrote: > When confirming that xe_exec() user_fences completed, this is performed > in a loop. When using __xe_wait_ufence(), it returns an updated timeout > value to reflect how much time was remaining. As side-effect, when calling > in a loop without resetting the timeout, the timeout value will get > progressively smaller over many iterations. > We don't want a smaller timeout to be used on each subsequent call to > __xe_wait_ufence(), so fix here is to reset the timeout inside the loop. > This issue is visible in simulation runs due to the slower execution time, > where later iterations of the wait are failing due to timeout being too > small. > > Signed-off-by: Brian Welty <brian.welty@intel.com> > --- > tests/intel/xe_exec_fault_mode.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/intel/xe_exec_fault_mode.c b/tests/intel/xe_exec_fault_mode.c > index 40fe1743e4..c0d082e7fa 100644 > --- a/tests/intel/xe_exec_fault_mode.c > +++ b/tests/intel/xe_exec_fault_mode.c > @@ -273,11 +273,12 @@ test_exec(int fd, struct drm_xe_engine_class_instance *eci, > } > } > if (!(flags & INVALID_FAULT)) { > - int64_t timeout = ONE_SEC; > + int64_t timeout; Should we just move the whole variable declaration down inside the loop? There doesn't appear to be a need to declare it at this level. Either way, Reviewed-by: Matt Roper <matthew.d.roper@intel.com> > > j = flags & INVALIDATE ? n_execs - 1 : 0; > > for (i = j; i < n_execs; i++) { > + timeout = ONE_SEC; > if (flags & INVALID_VA && !(flags & ENABLE_SCRATCH)) > igt_assert_eq(__xe_wait_ufence(fd, &data[i].exec_sync, USER_FENCE_VALUE, > exec_queues[i % n_exec_queues], &timeout), -EIO); > -- > 2.43.0 > -- Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-04-23 19:54 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-04-19 18:57 [PATCH i-g-t] tests/intel/xe_exec_fault_mode: Fix misuse of __xe_wait_ufence Brian Welty 2024-04-19 19:33 ` ✗ Fi.CI.BAT: failure for " Patchwork 2024-04-23 19:54 ` Kamil Konieczny 2024-04-19 21:35 ` ✓ CI.xeBAT: success " Patchwork 2024-04-23 4:36 ` [PATCH i-g-t] " Matt Roper
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox