Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t 0/2] Cleanup indentation on Intel JSON files
@ 2024-04-25  8:49 Mauro Carvalho Chehab
  2024-04-25  8:49 ` [PATCH i-g-t 1/2] tests/intel/kms_test_config.json: fix indentation Mauro Carvalho Chehab
  2024-04-25  8:49 ` [PATCH i-g-t 2/2] tests/intel/*.json: remove some uneeded whitespaces Mauro Carvalho Chehab
  0 siblings, 2 replies; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2024-04-25  8:49 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

Having an uniform notation at the JSON files is a good thing,
as it makes easier to maintain it.

Ensure that all 3 Intel JSON test plan config files are using the
same notation by running:

   cat tests/intel/xe_test_config.json |jq --indent 4 >a && mv a tests/intel/xe_test_config.json
   cat tests/intel/kms_test_config.json |jq --indent 4 >a && mv a tests/intel/kms_test_config.json
   cat tests/intel/i915_test_config.json |jq --indent 4 >a && mv a tests/intel/i915_test_config.json

And then verifying the results, committing the changes that
are worth and ensuring that all 3 files will follow the same
style.

Mauro Carvalho Chehab (2):
  tests/intel/kms_test_config.json: fix indentation
  tests/intel/*.json: remove some uneeded whitespaces

 tests/intel/i915_test_config.json | 4 ++--
 tests/intel/kms_test_config.json  | 8 ++++----
 tests/intel/xe_test_config.json   | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

-- 
2.44.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH i-g-t 1/2] tests/intel/kms_test_config.json: fix indentation
  2024-04-25  8:49 [PATCH i-g-t 0/2] Cleanup indentation on Intel JSON files Mauro Carvalho Chehab
@ 2024-04-25  8:49 ` Mauro Carvalho Chehab
  2024-04-25 10:01   ` Kamil Konieczny
  2024-04-25  8:49 ` [PATCH i-g-t 2/2] tests/intel/*.json: remove some uneeded whitespaces Mauro Carvalho Chehab
  1 sibling, 1 reply; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2024-04-25  8:49 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

There are some wrong indentation at Run Type. Fix it.

No functional changes.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/intel/kms_test_config.json | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/intel/kms_test_config.json b/tests/intel/kms_test_config.json
index 7c37c831b72c..5c8db82dfc73 100644
--- a/tests/intel/kms_test_config.json
+++ b/tests/intel/kms_test_config.json
@@ -23,9 +23,9 @@
                     "exclude": [
                         { "i915 BAT, i915 BAT chamelium, i915 chamelium, i915 FULL": "../intel-ci/blacklist.txt" },
                             { "Xe BAT, Xe BAT chamelium, Xe FULL": "../intel-ci/xe.blocklist.txt" }
-                        ]
-                    }
-                },
+                    ]
+                }
+            },
             "Category": {
                 "_properties_": {
                     "description": "Contains the major group for the tested functionality 'Display'"
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH i-g-t 2/2] tests/intel/*.json: remove some uneeded whitespaces
  2024-04-25  8:49 [PATCH i-g-t 0/2] Cleanup indentation on Intel JSON files Mauro Carvalho Chehab
  2024-04-25  8:49 ` [PATCH i-g-t 1/2] tests/intel/kms_test_config.json: fix indentation Mauro Carvalho Chehab
@ 2024-04-25  8:49 ` Mauro Carvalho Chehab
  2024-04-25 10:02   ` Kamil Konieczny
  1 sibling, 1 reply; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2024-04-25  8:49 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

To make the file more uniform, remove some extra whitespaces
after a couple of field names at those files.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/intel/i915_test_config.json | 4 ++--
 tests/intel/kms_test_config.json  | 2 +-
 tests/intel/xe_test_config.json   | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/intel/i915_test_config.json b/tests/intel/i915_test_config.json
index f51ae2a55bdd..26e47215248d 100644
--- a/tests/intel/i915_test_config.json
+++ b/tests/intel/i915_test_config.json
@@ -91,7 +91,7 @@
                 "description": "Describes any GPU-specific requrirement, like requiring multi-tiles."
             }
         },
-        "Depends on" : {
+        "Depends on": {
             "_properties_": {
                 "description": "List other subtests that are required to not be skipped before calling this one."
             }
@@ -101,7 +101,7 @@
                 "description": "Point to known missing features at the test or subtest."
             }
         },
-        "Description" : {
+        "Description": {
             "_properties_": {
                 "description": "Provides a description for the test/subtest."
             }
diff --git a/tests/intel/kms_test_config.json b/tests/intel/kms_test_config.json
index 5c8db82dfc73..bca3b250fffb 100644
--- a/tests/intel/kms_test_config.json
+++ b/tests/intel/kms_test_config.json
@@ -52,7 +52,7 @@
                 "description": "Defines the test category. Usually used at subtest level."
             }
         },
-        "Description" : {
+        "Description": {
             "_properties_": {
                 "description": "Provides a description for the test/subtest."
             }
diff --git a/tests/intel/xe_test_config.json b/tests/intel/xe_test_config.json
index f8888341475a..3775e63fc65e 100644
--- a/tests/intel/xe_test_config.json
+++ b/tests/intel/xe_test_config.json
@@ -79,7 +79,7 @@
                 "description": "Describes any GPU-specific requrirement, like requiring multi-tiles."
             }
         },
-        "Depends on" : {
+        "Depends on": {
             "_properties_": {
                 "description": "List other subtests that are required to not be skipped before calling this one."
             }
@@ -89,7 +89,7 @@
                 "description": "Point to known missing features at the test or subtest."
             }
         },
-        "Description" : {
+        "Description": {
             "_properties_": {
                 "mandatory": true,
                 "description": "Provides a description for the test/subtest."
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH i-g-t 1/2] tests/intel/kms_test_config.json: fix indentation
  2024-04-25  8:49 ` [PATCH i-g-t 1/2] tests/intel/kms_test_config.json: fix indentation Mauro Carvalho Chehab
@ 2024-04-25 10:01   ` Kamil Konieczny
  0 siblings, 0 replies; 5+ messages in thread
From: Kamil Konieczny @ 2024-04-25 10:01 UTC (permalink / raw)
  To: igt-dev; +Cc: Mauro Carvalho Chehab, Mauro Carvalho Chehab

Hi Mauro,
On 2024-04-25 at 10:49:22 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> There are some wrong indentation at Run Type. Fix it.
> 
> No functional changes.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  tests/intel/kms_test_config.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/intel/kms_test_config.json b/tests/intel/kms_test_config.json
> index 7c37c831b72c..5c8db82dfc73 100644
> --- a/tests/intel/kms_test_config.json
> +++ b/tests/intel/kms_test_config.json
> @@ -23,9 +23,9 @@
>                      "exclude": [
>                          { "i915 BAT, i915 BAT chamelium, i915 chamelium, i915 FULL": "../intel-ci/blacklist.txt" },
>                              { "Xe BAT, Xe BAT chamelium, Xe FULL": "../intel-ci/xe.blocklist.txt" }
> -                        ]
> -                    }
> -                },
> +                    ]
> +                }
> +            },
>              "Category": {
>                  "_properties_": {
>                      "description": "Contains the major group for the tested functionality 'Display'"
> -- 
> 2.44.0
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH i-g-t 2/2] tests/intel/*.json: remove some uneeded whitespaces
  2024-04-25  8:49 ` [PATCH i-g-t 2/2] tests/intel/*.json: remove some uneeded whitespaces Mauro Carvalho Chehab
@ 2024-04-25 10:02   ` Kamil Konieczny
  0 siblings, 0 replies; 5+ messages in thread
From: Kamil Konieczny @ 2024-04-25 10:02 UTC (permalink / raw)
  To: igt-dev; +Cc: Mauro Carvalho Chehab, Mauro Carvalho Chehab

Hi Mauro,
On 2024-04-25 at 10:49:23 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> To make the file more uniform, remove some extra whitespaces
> after a couple of field names at those files.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  tests/intel/i915_test_config.json | 4 ++--
>  tests/intel/kms_test_config.json  | 2 +-
>  tests/intel/xe_test_config.json   | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/intel/i915_test_config.json b/tests/intel/i915_test_config.json
> index f51ae2a55bdd..26e47215248d 100644
> --- a/tests/intel/i915_test_config.json
> +++ b/tests/intel/i915_test_config.json
> @@ -91,7 +91,7 @@
>                  "description": "Describes any GPU-specific requrirement, like requiring multi-tiles."
>              }
>          },
> -        "Depends on" : {
> +        "Depends on": {
>              "_properties_": {
>                  "description": "List other subtests that are required to not be skipped before calling this one."
>              }
> @@ -101,7 +101,7 @@
>                  "description": "Point to known missing features at the test or subtest."
>              }
>          },
> -        "Description" : {
> +        "Description": {
>              "_properties_": {
>                  "description": "Provides a description for the test/subtest."
>              }
> diff --git a/tests/intel/kms_test_config.json b/tests/intel/kms_test_config.json
> index 5c8db82dfc73..bca3b250fffb 100644
> --- a/tests/intel/kms_test_config.json
> +++ b/tests/intel/kms_test_config.json
> @@ -52,7 +52,7 @@
>                  "description": "Defines the test category. Usually used at subtest level."
>              }
>          },
> -        "Description" : {
> +        "Description": {
>              "_properties_": {
>                  "description": "Provides a description for the test/subtest."
>              }
> diff --git a/tests/intel/xe_test_config.json b/tests/intel/xe_test_config.json
> index f8888341475a..3775e63fc65e 100644
> --- a/tests/intel/xe_test_config.json
> +++ b/tests/intel/xe_test_config.json
> @@ -79,7 +79,7 @@
>                  "description": "Describes any GPU-specific requrirement, like requiring multi-tiles."
>              }
>          },
> -        "Depends on" : {
> +        "Depends on": {
>              "_properties_": {
>                  "description": "List other subtests that are required to not be skipped before calling this one."
>              }
> @@ -89,7 +89,7 @@
>                  "description": "Point to known missing features at the test or subtest."
>              }
>          },
> -        "Description" : {
> +        "Description": {
>              "_properties_": {
>                  "mandatory": true,
>                  "description": "Provides a description for the test/subtest."
> -- 
> 2.44.0
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-04-25 10:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-25  8:49 [PATCH i-g-t 0/2] Cleanup indentation on Intel JSON files Mauro Carvalho Chehab
2024-04-25  8:49 ` [PATCH i-g-t 1/2] tests/intel/kms_test_config.json: fix indentation Mauro Carvalho Chehab
2024-04-25 10:01   ` Kamil Konieczny
2024-04-25  8:49 ` [PATCH i-g-t 2/2] tests/intel/*.json: remove some uneeded whitespaces Mauro Carvalho Chehab
2024-04-25 10:02   ` Kamil Konieczny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox