Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t 0/1] lib/xe/xe_query: Wait for xe_supports_faults
@ 2024-05-03 19:37 Jonathan Cavitt
  2024-05-03 19:37 ` [PATCH i-g-t 1/1] " Jonathan Cavitt
                   ` (4 more replies)
  0 siblings, 5 replies; 15+ messages in thread
From: Jonathan Cavitt @ 2024-05-03 19:37 UTC (permalink / raw)
  To: igt-dev
  Cc: saurabhg.gupta, jonathan.cavitt, brian.welty, tomasz.mistat,
	himanshu.girotra

It's possible for xe_supports_faults to return false if the system is
busy with multiple running tests.  This is because the check looks for
all active VMs and searches for VMs that do not have faults enabled,
returning false if any exist.  Recently, this check has been changed to
return EBUSY when the check fails in this way, so wait for up to ten
seconds for all the active VMs to flush out before proceeding.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1562
Test-with: 20240503190138.1958302-1-jonathan.cavitt@intel.com
Suggested-by: Brian Welty <brian.welty@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>

Jonathan Cavitt (1):
  lib/xe/xe_query: Wait for xe_supports_faults

 lib/xe/xe_query.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [PATCH i-g-t 0/1] lib/xe/xe_query: Wait for xe_supports_faults
@ 2024-05-08 19:35 Jonathan Cavitt
  2024-05-08 19:35 ` [PATCH i-g-t 1/1] " Jonathan Cavitt
  0 siblings, 1 reply; 15+ messages in thread
From: Jonathan Cavitt @ 2024-05-08 19:35 UTC (permalink / raw)
  To: igt-dev
  Cc: jonathan.cavitt, saurabhg.gupta, brian.welty, tomasz.mistat,
	himanshu.girotra, kamil.konieczny

It's possible for xe_supports_faults to return false if the system is
busy with multiple running tests.  This is because the check looks for
all active VMs and searches for VMs that do not have faults enabled,
returning false if any exist.  Recently, this check has been changed to
return EBUSY when the check fails in this way, so wait for up to ten
seconds for all the active VMs to flush out before proceeding.

v2:
- Remove loop from lib version of xe_supports_faults.
- Change xe_supports_faults to instead return the return value of the
  ioctl call used for the check.
- Loop when xe_supports_faults is called instead if the return value is
  -EBUSY.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1562
Test-with: 20240503190138.1958302-1-jonathan.cavitt@intel.com
Suggested-by: Brian Welty <brian.welty@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>

Jonathan Cavitt (1):
  lib/xe/xe_query: Wait for xe_supports_faults

 lib/xe/xe_query.c                | 15 ++++++++-------
 lib/xe/xe_query.h                |  2 +-
 tests/intel/xe_exec_fault_mode.c |  9 ++++++++-
 3 files changed, 17 insertions(+), 9 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2024-05-10 15:58 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-03 19:37 [PATCH i-g-t 0/1] lib/xe/xe_query: Wait for xe_supports_faults Jonathan Cavitt
2024-05-03 19:37 ` [PATCH i-g-t 1/1] " Jonathan Cavitt
2024-05-08 16:23   ` Kamil Konieczny
2024-05-08 16:43     ` Cavitt, Jonathan
2024-05-08 17:11       ` Kamil Konieczny
2024-05-09  1:27         ` Welty, Brian
2024-05-09 14:27           ` Cavitt, Jonathan
2024-05-03 20:31 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-05-03 20:47 ` ✓ CI.xeBAT: " Patchwork
2024-05-03 23:16 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-04  7:50 ` ✗ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-05-08 19:35 [PATCH i-g-t 0/1] " Jonathan Cavitt
2024-05-08 19:35 ` [PATCH i-g-t 1/1] " Jonathan Cavitt
2024-05-09 16:20   ` Kamil Konieczny
2024-05-09 16:30     ` Cavitt, Jonathan
2024-05-10 15:58       ` Kamil Konieczny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox