From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t v3 10/13] lib/igt_drm_clients: Record drm-cycles
Date: Fri, 3 May 2024 23:46:40 -0700 [thread overview]
Message-ID: <20240504064643.25863-11-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20240504064643.25863-1-lucas.demarchi@intel.com>
Record drm-cycles and delta between 2 sample updates, just like done
with engine time. This also duplicates the utilization_mask so it's
available to the next layer.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
lib/igt_drm_clients.c | 30 ++++++++++++++++++++++--------
lib/igt_drm_clients.h | 10 ++++++++++
2 files changed, 32 insertions(+), 8 deletions(-)
diff --git a/lib/igt_drm_clients.c b/lib/igt_drm_clients.c
index 91d71a7bd..fbbb763f7 100644
--- a/lib/igt_drm_clients.c
+++ b/lib/igt_drm_clients.c
@@ -105,18 +105,32 @@ igt_drm_client_update(struct igt_drm_client *c, unsigned int pid, char *name,
c->agg_delta_engine_time = 0;
c->total_engine_time = 0;
+ c->agg_delta_cycles = 0;
+ c->total_cycles = 0;
for (i = 0; i <= c->engines->max_engine_id; i++) {
assert(i < ARRAY_SIZE(info->engine_time));
+ assert(i < ARRAY_SIZE(info->cycles));
+
+ if (info->utilization_mask & DRM_FDINFO_UTILIZATION_ENGINE_TIME &&
+ info->engine_time[i] >= c->utilization[i].last_engine_time) {
+ c->utilization_mask |= IGT_DRM_CLIENT_UTILIZATION_ENGINE_TIME;
+ c->total_engine_time += info->engine_time[i];
+ c->utilization[i].delta_engine_time =
+ info->engine_time[i] - c->utilization[i].last_engine_time;
+ c->agg_delta_engine_time += c->utilization[i].delta_engine_time;
+ c->utilization[i].last_engine_time = info->engine_time[i];
+ }
- if (info->engine_time[i] < c->utilization[i].last_engine_time)
- continue; /* It will catch up soon. */
-
- c->total_engine_time += info->engine_time[i];
- c->utilization[i].delta_engine_time =
- info->engine_time[i] - c->utilization[i].last_engine_time;
- c->agg_delta_engine_time += c->utilization[i].delta_engine_time;
- c->utilization[i].last_engine_time = info->engine_time[i];
+ if (info->utilization_mask & DRM_FDINFO_UTILIZATION_CYCLES &&
+ info->cycles[i] >= c->utilization[i].last_cycles) {
+ c->utilization_mask |= IGT_DRM_CLIENT_UTILIZATION_CYCLES;
+ c->total_cycles += info->cycles[i];
+ c->utilization[i].delta_cycles =
+ info->cycles[i] - c->utilization[i].last_cycles;
+ c->agg_delta_cycles += c->utilization[i].delta_cycles;
+ c->utilization[i].last_cycles = info->cycles[i];
+ }
}
/* Memory regions */
diff --git a/lib/igt_drm_clients.h b/lib/igt_drm_clients.h
index d44daa6dc..514c09e71 100644
--- a/lib/igt_drm_clients.h
+++ b/lib/igt_drm_clients.h
@@ -33,6 +33,11 @@ enum igt_drm_client_status {
IGT_DRM_CLIENT_PROBE
};
+enum igt_drm_client_utilization_type {
+ IGT_DRM_CLIENT_UTILIZATION_ENGINE_TIME = 1U << 0,
+ IGT_DRM_CLIENT_UTILIZATION_CYCLES = 1U << 1,
+};
+
struct igt_drm_client_engines {
unsigned int num_engines; /* Number of discovered active engines. */
unsigned int max_engine_id; /* Largest engine index discovered.
@@ -64,11 +69,16 @@ struct igt_drm_client {
char print_name[24]; /* Name without any non-printable characters. */
unsigned int samples; /* Count of times scanning updated this client. */
+ uint32_t utilization_mask; /* mask of enum igt_drm_client_utilization_type */
unsigned long total_engine_time; /* Aggregate of @utilization.agg_delta_engine_time, i.e. engine time on all engines since client start. */
unsigned long agg_delta_engine_time; /* Aggregate of @utilization.delta_engine_time, i.e. engine time on all engines since previous scan. */
+ unsigned long total_cycles; /* Aggregate of @utilization.agg_delta_cycles, i.e. engine time on all engines since client start. */
+ unsigned long agg_delta_cycles; /* Aggregate of @utilization.delta_cycles, i.e. engine time on all engines since previous scan. */
struct igt_drm_client_utilization {
unsigned long delta_engine_time; /* Engine time data, relative to previous scan. */
+ unsigned long delta_cycles; /* Engine cycles data, relative to previous scan. */
uint64_t last_engine_time; /* Engine time data as parsed from fdinfo. */
+ uint64_t last_cycles; /* Engine cycles data as parsed from fdinfo. */
} *utilization; /* Array of engine utilization */
struct drm_client_meminfo *memory; /* Array of region memory utilisation as parsed from fdinfo. */
--
2.43.0
next prev parent reply other threads:[~2024-05-04 6:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 6:46 [PATCH i-g-t v3 00/12] gputop: Add support for xe Lucas De Marchi
2024-05-04 6:46 ` [PATCH i-g-t v3 01/13] lib/igt_drm_fdinfo: Extract ignore_space() Lucas De Marchi
2024-05-06 20:21 ` Umesh Nerlige Ramappa
2024-05-04 6:46 ` [PATCH i-g-t v3 02/13] lib/igt_drm_fdinfo: Allow any number of spaces before unit Lucas De Marchi
2024-05-06 20:28 ` Umesh Nerlige Ramappa
2024-05-06 20:32 ` Umesh Nerlige Ramappa
2024-05-06 20:38 ` Lucas De Marchi
2024-05-04 6:46 ` [PATCH i-g-t v3 03/13] fixup! " Lucas De Marchi
2024-05-06 20:33 ` Umesh Nerlige Ramappa
2024-05-04 6:46 ` [PATCH i-g-t v3 04/13] lib/igt_drm_fdinfo: Stop passing key twice Lucas De Marchi
2024-05-04 6:46 ` [PATCH i-g-t v3 05/13] lib/igt_drm_fdinfo: Remove prefix arg from parse functions Lucas De Marchi
2024-05-04 6:46 ` [PATCH i-g-t v3 06/13] lib/igt_drm_fdinfo: Parse drm-cycles Lucas De Marchi
2024-05-07 1:11 ` Umesh Nerlige Ramappa
2024-05-04 6:46 ` [PATCH i-g-t v3 07/13] lib/igt_drm_fdinfo: Start tracking available engine keys Lucas De Marchi
2024-05-07 1:14 ` Umesh Nerlige Ramappa
2024-05-04 6:46 ` [PATCH i-g-t v3 08/13] treewide: Rename engine busyness variables Lucas De Marchi
2024-05-08 18:45 ` Umesh Nerlige Ramappa
2024-05-21 13:47 ` Lucas De Marchi
2024-05-04 6:46 ` [PATCH i-g-t v3 09/13] lib/igt_drm_clients: Move engine fields to substruct Lucas De Marchi
2024-05-08 18:45 ` Umesh Nerlige Ramappa
2024-05-04 6:46 ` Lucas De Marchi [this message]
2024-05-08 18:48 ` [PATCH i-g-t v3 10/13] lib/igt_drm_clients: Record drm-cycles Umesh Nerlige Ramappa
2024-05-04 6:46 ` [PATCH i-g-t v3 11/13] lib/igt_drm_fdinfo: Parse drm-total-cycles Lucas De Marchi
2024-05-08 18:49 ` Umesh Nerlige Ramappa
2024-05-04 6:46 ` [PATCH i-g-t v3 12/13] lib/igt_drm_clients: Record total cycles Lucas De Marchi
2024-05-08 19:01 ` Umesh Nerlige Ramappa
2024-05-08 19:07 ` Umesh Nerlige Ramappa
2024-05-04 6:46 ` [PATCH i-g-t v3 13/13] gputop: Add support to drm-cycles/drm-total-cycles Lucas De Marchi
2024-05-08 19:11 ` Umesh Nerlige Ramappa
2024-05-04 7:31 ` ✓ Fi.CI.BAT: success for gputop: Add support for xe (rev4) Patchwork
2024-05-04 7:36 ` ✓ CI.xeBAT: " Patchwork
2024-05-04 8:33 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-04 12:50 ` ✗ Fi.CI.IGT: " Patchwork
2024-05-06 10:37 ` [PATCH i-g-t v3 00/12] gputop: Add support for xe Tvrtko Ursulin
2024-05-06 20:40 ` Lucas De Marchi
2024-05-08 16:25 ` (subset) " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504064643.25863-11-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox