Re: [PATCH i-g-t v3 00/12] gputop: Add support for xe

[Tvrtko Ursulin <tursulin@ursulin.net>]

On 04/05/2024 07:46, Lucas De Marchi wrote:
> v3 of https://lore.kernel.org/all/20240423234431.1959354-1-lucas.demarchi@intel.com
> 
> I moved some gputop eye candy to a separate series:
> https://lore.kernel.org/all/20240501173303.115737-1-lucas.demarchi@intel.com
> 
> This now also moves all the refactors to come as prep patches. The
> drm-total-cycles addition is  in the last 3 patches.
> 
> As requested fdinfo and drm-clients libraries now don't take any
> decision: they only read the fdinfo and calculate the deltas
> respectively. The decision about what aproach to use to calculate the
> client utilization is left to gputop.

Approach LGTM so ack for the series. Hopefully someone else can do the 
detailed review.

Just two observations - 3/13 I don't know what the "fixup" is, supposed 
to be and 12/13 incorrectly mentions it is adding some assert to 
intel_gpu_top.

Regards,

Tvrtko

> Lucas De Marchi (13):
>    lib/igt_drm_fdinfo: Extract ignore_space()
>    lib/igt_drm_fdinfo: Allow any number of spaces before unit
>    fixup! lib/igt_drm_fdinfo: Allow any number of spaces before unit
>    lib/igt_drm_fdinfo: Stop passing key twice
>    lib/igt_drm_fdinfo: Remove prefix arg from parse functions
>    lib/igt_drm_fdinfo: Parse drm-cycles
>    lib/igt_drm_fdinfo: Start tracking available engine keys
>    treewide: Rename engine busyness variables
>    lib/igt_drm_clients: Move engine fields to substruct
>    lib/igt_drm_clients: Record drm-cycles
>    lib/igt_drm_fdinfo: Parse drm-total-cycles
>    lib/igt_drm_clients: Record total cycles
>    gputop: Add support to drm-cycles/drm-total-cycles
> 
>   lib/igt_drm_clients.c    |  55 ++++++++++----
>   lib/igt_drm_clients.h    |  27 ++++++-
>   lib/igt_drm_fdinfo.c     | 154 +++++++++++++++++++++------------------
>   lib/igt_drm_fdinfo.h     |  17 ++++-
>   tests/intel/drm_fdinfo.c |  44 +++++------
>   tools/gputop.c           |  45 ++++++++++--
>   tools/intel_gpu_top.c    |  24 +++---
>   7 files changed, 235 insertions(+), 131 deletions(-)
>