From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
"Karolina Stolarek" <karolina.stolarek@intel.com>
Subject: [PATCH i-g-t v4 02/11] lib/intel_blt: Rename confusing fb tile to i915 tile
Date: Wed, 8 May 2024 14:54:34 +0200 [thread overview]
Message-ID: <20240508125443.404402-3-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20240508125443.404402-1-zbigniew.kempczynski@intel.com>
Fb tile is defacto drm modifier, thus blt_tile_to_fb_tile() name
is confusing as it converts to I915_TILING*, not drm modifier.
Lets rename it.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
lib/intel_blt.c | 4 ++--
lib/intel_blt.h | 2 +-
tests/intel/xe_render_copy.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/intel_blt.c b/lib/intel_blt.c
index 4da5cc855e..5a281036c4 100644
--- a/lib/intel_blt.c
+++ b/lib/intel_blt.c
@@ -536,14 +536,14 @@ static int __block_tiling(enum blt_tiling_type tiling)
}
/**
- * blt_tile_to_fb_tile:
+ * blt_tile_to_i915_tile:
* @tiling: tiling id
*
* Returns:
* id of tiling introduced in i915 like I915_TILING_* used for example
* in render-copy code.
*/
-int blt_tile_to_fb_tile(enum blt_tiling_type tiling)
+int blt_tile_to_i915_tile(enum blt_tiling_type tiling)
{
switch (tiling) {
case T_LINEAR: return I915_TILING_NONE;
diff --git a/lib/intel_blt.h b/lib/intel_blt.h
index cc59666862..fcfce69bee 100644
--- a/lib/intel_blt.h
+++ b/lib/intel_blt.h
@@ -213,7 +213,7 @@ bool blt_platform_has_flat_ccs_enabled(int fd);
bool blt_uses_extended_block_copy(int fd);
const char *blt_tiling_name(enum blt_tiling_type tiling);
-int blt_tile_to_fb_tile(enum blt_tiling_type tiling);
+int blt_tile_to_i915_tile(enum blt_tiling_type tiling);
uint32_t blt_get_min_stride(uint32_t width, uint32_t bpp,
enum blt_tiling_type tiling);
diff --git a/tests/intel/xe_render_copy.c b/tests/intel/xe_render_copy.c
index 4f98cb7dfa..ef75c4ce6d 100644
--- a/tests/intel/xe_render_copy.c
+++ b/tests/intel/xe_render_copy.c
@@ -407,7 +407,7 @@ igt_main_args("dpiW:H:", NULL, help_str, opt_handler, NULL)
continue;
tiling_name = blt_tiling_name(tiling);
- tiling = blt_tile_to_fb_tile(tiling);
+ tiling = blt_tile_to_i915_tile(tiling);
igt_dynamic_f("render-%s-%ux%u", tiling_name, surfwidth, surfheight)
render(bops, tiling, surfwidth, surfheight, id);
}
--
2.34.1
next prev parent reply other threads:[~2024-05-08 12:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 12:54 [PATCH i-g-t v4 00/11] Add render-copy compression on Xe+ Zbigniew Kempczyński
2024-05-08 12:54 ` [PATCH i-g-t v4 01/11] lib/intel_bufops: Store devid on buffer ops creation Zbigniew Kempczyński
2024-05-08 12:54 ` Zbigniew Kempczyński [this message]
2024-05-08 12:54 ` [PATCH i-g-t v4 03/11] lib/intel_blt: Add i915 -> blt tile helper converter Zbigniew Kempczyński
2024-05-08 12:54 ` [PATCH i-g-t v4 04/11] lib/intel_bufops: Restrict tilings on non-flatccs platforms Zbigniew Kempczyński
2024-05-08 12:54 ` [PATCH i-g-t v4 05/11] lib/intel_bufops: Start supporting compression on Xe2+ Zbigniew Kempczyński
2024-05-08 12:54 ` [PATCH i-g-t v4 06/11] lib/rendercopy_gen9: Separate xe and xe2 compression format Zbigniew Kempczyński
2024-05-08 12:54 ` [PATCH i-g-t v4 07/11] lib/intel_cmds_info: Define tiling macros Zbigniew Kempczyński
2024-05-08 12:54 ` [PATCH i-g-t v4 08/11] lib/intel_cmds_info: Introduce render tilings Zbigniew Kempczyński
2024-05-08 12:54 ` [PATCH i-g-t v4 09/11] lib/intel_blt: Add render tilings and compression support helper Zbigniew Kempczyński
2024-05-08 12:54 ` [PATCH i-g-t v4 10/11] tests/xe_render_copy: Add subtest which exercises compression Zbigniew Kempczyński
2024-05-08 12:54 ` [PATCH i-g-t v4 11/11] tests/xe_intel_bb: Use supported tilings instead hardcoded ones Zbigniew Kempczyński
2024-05-09 5:18 ` Karolina Stolarek
2024-05-08 17:41 ` ✓ CI.xeBAT: success for Add render-copy compression on Xe+ (rev4) Patchwork
2024-05-08 17:48 ` ✓ Fi.CI.BAT: " Patchwork
2024-05-09 3:22 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-09 8:34 ` ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508125443.404402-3-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karolina.stolarek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox