Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Zack Rusin <zack.rusin@broadcom.com>
To: igt-dev@lists.freedesktop.org
Cc: ian.forbes@broadcom.com, martin.krastev@broadcom.com,
	maaz.mombasawala@broadcom.com,
	Maaz Mombasawala <mombasawalam@vmware.com>,
	Martin Krastev <krastevm@vmware.com>,
	Ian Forbes <iforbes@vmware.com>,
	Zack Rusin <zack.rusin@broadcom.com>
Subject: [PATCH i-g-t 1/3] tests/vmwgfx: Removing incorrect assert in mob_repeated_unref
Date: Thu,  9 May 2024 15:15:27 -0400	[thread overview]
Message-ID: <20240509191529.3783796-2-zack.rusin@broadcom.com> (raw)
In-Reply-To: <20240509191529.3783796-1-zack.rusin@broadcom.com>

From: Maaz Mombasawala <mombasawalam@vmware.com>

Remove an incorrect assert in test mob_repeated_unref that checked if return
value from multiple unrefs of a mob was 0. This was a bug in the vmwgfx driver,
since after the first unref it should return -EINVAL.
This bug was fixed with buffer rework in the vmwgfx driver and now the unref
ioctl behaves the correct way.

Signed-off-by: Maaz Mombasawala <mombasawalam@vmware.com>
Reviewed-by: Martin Krastev <krastevm@vmware.com>
Reviewed-by: Ian Forbes <iforbes@vmware.com>
Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
---
 tests/vmwgfx/vmw_ref_count.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/vmwgfx/vmw_ref_count.c b/tests/vmwgfx/vmw_ref_count.c
index da4b41f89..92d49dbd0 100644
--- a/tests/vmwgfx/vmw_ref_count.c
+++ b/tests/vmwgfx/vmw_ref_count.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0 OR MIT
 /**********************************************************
- * Copyright 2021-2022 VMware, Inc.
+ * Copyright 2021-2023 VMware, Inc.
  *
  * Permission is hereby granted, free of charge, to any person
  * obtaining a copy of this software and associated documentation
@@ -256,13 +256,11 @@ igt_main
 
 		/* Shouldn't crash on multiple invocations */
 		for (i = 0; i < 3; i++) {
-			int ret;
 			struct drm_vmw_handle_close_arg arg = {
 				.handle = mob->handle
 			};
-			ret = drmCommandWrite(fd1, DRM_VMW_HANDLE_CLOSE, &arg,
+			drmCommandWrite(fd1, DRM_VMW_HANDLE_CLOSE, &arg,
 					      sizeof(arg));
-			igt_assert_eq(ret, 0);
 		}
 		free(mob);
 	}
-- 
2.40.1


  reply	other threads:[~2024-05-09 19:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-09 19:15 [PATCH i-g-t 0/3] Add vmwgfx prime tests Zack Rusin
2024-05-09 19:15 ` Zack Rusin [this message]
2024-05-13 14:01   ` [PATCH i-g-t 1/3] tests/vmwgfx: Removing incorrect assert in mob_repeated_unref Kamil Konieczny
2024-05-09 19:15 ` [PATCH i-g-t 2/3] lib/vmwgfx: Allow using any buffer handle as a surface backing Zack Rusin
2024-05-09 19:15 ` [PATCH i-g-t 3/3] tests/vmwgfx: Add a prime test Zack Rusin
2024-05-10 12:29   ` Kamil Konieczny
2024-05-09 20:36 ` ✗ Fi.CI.BAT: failure for Add vmwgfx prime tests Patchwork
2024-05-09 20:48 ` ✓ CI.xeBAT: success " Patchwork
2024-05-10  1:26 ` ✗ CI.xeFULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240509191529.3783796-2-zack.rusin@broadcom.com \
    --to=zack.rusin@broadcom.com \
    --cc=ian.forbes@broadcom.com \
    --cc=iforbes@vmware.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=krastevm@vmware.com \
    --cc=maaz.mombasawala@broadcom.com \
    --cc=martin.krastev@broadcom.com \
    --cc=mombasawalam@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox