Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Add gputop support for sysfs profiling knob
@ 2024-05-10 19:22 Adrián Larumbe
  2024-05-10 19:22 ` [PATCH v3 1/2] lib: Add DRM driver sysfs profiling knob toggling functions Adrián Larumbe
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Adrián Larumbe @ 2024-05-10 19:22 UTC (permalink / raw)
  To: tursulin, robdclark, kamil.konieczny, lucas.demarchi, igt-dev
  Cc: healych, adrian.larumbe, kernel

Some GPUs like Panfrost need a sysfs file to be toggled before the HW can
initiate the job accounting necessary to feed fdinfo with engine and cycle
data. This sysfs knob has to be disabled when the profiler is done, to save
power.

Changelog:

v3:
 - Created separate lib_igt_profiling to avoid dynamic linking
 of gputop with igt_lib, which also meant isolating the functions
 therein from the rest of igt_lib.
 - Make gputop check the sysfs knob state at the end of every period
 in case other instances of itself or other profilers might have
 changed it, so that the knob can be returned to its original state.
v2:
 - Added header file guards around igt_profiling.h
 - Modified licensing information to comply with SPDX format
 - Sorted included header files in alphabetic order
 - Added volatile qualifier to gputop stop variable

Adrián Larumbe (2):
  lib: Add DRM driver sysfs profiling knob toggling functions
  tools/gputop: toggle sysfs profiling knob if available for device

 lib/igt_profiling.c | 141 ++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_profiling.h |  21 +++++++
 lib/meson.build     |   8 +++
 tools/gputop.c      |  33 ++++++++++-
 tools/meson.build   |   2 +-
 5 files changed, 203 insertions(+), 2 deletions(-)
 create mode 100644 lib/igt_profiling.c
 create mode 100644 lib/igt_profiling.h


base-commit: 4a5fd4e7cb2798636f6464e2bd61399f3242b322
-- 
2.44.0


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH v3 0/2] Add gputop support for sysfs profiling knob
@ 2024-05-10 19:15 Adrián Larumbe
  0 siblings, 0 replies; 13+ messages in thread
From: Adrián Larumbe @ 2024-05-10 19:15 UTC (permalink / raw)
  To: tvrtko.ursulin, robdclark, kamil.konieczny, lucas.demarchi,
	igt-dev
  Cc: healych, adrian.larumbe, kernel

Some GPUs like Panfrost need a sysfs file to be toggled before the HW can
initiate the job accounting necessary to feed fdinfo with engine and cycle
data. This sysfs knob has to be disabled when the profiler is done, to save
power.

Changelog:

v3:
 - Created separate lib_igt_profiling to avoid dynamic linking
 of gputop with igt_lib, which also meant isolating the functions
 therein from the rest of igt_lib.
 - Make gputop check the sysfs knob state at the end of every period
 in case other instances of itself or other profilers might have
 changed it, so that the knob can be returned to its original state.
v2:
 - Added header file guards around igt_profiling.h
 - Modified licensing information to comply with SPDX format
 - Sorted included header files in alphabetic order
 - Added volatile qualifier to gputop stop variable

Adrián Larumbe (2):
  lib: Add DRM driver sysfs profiling knob toggling functions
  tools/gputop: toggle sysfs profiling knob if available for device

 lib/igt_profiling.c | 141 ++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_profiling.h |  21 +++++++
 lib/meson.build     |   8 +++
 tools/gputop.c      |  33 ++++++++++-
 tools/meson.build   |   2 +-
 5 files changed, 203 insertions(+), 2 deletions(-)
 create mode 100644 lib/igt_profiling.c
 create mode 100644 lib/igt_profiling.h


base-commit: 4a5fd4e7cb2798636f6464e2bd61399f3242b322
-- 
2.44.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-05-20  7:24 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-10 19:22 [PATCH v3 0/2] Add gputop support for sysfs profiling knob Adrián Larumbe
2024-05-10 19:22 ` [PATCH v3 1/2] lib: Add DRM driver sysfs profiling knob toggling functions Adrián Larumbe
2024-05-15 17:50   ` Kamil Konieczny
2024-05-16 19:52     ` Adrián Larumbe
2024-05-10 19:22 ` [PATCH v3 2/2] tools/gputop: toggle sysfs profiling knob if available for device Adrián Larumbe
2024-05-13  7:17   ` Zbigniew Kempczyński
2024-05-16 19:49     ` Adrián Larumbe
2024-05-20  7:24       ` Zbigniew Kempczyński
2024-05-10 20:39 ` ✓ CI.xeBAT: success for Add gputop support for sysfs profiling knob Patchwork
2024-05-10 20:40 ` ✓ Fi.CI.BAT: " Patchwork
2024-05-10 23:14 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-12 16:45 ` ✗ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-05-10 19:15 [PATCH v3 0/2] " Adrián Larumbe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox