* [PATCH i-g-t 0/3] fix kms_be test
@ 2024-05-12 16:01 Kunal Joshi
2024-05-12 16:01 ` [PATCH i-g-t 1/3] tests/kms_bw: convert to dynamic subtest Kunal Joshi
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Kunal Joshi @ 2024-05-12 16:01 UTC (permalink / raw)
To: igt-dev; +Cc: Kunal Joshi
first patch converts the test structure to a dynamic subtest format,
reducing skip counts due to missing configurations.
The second patch restricts the test to run only on
physically connected displays, addressing issues with
forced 4K EDID on disconnected connectors.
Kunal Joshi (3):
tests/kms_bw: convert to dynamic subtest
tests/kms_bw: allow physically connected only
HAX patch do not merge
tests/intel-ci/fast-feedback.testlist | 5 +-
tests/kms_bw.c | 81 +++++++++++++--------------
2 files changed, 42 insertions(+), 44 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH i-g-t 1/3] tests/kms_bw: convert to dynamic subtest 2024-05-12 16:01 [PATCH i-g-t 0/3] fix kms_be test Kunal Joshi @ 2024-05-12 16:01 ` Kunal Joshi 2024-05-13 11:59 ` Kamil Konieczny 2024-05-12 16:01 ` [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only Kunal Joshi ` (2 subsequent siblings) 3 siblings, 1 reply; 10+ messages in thread From: Kunal Joshi @ 2024-05-12 16:01 UTC (permalink / raw) To: igt-dev; +Cc: Kunal Joshi Convert the test structure from individual subtests for each display mode (1080, 2k, 4k...) and display count (1, 2... n) to a dynamic subtest structure. The change addresses the issue of high skip counts due to potentially missing configurations, which previously required blacklisting. In the new structure, the display mode is set at the subtest level, while the number of displays is dynamic. This ensures that the subtest passes regardless of the number of connected displays. To cover all scenarios, it may be necessary to connect the maximum possible number of displays. Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> --- tests/kms_bw.c | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/tests/kms_bw.c b/tests/kms_bw.c index 05f7e79ad..b50f324af 100644 --- a/tests/kms_bw.c +++ b/tests/kms_bw.c @@ -37,12 +37,10 @@ #include <xf86drmMode.h> /** - * SUBTEST: linear-tiling-%d-displays-%s - * Description: bw test with %arg[2] + * SUBTEST: linear-tiling-%s + * Description: bw test with %arg[1] * - * arg[1].values: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16 - * - * arg[2]: + * arg[1]: * * @1920x1080p: 1920x1080 resolution * @2560x1440p: 2560x1440 resolution @@ -62,6 +60,7 @@ typedef struct data { int w[IGT_MAX_PIPES]; int h[IGT_MAX_PIPES]; int fd; + int num_pipes; } data_t; static drmModeModeInfo test_mode[] = { @@ -178,16 +177,10 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo igt_output_t *output; struct igt_fb buffer[IGT_MAX_PIPES]; igt_crc_t zero, captured[IGT_MAX_PIPES]; - int i = 0, num_pipes = 0; - enum pipe p; int ret; - /* Cannot use igt_display_get_n_pipes() due to fused pipes on i915 where they do - * not give the numver of valid crtcs and always return IGT_MAX_PIPES */ - for_each_pipe(display, p) num_pipes++; - - igt_skip_on_f(pipe >= num_pipes, - "ASIC does not have %d pipes\n", pipe); + igt_skip_on_f(pipe >= data->num_pipes, + "ASIC does not have %d pipes\n", pipe); test_init(data); @@ -244,28 +237,37 @@ igt_main { data_t data; int i = 0, j = 0; + enum pipe p; memset(&data, 0, sizeof(data)); igt_fixture { data.fd = drm_open_driver_master(DRIVER_ANY); + data.num_pipes = 0; kmstest_set_vt_graphics_mode(); igt_display_require(&data.display, data.fd); igt_require(&data.display.is_atomic); igt_display_require_output(&data.display); + /* + * Cannot use igt_display_get_n_pipes() due to fused pipes on i915 where they do + * not give the numver of valid crtcs and always return IGT_MAX_PIPES + */ + for_each_pipe(&data.display, p) data.num_pipes++; } /* We're not using for_each_pipe_static because we need the * _amount_ of pipes */ - for (i = 0; i < IGT_MAX_PIPES; i++) { - for (j = 0; j < ARRAY_SIZE(test_mode); j++) { - igt_subtest_f("linear-tiling-%d-displays-%s", i+1, - test_mode[j].name) - run_test_linear_tiling(&data, i, &test_mode[j]); + for (j = 0; j < ARRAY_SIZE(test_mode); j++) { + igt_subtest_with_dynamic_f("linear-tiling-%s", test_mode[j].name) + { + for (i = 0; i < data.num_pipes; i++) { + igt_dynamic_f("%d-display%s", i+1, i == 0 ? "" : "s") + run_test_linear_tiling(&data, i, &test_mode[j]); + } } } -- 2.34.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH i-g-t 1/3] tests/kms_bw: convert to dynamic subtest 2024-05-12 16:01 ` [PATCH i-g-t 1/3] tests/kms_bw: convert to dynamic subtest Kunal Joshi @ 2024-05-13 11:59 ` Kamil Konieczny 0 siblings, 0 replies; 10+ messages in thread From: Kamil Konieczny @ 2024-05-13 11:59 UTC (permalink / raw) To: igt-dev; +Cc: Kunal Joshi Hi Kunal, On 2024-05-12 at 21:31:56 +0530, Kunal Joshi wrote: > Convert the test structure from individual subtests for each > display mode (1080, 2k, 4k...) and display count (1, 2... n) > to a dynamic subtest structure. The change addresses the issue > of high skip counts due to potentially missing configurations, > which previously required blacklisting. --------------------------- ^^^^^^^^^^^^ s/blacklisting./blocking./ > > In the new structure, the display mode is set at the subtest level, > while the number of displays is dynamic. This ensures that the subtest > passes regardless of the number of connected displays. > To cover all scenarios, it may be necessary to connect the > maximum possible number of displays. Looks like it still skips, please see CI results. Could you just assume that when run, it has at least one connected display and skip only for no connected? Regards, Kamil > > Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> > --- > tests/kms_bw.c | 38 ++++++++++++++++++++------------------ > 1 file changed, 20 insertions(+), 18 deletions(-) > > diff --git a/tests/kms_bw.c b/tests/kms_bw.c > index 05f7e79ad..b50f324af 100644 > --- a/tests/kms_bw.c > +++ b/tests/kms_bw.c > @@ -37,12 +37,10 @@ > #include <xf86drmMode.h> > > /** > - * SUBTEST: linear-tiling-%d-displays-%s > - * Description: bw test with %arg[2] > + * SUBTEST: linear-tiling-%s > + * Description: bw test with %arg[1] > * > - * arg[1].values: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16 > - * > - * arg[2]: > + * arg[1]: > * > * @1920x1080p: 1920x1080 resolution > * @2560x1440p: 2560x1440 resolution > @@ -62,6 +60,7 @@ typedef struct data { > int w[IGT_MAX_PIPES]; > int h[IGT_MAX_PIPES]; > int fd; > + int num_pipes; > } data_t; > > static drmModeModeInfo test_mode[] = { > @@ -178,16 +177,10 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo > igt_output_t *output; > struct igt_fb buffer[IGT_MAX_PIPES]; > igt_crc_t zero, captured[IGT_MAX_PIPES]; > - int i = 0, num_pipes = 0; > - enum pipe p; > int ret; > > - /* Cannot use igt_display_get_n_pipes() due to fused pipes on i915 where they do > - * not give the numver of valid crtcs and always return IGT_MAX_PIPES */ > - for_each_pipe(display, p) num_pipes++; > - > - igt_skip_on_f(pipe >= num_pipes, > - "ASIC does not have %d pipes\n", pipe); > + igt_skip_on_f(pipe >= data->num_pipes, > + "ASIC does not have %d pipes\n", pipe); > > test_init(data); > > @@ -244,28 +237,37 @@ igt_main > { > data_t data; > int i = 0, j = 0; > + enum pipe p; > > memset(&data, 0, sizeof(data)); > > igt_fixture > { > data.fd = drm_open_driver_master(DRIVER_ANY); > + data.num_pipes = 0; > > kmstest_set_vt_graphics_mode(); > > igt_display_require(&data.display, data.fd); > igt_require(&data.display.is_atomic); > igt_display_require_output(&data.display); > + /* > + * Cannot use igt_display_get_n_pipes() due to fused pipes on i915 where they do > + * not give the numver of valid crtcs and always return IGT_MAX_PIPES > + */ > + for_each_pipe(&data.display, p) data.num_pipes++; > > } > > /* We're not using for_each_pipe_static because we need the > * _amount_ of pipes */ > - for (i = 0; i < IGT_MAX_PIPES; i++) { > - for (j = 0; j < ARRAY_SIZE(test_mode); j++) { > - igt_subtest_f("linear-tiling-%d-displays-%s", i+1, > - test_mode[j].name) > - run_test_linear_tiling(&data, i, &test_mode[j]); > + for (j = 0; j < ARRAY_SIZE(test_mode); j++) { > + igt_subtest_with_dynamic_f("linear-tiling-%s", test_mode[j].name) > + { > + for (i = 0; i < data.num_pipes; i++) { > + igt_dynamic_f("%d-display%s", i+1, i == 0 ? "" : "s") > + run_test_linear_tiling(&data, i, &test_mode[j]); > + } > } > } > > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only 2024-05-12 16:01 [PATCH i-g-t 0/3] fix kms_be test Kunal Joshi 2024-05-12 16:01 ` [PATCH i-g-t 1/3] tests/kms_bw: convert to dynamic subtest Kunal Joshi @ 2024-05-12 16:01 ` Kunal Joshi 2024-05-13 12:10 ` Kamil Konieczny 2024-05-12 16:01 ` [PATCH i-g-t 3/3] HAX patch do not merge Kunal Joshi 2024-05-12 16:19 ` ✗ Fi.CI.BAT: failure for fix kms_be test Patchwork 3 siblings, 1 reply; 10+ messages in thread From: Kunal Joshi @ 2024-05-12 16:01 UTC (permalink / raw) To: igt-dev; +Cc: Kunal Joshi modify kms_bw test to only run on physically connected displays, avoiding issues with forcing a 4K EDID on disconnected connectors. For instance, consider a system with 2 DP and 2 HDMI connectors (DP-1, DP-2, HDMI-1, HDMI-2). Forcing EDID on DP is currently problematic, and we only support forcing for HDMI. However, if there's only one TMDS encoder, we can only drive one HDMI display, not two. For now, the test will only run on physically connected displays. Future improvements may consider the encoder count to handle such scenarios more gracefully. Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> --- tests/kms_bw.c | 43 ++++++++++++++++++------------------------- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/tests/kms_bw.c b/tests/kms_bw.c index b50f324af..4aabb02b7 100644 --- a/tests/kms_bw.c +++ b/tests/kms_bw.c @@ -61,6 +61,7 @@ typedef struct data { int h[IGT_MAX_PIPES]; int fd; int num_pipes; + int num_outputs; } data_t; static drmModeModeInfo test_mode[] = { @@ -105,8 +106,9 @@ static drmModeModeInfo test_mode[] = { static void test_init(data_t *data) { igt_display_t *display = &data->display; - int i, max_pipes = display->n_pipes; + int i; igt_output_t *output; + data->num_outputs = 0; for_each_pipe(display, i) { data->pipe_id[i] = i; @@ -118,23 +120,22 @@ static void test_init(data_t *data) IGT_PIPE_CRC_SOURCE_AUTO); } - for (i = 0; i < display->n_outputs && i < max_pipes; i++) { - if (!data->pipe[i]) - continue; - - output = &display->outputs[i]; - - data->output[i] = output; + i = 0; + for_each_output(display, output) { /* Only allow physically connected displays for the tests. */ if (!igt_output_is_connected(output)) continue; + data->output[i] = output; + data->num_outputs++; + igt_assert(kmstest_get_connector_default_mode( data->fd, output->config.connector, &data->mode[i])); data->w[i] = data->mode[i].hdisplay; data->h[i] = data->mode[i].vdisplay; + i++; } @@ -156,27 +157,12 @@ static void test_fini(data_t *data) igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0); } -/* Forces a mode for a connector. */ -static void force_output_mode(data_t *d, igt_output_t *output, - const drmModeModeInfo *mode) -{ - /* This allows us to create a virtual sink. */ - if (!igt_output_is_connected(output)) { - kmstest_force_edid(d->fd, output->config.connector, - igt_kms_get_4k_edid()); - - kmstest_force_connector(d->fd, output->config.connector, - FORCE_CONNECTOR_DIGITAL); - } - - igt_output_override_mode(output, mode); -} - static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo *mode) { igt_display_t *display = &data->display; igt_output_t *output; struct igt_fb buffer[IGT_MAX_PIPES]; igt_crc_t zero, captured[IGT_MAX_PIPES]; + int i = 0; int ret; igt_skip_on_f(pipe >= data->num_pipes, @@ -184,6 +170,10 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo test_init(data); + igt_skip_on_f(pipe >= data->num_outputs, + "%d connected outputs required but found %d\n", + pipe+1, data->num_outputs+1); + /* create buffers */ for (i = 0; i <= pipe; i++) { output = data->output[i]; @@ -191,7 +181,7 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo continue; } - force_output_mode(data, output, mode); + igt_output_override_mode(output, mode); igt_create_color_fb(display->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, @@ -199,6 +189,9 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo &buffer[i]); igt_output_set_pipe(output, i); + igt_info("Assigned output %s to pipe %s with mode %dx%d@%d\n", + igt_output_name(output), kmstest_pipe_name(i), + mode->hdisplay, mode->vdisplay, mode->vrefresh); igt_plane_set_fb(data->primary[i], &buffer[i]); } -- 2.34.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only 2024-05-12 16:01 ` [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only Kunal Joshi @ 2024-05-13 12:10 ` Kamil Konieczny 0 siblings, 0 replies; 10+ messages in thread From: Kamil Konieczny @ 2024-05-13 12:10 UTC (permalink / raw) To: igt-dev; +Cc: Kunal Joshi Hi Kunal, On 2024-05-12 at 21:31:57 +0530, Kunal Joshi wrote: > modify kms_bw test to only run on physically connected displays, --^ Start from uppercase. > avoiding issues with forcing a 4K EDID on disconnected connectors. > > For instance, consider a system with 2 DP and 2 HDMI connectors > (DP-1, DP-2, HDMI-1, HDMI-2). Forcing EDID on DP is currently problematic, > and we only support forcing for HDMI. However, if there's only one > TMDS encoder, we can only drive one HDMI display, not two. > > For now, the test will only run on physically connected displays. > Future improvements may consider the encoder count to handle such > scenarios more gracefully. > Add to cc a few amd devs. Regards, Kamil > Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> > --- > tests/kms_bw.c | 43 ++++++++++++++++++------------------------- > 1 file changed, 18 insertions(+), 25 deletions(-) > > diff --git a/tests/kms_bw.c b/tests/kms_bw.c > index b50f324af..4aabb02b7 100644 > --- a/tests/kms_bw.c > +++ b/tests/kms_bw.c > @@ -61,6 +61,7 @@ typedef struct data { > int h[IGT_MAX_PIPES]; > int fd; > int num_pipes; > + int num_outputs; > } data_t; > > static drmModeModeInfo test_mode[] = { > @@ -105,8 +106,9 @@ static drmModeModeInfo test_mode[] = { > static void test_init(data_t *data) > { > igt_display_t *display = &data->display; > - int i, max_pipes = display->n_pipes; > + int i; > igt_output_t *output; > + data->num_outputs = 0; > > for_each_pipe(display, i) { > data->pipe_id[i] = i; > @@ -118,23 +120,22 @@ static void test_init(data_t *data) > IGT_PIPE_CRC_SOURCE_AUTO); > } > > - for (i = 0; i < display->n_outputs && i < max_pipes; i++) { > - if (!data->pipe[i]) > - continue; > - > - output = &display->outputs[i]; > - > - data->output[i] = output; > + i = 0; > > + for_each_output(display, output) { > /* Only allow physically connected displays for the tests. */ > if (!igt_output_is_connected(output)) > continue; > > + data->output[i] = output; > + data->num_outputs++; > + > igt_assert(kmstest_get_connector_default_mode( > data->fd, output->config.connector, &data->mode[i])); > > data->w[i] = data->mode[i].hdisplay; > data->h[i] = data->mode[i].vdisplay; > + i++; > } > > > @@ -156,27 +157,12 @@ static void test_fini(data_t *data) > igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0); > } > > -/* Forces a mode for a connector. */ > -static void force_output_mode(data_t *d, igt_output_t *output, > - const drmModeModeInfo *mode) > -{ > - /* This allows us to create a virtual sink. */ > - if (!igt_output_is_connected(output)) { > - kmstest_force_edid(d->fd, output->config.connector, > - igt_kms_get_4k_edid()); > - > - kmstest_force_connector(d->fd, output->config.connector, > - FORCE_CONNECTOR_DIGITAL); > - } > - > - igt_output_override_mode(output, mode); > -} > - > static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo *mode) { > igt_display_t *display = &data->display; > igt_output_t *output; > struct igt_fb buffer[IGT_MAX_PIPES]; > igt_crc_t zero, captured[IGT_MAX_PIPES]; > + int i = 0; > int ret; > > igt_skip_on_f(pipe >= data->num_pipes, > @@ -184,6 +170,10 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo > > test_init(data); > > + igt_skip_on_f(pipe >= data->num_outputs, > + "%d connected outputs required but found %d\n", > + pipe+1, data->num_outputs+1); > + > /* create buffers */ > for (i = 0; i <= pipe; i++) { > output = data->output[i]; > @@ -191,7 +181,7 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo > continue; > } > > - force_output_mode(data, output, mode); > + igt_output_override_mode(output, mode); > > igt_create_color_fb(display->drm_fd, mode->hdisplay, > mode->vdisplay, DRM_FORMAT_XRGB8888, > @@ -199,6 +189,9 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo > &buffer[i]); > > igt_output_set_pipe(output, i); > + igt_info("Assigned output %s to pipe %s with mode %dx%d@%d\n", > + igt_output_name(output), kmstest_pipe_name(i), > + mode->hdisplay, mode->vdisplay, mode->vrefresh); > > igt_plane_set_fb(data->primary[i], &buffer[i]); > } > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH i-g-t 3/3] HAX patch do not merge 2024-05-12 16:01 [PATCH i-g-t 0/3] fix kms_be test Kunal Joshi 2024-05-12 16:01 ` [PATCH i-g-t 1/3] tests/kms_bw: convert to dynamic subtest Kunal Joshi 2024-05-12 16:01 ` [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only Kunal Joshi @ 2024-05-12 16:01 ` Kunal Joshi 2024-05-12 16:19 ` ✗ Fi.CI.BAT: failure for fix kms_be test Patchwork 3 siblings, 0 replies; 10+ messages in thread From: Kunal Joshi @ 2024-05-12 16:01 UTC (permalink / raw) To: igt-dev; +Cc: Kunal Joshi HAX patch do not merge Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> --- tests/intel-ci/fast-feedback.testlist | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index be0965110..10f54d516 100644 --- a/tests/intel-ci/fast-feedback.testlist +++ b/tests/intel-ci/fast-feedback.testlist @@ -1,6 +1,9 @@ # Try to load the driver if it's not available yet. igt@i915_module_load@load - +igt@kms_bw@linear-tiling-1920x1080p +igt@kms_bw@linear-tiling-2560x1440p +igt@kms_bw@linear-tiling-3840x2160p +igt@kms_bw@linear-tiling-2160x1440p # Keep alphabetically sorted by default igt@core_auth@basic-auth igt@debugfs_test@read_all_entries -- 2.34.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✗ Fi.CI.BAT: failure for fix kms_be test 2024-05-12 16:01 [PATCH i-g-t 0/3] fix kms_be test Kunal Joshi ` (2 preceding siblings ...) 2024-05-12 16:01 ` [PATCH i-g-t 3/3] HAX patch do not merge Kunal Joshi @ 2024-05-12 16:19 ` Patchwork 3 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2024-05-12 16:19 UTC (permalink / raw) To: Kunal Joshi; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 21353 bytes --] == Series Details == Series: fix kms_be test URL : https://patchwork.freedesktop.org/series/133510/ State : failure == Summary == CI Bug Log - changes from IGT_7847 -> IGTPW_11132 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_11132 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_11132, please notify your bug team ('I915-ci-infra@lists.freedesktop.org') to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/index.html Participating hosts (36 -> 40) ------------------------------ Additional (6): bat-kbl-2 fi-tgl-1115g4 fi-glk-j4005 fi-cfl-8109u fi-kbl-8809g bat-jsl-1 Missing (2): bat-mtlp-8 fi-snb-2520m Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_11132: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_fence@basic-await@bcs0: - bat-adlm-1: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7847/bat-adlm-1/igt@gem_exec_fence@basic-await@bcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-adlm-1/igt@gem_exec_fence@basic-await@bcs0.html * igt@i915_pm_rpm@module-reload: - bat-dg2-14: [PASS][3] -> [INCOMPLETE][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7847/bat-dg2-14/igt@i915_pm_rpm@module-reload.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-dg2-14/igt@i915_pm_rpm@module-reload.html * {igt@kms_bw@linear-tiling-1920x1080p@2-displays} (NEW): - bat-rplp-1: NOTRUN -> [SKIP][5] +11 other tests skip [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-rplp-1/igt@kms_bw@linear-tiling-1920x1080p@2-displays.html - fi-rkl-11600: NOTRUN -> [SKIP][6] +8 other tests skip [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-rkl-11600/igt@kms_bw@linear-tiling-1920x1080p@2-displays.html * {igt@kms_bw@linear-tiling-1920x1080p@3-displays} (NEW): - bat-dg1-7: NOTRUN -> [SKIP][7] +12 other tests skip [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-dg1-7/igt@kms_bw@linear-tiling-1920x1080p@3-displays.html - {bat-twl-1}: NOTRUN -> [SKIP][8] +7 other tests skip [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-twl-1/igt@kms_bw@linear-tiling-1920x1080p@3-displays.html * {igt@kms_bw@linear-tiling-1920x1080p@4-displays} (NEW): - bat-adlp-9: NOTRUN -> [SKIP][9] +11 other tests skip [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-adlp-9/igt@kms_bw@linear-tiling-1920x1080p@4-displays.html - {bat-rpls-4}: NOTRUN -> [SKIP][10] +8 other tests skip [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-rpls-4/igt@kms_bw@linear-tiling-1920x1080p@4-displays.html * {igt@kms_bw@linear-tiling-2160x1440p@3-displays} (NEW): - bat-arls-2: NOTRUN -> [SKIP][11] +11 other tests skip [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-arls-2/igt@kms_bw@linear-tiling-2160x1440p@3-displays.html - bat-adln-1: NOTRUN -> [SKIP][12] +7 other tests skip [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-adln-1/igt@kms_bw@linear-tiling-2160x1440p@3-displays.html - {bat-arls-4}: NOTRUN -> [SKIP][13] +11 other tests skip [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-arls-4/igt@kms_bw@linear-tiling-2160x1440p@3-displays.html - bat-jsl-1: NOTRUN -> [SKIP][14] +7 other tests skip [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-jsl-1/igt@kms_bw@linear-tiling-2160x1440p@3-displays.html * {igt@kms_bw@linear-tiling-2560x1440p@2-displays} (NEW): - bat-arls-1: NOTRUN -> [SKIP][15] +11 other tests skip [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-arls-1/igt@kms_bw@linear-tiling-2560x1440p@2-displays.html * {igt@kms_bw@linear-tiling-2560x1440p@3-displays} (NEW): - {bat-mtlp-9}: NOTRUN -> [SKIP][16] +8 other tests skip [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-mtlp-9/igt@kms_bw@linear-tiling-2560x1440p@3-displays.html - bat-jsl-3: NOTRUN -> [SKIP][17] +7 other tests skip [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-jsl-3/igt@kms_bw@linear-tiling-2560x1440p@3-displays.html * {igt@kms_bw@linear-tiling-2560x1440p@4-displays} (NEW): - bat-adls-6: NOTRUN -> [SKIP][18] +9 other tests skip [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-adls-6/igt@kms_bw@linear-tiling-2560x1440p@4-displays.html - fi-tgl-1115g4: NOTRUN -> [SKIP][19] +12 other tests skip [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-tgl-1115g4/igt@kms_bw@linear-tiling-2560x1440p@4-displays.html * {igt@kms_bw@linear-tiling-3840x2160p@1-display} (NEW): - bat-dg2-14: NOTRUN -> [SKIP][20] +15 other tests skip [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-dg2-14/igt@kms_bw@linear-tiling-3840x2160p@1-display.html * {igt@kms_bw@linear-tiling-3840x2160p@4-displays} (NEW): - bat-adlp-6: NOTRUN -> [SKIP][21] +7 other tests skip [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-adlp-6/igt@kms_bw@linear-tiling-3840x2160p@4-displays.html New tests --------- New tests have been introduced between IGT_7847 and IGTPW_11132: ### New IGT tests (20) ### * igt@kms_bw@linear-tiling-1920x1080p: - Statuses : 9 skip(s) - Exec time: [0.0] s * igt@kms_bw@linear-tiling-1920x1080p@1-display: - Statuses : 25 pass(s) 5 skip(s) - Exec time: [0.02, 0.69] s * igt@kms_bw@linear-tiling-1920x1080p@2-displays: - Statuses : 5 pass(s) 25 skip(s) - Exec time: [0.0, 1.55] s * igt@kms_bw@linear-tiling-1920x1080p@3-displays: - Statuses : 26 skip(s) - Exec time: [0.0, 0.00] s * igt@kms_bw@linear-tiling-1920x1080p@4-displays: - Statuses : 12 skip(s) - Exec time: [0.0, 0.00] s * igt@kms_bw@linear-tiling-2160x1440p: - Statuses : 9 skip(s) - Exec time: [0.0] s * igt@kms_bw@linear-tiling-2160x1440p@1-display: - Statuses : 24 pass(s) 6 skip(s) - Exec time: [0.02, 1.59] s * igt@kms_bw@linear-tiling-2160x1440p@2-displays: - Statuses : 5 pass(s) 25 skip(s) - Exec time: [0.0, 1.75] s * igt@kms_bw@linear-tiling-2160x1440p@3-displays: - Statuses : 26 skip(s) - Exec time: [0.0, 0.00] s * igt@kms_bw@linear-tiling-2160x1440p@4-displays: - Statuses : 12 skip(s) - Exec time: [0.0, 0.00] s * igt@kms_bw@linear-tiling-2560x1440p: - Statuses : 9 skip(s) - Exec time: [0.0] s * igt@kms_bw@linear-tiling-2560x1440p@1-display: - Statuses : 22 pass(s) 8 skip(s) - Exec time: [0.01, 1.55] s * igt@kms_bw@linear-tiling-2560x1440p@2-displays: - Statuses : 5 pass(s) 25 skip(s) - Exec time: [0.0, 2.20] s * igt@kms_bw@linear-tiling-2560x1440p@3-displays: - Statuses : 26 skip(s) - Exec time: [0.0, 0.00] s * igt@kms_bw@linear-tiling-2560x1440p@4-displays: - Statuses : 12 skip(s) - Exec time: [0.0, 0.00] s * igt@kms_bw@linear-tiling-3840x2160p: - Statuses : 9 skip(s) - Exec time: [0.0] s * igt@kms_bw@linear-tiling-3840x2160p@1-display: - Statuses : 16 pass(s) 14 skip(s) - Exec time: [0.01, 1.66] s * igt@kms_bw@linear-tiling-3840x2160p@2-displays: - Statuses : 2 pass(s) 28 skip(s) - Exec time: [0.0, 1.60] s * igt@kms_bw@linear-tiling-3840x2160p@3-displays: - Statuses : 26 skip(s) - Exec time: [0.0, 0.00] s * igt@kms_bw@linear-tiling-3840x2160p@4-displays: - Statuses : 12 skip(s) - Exec time: [0.0, 0.00] s Known issues ------------ Here are the changes found in IGTPW_11132 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@basic-hwmon: - bat-jsl-1: NOTRUN -> [SKIP][22] ([i915#9318]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-jsl-1/igt@debugfs_test@basic-hwmon.html - fi-tgl-1115g4: NOTRUN -> [SKIP][23] ([i915#9318]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html * igt@fbdev@info: - bat-kbl-2: NOTRUN -> [SKIP][24] ([i915#1849]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-kbl-2/igt@fbdev@info.html * igt@gem_huc_copy@huc-copy: - fi-cfl-8109u: NOTRUN -> [SKIP][25] ([i915#2190]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-cfl-8109u/igt@gem_huc_copy@huc-copy.html - fi-kbl-8809g: NOTRUN -> [SKIP][26] ([i915#2190]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html - fi-tgl-1115g4: NOTRUN -> [SKIP][27] ([i915#2190]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html - bat-jsl-1: NOTRUN -> [SKIP][28] ([i915#2190]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-jsl-1/igt@gem_huc_copy@huc-copy.html - fi-glk-j4005: NOTRUN -> [SKIP][29] ([i915#2190]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-glk-j4005/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-glk-j4005: NOTRUN -> [SKIP][30] ([i915#4613]) +3 other tests skip [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-glk-j4005/igt@gem_lmem_swapping@basic.html - fi-kbl-8809g: NOTRUN -> [SKIP][31] ([i915#4613]) +3 other tests skip [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-kbl-8809g/igt@gem_lmem_swapping@basic.html * igt@gem_lmem_swapping@parallel-random-engines: - bat-kbl-2: NOTRUN -> [SKIP][32] +43 other tests skip [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-kbl-2/igt@gem_lmem_swapping@parallel-random-engines.html - fi-tgl-1115g4: NOTRUN -> [SKIP][33] ([i915#4613]) +3 other tests skip [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-tgl-1115g4/igt@gem_lmem_swapping@parallel-random-engines.html * igt@gem_lmem_swapping@verify-random: - fi-cfl-8109u: NOTRUN -> [SKIP][34] ([i915#4613]) +3 other tests skip [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-cfl-8109u/igt@gem_lmem_swapping@verify-random.html - bat-jsl-1: NOTRUN -> [SKIP][35] ([i915#4613]) +3 other tests skip [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-jsl-1/igt@gem_lmem_swapping@verify-random.html * {igt@kms_bw@linear-tiling-1920x1080p} (NEW): - fi-kbl-8809g: NOTRUN -> [SKIP][36] +34 other tests skip [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-kbl-8809g/igt@kms_bw@linear-tiling-1920x1080p.html - bat-dg2-8: NOTRUN -> [SKIP][37] ([i915#9197]) +3 other tests skip [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-dg2-8/igt@kms_bw@linear-tiling-1920x1080p.html - fi-kbl-guc: NOTRUN -> [SKIP][38] +3 other tests skip [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-kbl-guc/igt@kms_bw@linear-tiling-1920x1080p.html - bat-adlm-1: NOTRUN -> [SKIP][39] ([i915#9900]) +3 other tests skip [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-adlm-1/igt@kms_bw@linear-tiling-1920x1080p.html * {igt@kms_bw@linear-tiling-1920x1080p@1-display} (NEW): - fi-blb-e6850: NOTRUN -> [SKIP][40] +7 other tests skip [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-blb-e6850/igt@kms_bw@linear-tiling-1920x1080p@1-display.html - fi-bsw-n3050: NOTRUN -> [SKIP][41] +11 other tests skip [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-bsw-n3050/igt@kms_bw@linear-tiling-1920x1080p@1-display.html * {igt@kms_bw@linear-tiling-1920x1080p@2-displays} (NEW): - fi-elk-e7500: NOTRUN -> [SKIP][42] +6 other tests skip [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-elk-e7500/igt@kms_bw@linear-tiling-1920x1080p@2-displays.html - fi-ilk-650: NOTRUN -> [SKIP][43] +4 other tests skip [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-ilk-650/igt@kms_bw@linear-tiling-1920x1080p@2-displays.html * {igt@kms_bw@linear-tiling-1920x1080p@3-displays} (NEW): - fi-cfl-8700k: NOTRUN -> [SKIP][44] +9 other tests skip [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-cfl-8700k/igt@kms_bw@linear-tiling-1920x1080p@3-displays.html - {bat-apl-1}: NOTRUN -> [SKIP][45] +7 other tests skip [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-apl-1/igt@kms_bw@linear-tiling-1920x1080p@3-displays.html * {igt@kms_bw@linear-tiling-2160x1440p@3-displays} (NEW): - fi-cfl-8109u: NOTRUN -> [SKIP][46] +15 other tests skip [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-cfl-8109u/igt@kms_bw@linear-tiling-2160x1440p@3-displays.html - fi-kbl-7567u: NOTRUN -> [SKIP][47] +7 other tests skip [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-kbl-7567u/igt@kms_bw@linear-tiling-2160x1440p@3-displays.html - fi-ivb-3770: NOTRUN -> [SKIP][48] +8 other tests skip [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-ivb-3770/igt@kms_bw@linear-tiling-2160x1440p@3-displays.html * {igt@kms_bw@linear-tiling-2560x1440p@1-display} (NEW): - fi-pnv-d510: NOTRUN -> [SKIP][49] +7 other tests skip [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-pnv-d510/igt@kms_bw@linear-tiling-2560x1440p@1-display.html * {igt@kms_bw@linear-tiling-2560x1440p@3-displays} (NEW): - fi-cfl-guc: NOTRUN -> [SKIP][50] +9 other tests skip [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-cfl-guc/igt@kms_bw@linear-tiling-2560x1440p@3-displays.html * {igt@kms_bw@linear-tiling-3840x2160p} (NEW): - bat-atsm-1: NOTRUN -> [SKIP][51] ([i915#6078]) +3 other tests skip [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-atsm-1/igt@kms_bw@linear-tiling-3840x2160p.html - bat-dg2-9: NOTRUN -> [SKIP][52] ([i915#9197]) +3 other tests skip [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-dg2-9/igt@kms_bw@linear-tiling-3840x2160p.html - fi-kbl-x1275: NOTRUN -> [SKIP][53] +3 other tests skip [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-kbl-x1275/igt@kms_bw@linear-tiling-3840x2160p.html - bat-adlp-11: NOTRUN -> [SKIP][54] ([i915#10470]) +3 other tests skip [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-adlp-11/igt@kms_bw@linear-tiling-3840x2160p.html * {igt@kms_bw@linear-tiling-3840x2160p@1-display} (NEW): - fi-bsw-nick: NOTRUN -> [SKIP][55] +11 other tests skip [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-bsw-nick/igt@kms_bw@linear-tiling-3840x2160p@1-display.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-glk-j4005: NOTRUN -> [SKIP][56] +18 other tests skip [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-glk-j4005/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html - fi-tgl-1115g4: NOTRUN -> [SKIP][57] ([i915#4103]) +1 other test skip [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy: - bat-jsl-1: NOTRUN -> [SKIP][58] ([i915#4103]) +1 other test skip [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-jsl-1/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html * igt@kms_dsc@dsc-basic: - fi-tgl-1115g4: NOTRUN -> [SKIP][59] ([i915#3555] / [i915#3840]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-tgl-1115g4/igt@kms_dsc@dsc-basic.html - bat-jsl-1: NOTRUN -> [SKIP][60] ([i915#3555] / [i915#9886]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-jsl-1/igt@kms_dsc@dsc-basic.html * igt@kms_force_connector_basic@force-load-detect: - fi-tgl-1115g4: NOTRUN -> [SKIP][61] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html - bat-jsl-1: NOTRUN -> [SKIP][62] [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-jsl-1/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_pm_backlight@basic-brightness: - fi-tgl-1115g4: NOTRUN -> [SKIP][63] ([i915#9812]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-tgl-1115g4/igt@kms_pm_backlight@basic-brightness.html * igt@kms_psr@psr-sprite-plane-onoff: - fi-tgl-1115g4: NOTRUN -> [SKIP][64] ([i915#9732]) +3 other tests skip [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-tgl-1115g4/igt@kms_psr@psr-sprite-plane-onoff.html * igt@kms_setmode@basic-clone-single-crtc: - bat-jsl-1: NOTRUN -> [SKIP][65] ([i915#3555]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-jsl-1/igt@kms_setmode@basic-clone-single-crtc.html - fi-tgl-1115g4: NOTRUN -> [SKIP][66] ([i915#3555]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html #### Possible fixes #### * igt@i915_module_load@load: - bat-dg2-8: [DMESG-WARN][67] ([i915#10014]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7847/bat-dg2-8/igt@i915_module_load@load.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-dg2-8/igt@i915_module_load@load.html * igt@i915_selftest@live@active: - fi-bsw-nick: [DMESG-FAIL][69] ([i915#10676]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7847/fi-bsw-nick/igt@i915_selftest@live@active.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/fi-bsw-nick/igt@i915_selftest@live@active.html * igt@i915_selftest@live@gt_engines: - bat-adls-6: [TIMEOUT][71] ([i915#10026] / [i915#10134]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7847/bat-adls-6/igt@i915_selftest@live@gt_engines.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-adls-6/igt@i915_selftest@live@gt_engines.html * igt@kms_flip@basic-plain-flip@a-dp6: - {bat-mtlp-9}: [DMESG-WARN][73] -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7847/bat-mtlp-9/igt@kms_flip@basic-plain-flip@a-dp6.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-mtlp-9/igt@kms_flip@basic-plain-flip@a-dp6.html * igt@kms_flip@basic-plain-flip@c-dp7: - {bat-mtlp-9}: [FAIL][75] ([i915#6121]) -> [PASS][76] +6 other tests pass [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7847/bat-mtlp-9/igt@kms_flip@basic-plain-flip@c-dp7.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/bat-mtlp-9/igt@kms_flip@basic-plain-flip@c-dp7.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#10014]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10014 [i915#10026]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10026 [i915#10134]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10134 [i915#10470]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10470 [i915#10676]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10676 [i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849 [i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190 [i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555 [i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840 [i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103 [i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613 [i915#6078]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6078 [i915#6121]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6121 [i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197 [i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318 [i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732 [i915#9812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9812 [i915#9886]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9886 [i915#9900]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9900 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7847 -> IGTPW_11132 CI-20190529: 20190529 CI_DRM_14750: 7aa7a8842f00c5749e1a21cd2cf6dfc0e3e3a18e @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_11132: fa03f16fb79a7130c3ca1fb6f1203040b0f1b380 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git IGT_7847: 86712f2effc8ba6690c7e165ad63904416763b75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11132/index.html [-- Attachment #2: Type: text/html, Size: 24797 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH i-g-t 0/3] fix kms_bw test @ 2024-05-23 10:02 Kunal Joshi 2024-05-23 10:02 ` [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only Kunal Joshi 0 siblings, 1 reply; 10+ messages in thread From: Kunal Joshi @ 2024-05-23 10:02 UTC (permalink / raw) To: igt-dev; +Cc: Kunal Joshi first patch converts the test structure to a dynamic subtest format, reducing skip counts due to missing configurations. The second patch restricts the test to run only on physically connected displays, addressing issues with forced 4K EDID on disconnected connectors. Kunal Joshi (3): tests/kms_bw: convert to dynamic subtest tests/kms_bw: allow physically connected only HAX patch do not merge tests/intel-ci/fast-feedback.testlist | 5 +- tests/kms_bw.c | 81 +++++++++++++-------------- 2 files changed, 42 insertions(+), 44 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only 2024-05-23 10:02 [PATCH i-g-t 0/3] fix kms_bw test Kunal Joshi @ 2024-05-23 10:02 ` Kunal Joshi 2024-05-23 12:56 ` Aurabindo Pillai 0 siblings, 1 reply; 10+ messages in thread From: Kunal Joshi @ 2024-05-23 10:02 UTC (permalink / raw) To: igt-dev; +Cc: Kunal Joshi, Aurabindo Pillai modify kms_bw test to only run on physically connected displays, avoiding issues with forcing a 4K EDID on disconnected connectors. For instance, consider a system with 2 DP and 2 HDMI connectors (DP-1, DP-2, HDMI-1, HDMI-2). Forcing EDID on DP is currently problematic, and we only support forcing for HDMI. However, if there's only one TMDS encoder, we can only drive one HDMI display, not two. For now, the test will only run on physically connected displays. Future improvements may consider the encoder count to handle such scenarios more gracefully. Cc: Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> --- tests/kms_bw.c | 43 ++++++++++++++++++------------------------- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/tests/kms_bw.c b/tests/kms_bw.c index b50f324af..4aabb02b7 100644 --- a/tests/kms_bw.c +++ b/tests/kms_bw.c @@ -61,6 +61,7 @@ typedef struct data { int h[IGT_MAX_PIPES]; int fd; int num_pipes; + int num_outputs; } data_t; static drmModeModeInfo test_mode[] = { @@ -105,8 +106,9 @@ static drmModeModeInfo test_mode[] = { static void test_init(data_t *data) { igt_display_t *display = &data->display; - int i, max_pipes = display->n_pipes; + int i; igt_output_t *output; + data->num_outputs = 0; for_each_pipe(display, i) { data->pipe_id[i] = i; @@ -118,23 +120,22 @@ static void test_init(data_t *data) IGT_PIPE_CRC_SOURCE_AUTO); } - for (i = 0; i < display->n_outputs && i < max_pipes; i++) { - if (!data->pipe[i]) - continue; - - output = &display->outputs[i]; - - data->output[i] = output; + i = 0; + for_each_output(display, output) { /* Only allow physically connected displays for the tests. */ if (!igt_output_is_connected(output)) continue; + data->output[i] = output; + data->num_outputs++; + igt_assert(kmstest_get_connector_default_mode( data->fd, output->config.connector, &data->mode[i])); data->w[i] = data->mode[i].hdisplay; data->h[i] = data->mode[i].vdisplay; + i++; } @@ -156,27 +157,12 @@ static void test_fini(data_t *data) igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0); } -/* Forces a mode for a connector. */ -static void force_output_mode(data_t *d, igt_output_t *output, - const drmModeModeInfo *mode) -{ - /* This allows us to create a virtual sink. */ - if (!igt_output_is_connected(output)) { - kmstest_force_edid(d->fd, output->config.connector, - igt_kms_get_4k_edid()); - - kmstest_force_connector(d->fd, output->config.connector, - FORCE_CONNECTOR_DIGITAL); - } - - igt_output_override_mode(output, mode); -} - static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo *mode) { igt_display_t *display = &data->display; igt_output_t *output; struct igt_fb buffer[IGT_MAX_PIPES]; igt_crc_t zero, captured[IGT_MAX_PIPES]; + int i = 0; int ret; igt_skip_on_f(pipe >= data->num_pipes, @@ -184,6 +170,10 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo test_init(data); + igt_skip_on_f(pipe >= data->num_outputs, + "%d connected outputs required but found %d\n", + pipe+1, data->num_outputs+1); + /* create buffers */ for (i = 0; i <= pipe; i++) { output = data->output[i]; @@ -191,7 +181,7 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo continue; } - force_output_mode(data, output, mode); + igt_output_override_mode(output, mode); igt_create_color_fb(display->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, @@ -199,6 +189,9 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo &buffer[i]); igt_output_set_pipe(output, i); + igt_info("Assigned output %s to pipe %s with mode %dx%d@%d\n", + igt_output_name(output), kmstest_pipe_name(i), + mode->hdisplay, mode->vdisplay, mode->vrefresh); igt_plane_set_fb(data->primary[i], &buffer[i]); } -- 2.25.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only 2024-05-23 10:02 ` [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only Kunal Joshi @ 2024-05-23 12:56 ` Aurabindo Pillai 2024-06-13 13:05 ` Joshi, Kunal1 0 siblings, 1 reply; 10+ messages in thread From: Aurabindo Pillai @ 2024-05-23 12:56 UTC (permalink / raw) To: Kunal Joshi, igt-dev Hi Kunal, On 5/23/24 6:02 AM, Kunal Joshi wrote: > modify kms_bw test to only run on physically connected displays, > avoiding issues with forcing a 4K EDID on disconnected connectors. > > For instance, consider a system with 2 DP and 2 HDMI connectors > (DP-1, DP-2, HDMI-1, HDMI-2). Forcing EDID on DP is currently problematic, > and we only support forcing for HDMI. However, if there's only one Is this limitation intel specific? > TMDS encoder, we can only drive one HDMI display, not two. > > For now, the test will only run on physically connected displays. > Future improvements may consider the encoder count to handle such > scenarios more gracefully. > Making it run only on physical connected displays limits us from catching any issues in backend programming related to bandwidth calculation, so this change isnt helpful. How about adding a subtest that can be tested only on physically connected ones ? > Cc: Aurabindo Pillai <aurabindo.pillai@amd.com> > Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> > --- > tests/kms_bw.c | 43 ++++++++++++++++++------------------------- > 1 file changed, 18 insertions(+), 25 deletions(-) > > diff --git a/tests/kms_bw.c b/tests/kms_bw.c > index b50f324af..4aabb02b7 100644 > --- a/tests/kms_bw.c > +++ b/tests/kms_bw.c > @@ -61,6 +61,7 @@ typedef struct data { > int h[IGT_MAX_PIPES]; > int fd; > int num_pipes; > + int num_outputs; > } data_t; > > static drmModeModeInfo test_mode[] = { > @@ -105,8 +106,9 @@ static drmModeModeInfo test_mode[] = { > static void test_init(data_t *data) > { > igt_display_t *display = &data->display; > - int i, max_pipes = display->n_pipes; > + int i; > igt_output_t *output; > + data->num_outputs = 0; > > for_each_pipe(display, i) { > data->pipe_id[i] = i; > @@ -118,23 +120,22 @@ static void test_init(data_t *data) > IGT_PIPE_CRC_SOURCE_AUTO); > } > > - for (i = 0; i < display->n_outputs && i < max_pipes; i++) { > - if (!data->pipe[i]) > - continue; > - > - output = &display->outputs[i]; > - > - data->output[i] = output; > + i = 0; > > + for_each_output(display, output) { > /* Only allow physically connected displays for the tests. */ > if (!igt_output_is_connected(output)) > continue; > > + data->output[i] = output; > + data->num_outputs++; > + > igt_assert(kmstest_get_connector_default_mode( > data->fd, output->config.connector, &data->mode[i])); > > data->w[i] = data->mode[i].hdisplay; > data->h[i] = data->mode[i].vdisplay; > + i++; > } > > > @@ -156,27 +157,12 @@ static void test_fini(data_t *data) > igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0); > } > > -/* Forces a mode for a connector. */ > -static void force_output_mode(data_t *d, igt_output_t *output, > - const drmModeModeInfo *mode) > -{ > - /* This allows us to create a virtual sink. */ > - if (!igt_output_is_connected(output)) { > - kmstest_force_edid(d->fd, output->config.connector, > - igt_kms_get_4k_edid()); > - > - kmstest_force_connector(d->fd, output->config.connector, > - FORCE_CONNECTOR_DIGITAL); > - } > - > - igt_output_override_mode(output, mode); > -} > - > static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo *mode) { > igt_display_t *display = &data->display; > igt_output_t *output; > struct igt_fb buffer[IGT_MAX_PIPES]; > igt_crc_t zero, captured[IGT_MAX_PIPES]; > + int i = 0; > int ret; > > igt_skip_on_f(pipe >= data->num_pipes, > @@ -184,6 +170,10 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo > > test_init(data); > > + igt_skip_on_f(pipe >= data->num_outputs, > + "%d connected outputs required but found %d\n", > + pipe+1, data->num_outputs+1); > + > /* create buffers */ > for (i = 0; i <= pipe; i++) { > output = data->output[i]; > @@ -191,7 +181,7 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo > continue; > } > > - force_output_mode(data, output, mode); > + igt_output_override_mode(output, mode); > > igt_create_color_fb(display->drm_fd, mode->hdisplay, > mode->vdisplay, DRM_FORMAT_XRGB8888, > @@ -199,6 +189,9 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo > &buffer[i]); > > igt_output_set_pipe(output, i); > + igt_info("Assigned output %s to pipe %s with mode %dx%d@%d\n", > + igt_output_name(output), kmstest_pipe_name(i), > + mode->hdisplay, mode->vdisplay, mode->vrefresh); > > igt_plane_set_fb(data->primary[i], &buffer[i]); > } -- -- Thanks & Regards, Aurabindo Pillai ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only 2024-05-23 12:56 ` Aurabindo Pillai @ 2024-06-13 13:05 ` Joshi, Kunal1 0 siblings, 0 replies; 10+ messages in thread From: Joshi, Kunal1 @ 2024-06-13 13:05 UTC (permalink / raw) To: Aurabindo Pillai, igt-dev Hello Aurabindo, On 5/23/2024 6:26 PM, Aurabindo Pillai wrote: > Hi Kunal, > > On 5/23/24 6:02 AM, Kunal Joshi wrote: >> modify kms_bw test to only run on physically connected displays, >> avoiding issues with forcing a 4K EDID on disconnected connectors. >> >> For instance, consider a system with 2 DP and 2 HDMI connectors >> (DP-1, DP-2, HDMI-1, HDMI-2). Forcing EDID on DP is currently >> problematic, >> and we only support forcing for HDMI. However, if there's only one > > Is this limitation intel specific? Yes, bool kmstest_force_connector(int drm_fd, drmModeConnector *connector, enum kmstest_force_connector_state state) { const char *value; drmModeConnector *temp; /* * Forcing DP connectors doesn't currently work, so * fail early to allow the test to skip if required. */ if (is_intel_device(drm_fd) && connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) return false; > >> TMDS encoder, we can only drive one HDMI display, not two. >> >> For now, the test will only run on physically connected displays. >> Future improvements may consider the encoder count to handle such >> scenarios more gracefully. >> > > Making it run only on physical connected displays limits us from > catching any issues in backend programming related to bandwidth > calculation, so this change isnt helpful. > > How about adding a subtest that can be tested only on physically > connected ones ? Thanks for the suggestion and the comments :), Have done the same, https://patchwork.freedesktop.org/series/134822/ Regards Kunal Joshi >> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com> >> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> >> --- >> tests/kms_bw.c | 43 ++++++++++++++++++------------------------- >> 1 file changed, 18 insertions(+), 25 deletions(-) >> >> diff --git a/tests/kms_bw.c b/tests/kms_bw.c >> index b50f324af..4aabb02b7 100644 >> --- a/tests/kms_bw.c >> +++ b/tests/kms_bw.c >> @@ -61,6 +61,7 @@ typedef struct data { >> int h[IGT_MAX_PIPES]; >> int fd; >> int num_pipes; >> + int num_outputs; >> } data_t; >> static drmModeModeInfo test_mode[] = { >> @@ -105,8 +106,9 @@ static drmModeModeInfo test_mode[] = { >> static void test_init(data_t *data) >> { >> igt_display_t *display = &data->display; >> - int i, max_pipes = display->n_pipes; >> + int i; >> igt_output_t *output; >> + data->num_outputs = 0; >> for_each_pipe(display, i) { >> data->pipe_id[i] = i; >> @@ -118,23 +120,22 @@ static void test_init(data_t *data) >> IGT_PIPE_CRC_SOURCE_AUTO); >> } >> - for (i = 0; i < display->n_outputs && i < max_pipes; i++) { >> - if (!data->pipe[i]) >> - continue; >> - >> - output = &display->outputs[i]; >> - >> - data->output[i] = output; >> + i = 0; >> + for_each_output(display, output) { >> /* Only allow physically connected displays for the tests. */ >> if (!igt_output_is_connected(output)) >> continue; >> + data->output[i] = output; >> + data->num_outputs++; >> + >> igt_assert(kmstest_get_connector_default_mode( >> data->fd, output->config.connector, &data->mode[i])); >> data->w[i] = data->mode[i].hdisplay; >> data->h[i] = data->mode[i].vdisplay; >> + i++; >> } >> @@ -156,27 +157,12 @@ static void test_fini(data_t *data) >> igt_display_commit_atomic(display, >> DRM_MODE_ATOMIC_ALLOW_MODESET, 0); >> } >> -/* Forces a mode for a connector. */ >> -static void force_output_mode(data_t *d, igt_output_t *output, >> - const drmModeModeInfo *mode) >> -{ >> - /* This allows us to create a virtual sink. */ >> - if (!igt_output_is_connected(output)) { >> - kmstest_force_edid(d->fd, output->config.connector, >> - igt_kms_get_4k_edid()); >> - >> - kmstest_force_connector(d->fd, output->config.connector, >> - FORCE_CONNECTOR_DIGITAL); >> - } >> - >> - igt_output_override_mode(output, mode); >> -} >> - >> static void run_test_linear_tiling(data_t *data, int pipe, const >> drmModeModeInfo *mode) { >> igt_display_t *display = &data->display; >> igt_output_t *output; >> struct igt_fb buffer[IGT_MAX_PIPES]; >> igt_crc_t zero, captured[IGT_MAX_PIPES]; >> + int i = 0; >> int ret; >> igt_skip_on_f(pipe >= data->num_pipes, >> @@ -184,6 +170,10 @@ static void run_test_linear_tiling(data_t *data, >> int pipe, const drmModeModeInfo >> test_init(data); >> + igt_skip_on_f(pipe >= data->num_outputs, >> + "%d connected outputs required but found %d\n", >> + pipe+1, data->num_outputs+1); >> + >> /* create buffers */ >> for (i = 0; i <= pipe; i++) { >> output = data->output[i]; >> @@ -191,7 +181,7 @@ static void run_test_linear_tiling(data_t *data, >> int pipe, const drmModeModeInfo >> continue; >> } >> - force_output_mode(data, output, mode); >> + igt_output_override_mode(output, mode); >> igt_create_color_fb(display->drm_fd, mode->hdisplay, >> mode->vdisplay, DRM_FORMAT_XRGB8888, >> @@ -199,6 +189,9 @@ static void run_test_linear_tiling(data_t *data, >> int pipe, const drmModeModeInfo >> &buffer[i]); >> igt_output_set_pipe(output, i); >> + igt_info("Assigned output %s to pipe %s with mode %dx%d@%d\n", >> + igt_output_name(output), kmstest_pipe_name(i), >> + mode->hdisplay, mode->vdisplay, mode->vrefresh); >> igt_plane_set_fb(data->primary[i], &buffer[i]); >> } > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-06-13 13:05 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-05-12 16:01 [PATCH i-g-t 0/3] fix kms_be test Kunal Joshi 2024-05-12 16:01 ` [PATCH i-g-t 1/3] tests/kms_bw: convert to dynamic subtest Kunal Joshi 2024-05-13 11:59 ` Kamil Konieczny 2024-05-12 16:01 ` [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only Kunal Joshi 2024-05-13 12:10 ` Kamil Konieczny 2024-05-12 16:01 ` [PATCH i-g-t 3/3] HAX patch do not merge Kunal Joshi 2024-05-12 16:19 ` ✗ Fi.CI.BAT: failure for fix kms_be test Patchwork -- strict thread matches above, loose matches on Subject: below -- 2024-05-23 10:02 [PATCH i-g-t 0/3] fix kms_bw test Kunal Joshi 2024-05-23 10:02 ` [PATCH i-g-t 2/3] tests/kms_bw: allow physically connected only Kunal Joshi 2024-05-23 12:56 ` Aurabindo Pillai 2024-06-13 13:05 ` Joshi, Kunal1
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox