Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Juha-Pekka Heikkila" <juhapekka.heikkila@gmail.com>
Subject: [PATCH i-g-t 01/12] lib/intel_bufops: Fix offset returned for Tile4
Date: Mon, 27 May 2024 09:33:34 +0200	[thread overview]
Message-ID: <20240527073345.54729-2-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20240527073345.54729-1-zbigniew.kempczynski@intel.com>

Functions which calculates offset in bufops for specific tiling should
return it in bytes, not in cpp. Fix this issue for Tile4.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 lib/intel_bufops.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c
index 52a5f322ea..313c2665ae 100644
--- a/lib/intel_bufops.c
+++ b/lib/intel_bufops.c
@@ -377,7 +377,6 @@ static void *tile4_ptr(void *ptr,
 		((tile_y & 3) << __builtin_ctz(owords)) +
 		(tile_x & (owords - 1));
 	igt_assert((pos & (cpp - 1)) == 0);
-	pos = pos >> __builtin_ctz(cpp);
 
 	return ptr + pos;
 }
-- 
2.34.1


  reply	other threads:[~2024-05-27  7:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27  7:33 [PATCH i-g-t 00/12] Introduce intel_tiling_detect tool Zbigniew Kempczyński
2024-05-27  7:33 ` Zbigniew Kempczyński [this message]
2024-06-03  7:26   ` [PATCH i-g-t 01/12] lib/intel_bufops: Fix offset returned for Tile4 Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 02/12] lib/intel_bufops: Fix mapping/unmapping for i915 and xe Zbigniew Kempczyński
2024-06-03  7:31   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 03/12] lib/intel_bufops: Add linear-to-none copy path Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 04/12] lib/intel_bufops: Add Tile4 in linear_to and to_linear helpers Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 05/12] lib/intel_bufops: Add Yf tiling Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 06/12] lib/intel_blt: Add Yf tiling in block-copy Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 07/12] lib/intel_bufops: Add Ys tiling in linear_to and to_linear path Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 08/12] lib/intel_bufops: Drop unnecessary Tile4 function assignment Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 09/12] lib/intel_bufops: Preparation for adding software tiling for Tile64 Zbigniew Kempczyński
2024-06-17 11:17   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 10/12] lib/intel_bufops: Drop Tile4 swizzling Zbigniew Kempczyński
2024-06-17 11:17   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 11/12] lib/intel_bufops: Don't disable x and y on platforms without swizzling Zbigniew Kempczyński
2024-06-17 16:43   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 12/12] tools/intel_tiling_detect: Introduce tiling detection tool Zbigniew Kempczyński
2024-06-17 19:21   ` Juha-Pekka Heikkila
2024-06-18  4:51     ` Zbigniew Kempczyński
2024-06-17 19:46   ` Kamil Konieczny
2024-06-18  5:15     ` Zbigniew Kempczyński
2024-05-27 18:40 ` ✓ Fi.CI.BAT: success for Introduce intel_tiling_detect tool Patchwork
2024-05-27 18:45 ` ✓ CI.xeBAT: " Patchwork
2024-05-28  7:29 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-28  7:46   ` Zbigniew Kempczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240527073345.54729-2-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox