Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Juha-Pekka Heikkila" <juhapekka.heikkila@gmail.com>
Subject: [PATCH i-g-t 07/12] lib/intel_bufops: Add Ys tiling in linear_to and to_linear path
Date: Mon, 27 May 2024 09:33:40 +0200	[thread overview]
Message-ID: <20240527073345.54729-8-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20240527073345.54729-1-zbigniew.kempczynski@intel.com>

To iterate over all tilings we need to have each case addressed
in the code. Add missing Ys case.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 lib/intel_blt.c       | 3 +++
 lib/intel_bufops.c    | 6 ++++--
 lib/intel_cmds_info.h | 1 +
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/lib/intel_blt.c b/lib/intel_blt.c
index d1200ca862..20c42eec14 100644
--- a/lib/intel_blt.c
+++ b/lib/intel_blt.c
@@ -540,6 +540,7 @@ const char *blt_tiling_name(enum blt_tiling_type tiling)
 	case T_TILE4:  return "tile4";
 	case T_TILE64: return "tile64";
 	case T_YFMAJOR: return "yfmajor";
+	case T_YSMAJOR: return "ysmajor";
 	default:
 		break;
 	}
@@ -582,6 +583,7 @@ int blt_tile_to_i915_tile(enum blt_tiling_type tiling)
 	case T_TILE4:  return I915_TILING_4;
 	case T_TILE64: return I915_TILING_64;
 	case T_YFMAJOR: return I915_TILING_Yf;
+	case T_YSMAJOR: return I915_TILING_Ys;
 	default:
 		break;
 	}
@@ -606,6 +608,7 @@ enum blt_tiling_type i915_tile_to_blt_tile(uint32_t tiling)
 	case I915_TILING_4:	return T_TILE4;
 	case I915_TILING_64:	return T_TILE64;
 	case I915_TILING_Yf:	return T_YFMAJOR;
+	case I915_TILING_Ys:	return T_YSMAJOR;
 	default:
 		igt_assert_f(0, "Unknown tiling!\n");
 	}
diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c
index 36b9aa2a8c..38b720624e 100644
--- a/lib/intel_bufops.c
+++ b/lib/intel_bufops.c
@@ -1697,8 +1697,6 @@ static struct buf_ops *__buf_ops_create(int fd, bool check_idempotency)
 		bops->y_to_linear = copy_y_to_linear;
 		bops->linear_to_tile4 = copy_linear_to_tile4;
 		bops->tile4_to_linear = copy_tile4_to_linear;
-		bops->linear_to_ys = NULL;
-		bops->ys_to_linear = NULL;
 
 		return bops;
 	}
@@ -1956,6 +1954,10 @@ bool buf_ops_set_software_tiling(struct buf_ops *bops,
 		igt_debug("-> use SW on tiling Yf\n");
 		break;
 
+	case I915_TILING_Ys:
+		igt_debug("-> use SW on tiling Ys\n");
+		break;
+
 	default:
 		igt_warn("Invalid tiling: %d\n", tiling);
 		was_changed = false;
diff --git a/lib/intel_cmds_info.h b/lib/intel_cmds_info.h
index 6f7d655083..7960e0412e 100644
--- a/lib/intel_cmds_info.h
+++ b/lib/intel_cmds_info.h
@@ -14,6 +14,7 @@ enum blt_tiling_type {
 	T_YMAJOR,
 	T_TILE4,
 	T_YFMAJOR,
+	T_YSMAJOR,
 	T_TILE64,
 	__BLT_MAX_TILING
 };
-- 
2.34.1


  parent reply	other threads:[~2024-05-27  7:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27  7:33 [PATCH i-g-t 00/12] Introduce intel_tiling_detect tool Zbigniew Kempczyński
2024-05-27  7:33 ` [PATCH i-g-t 01/12] lib/intel_bufops: Fix offset returned for Tile4 Zbigniew Kempczyński
2024-06-03  7:26   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 02/12] lib/intel_bufops: Fix mapping/unmapping for i915 and xe Zbigniew Kempczyński
2024-06-03  7:31   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 03/12] lib/intel_bufops: Add linear-to-none copy path Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 04/12] lib/intel_bufops: Add Tile4 in linear_to and to_linear helpers Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 05/12] lib/intel_bufops: Add Yf tiling Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 06/12] lib/intel_blt: Add Yf tiling in block-copy Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` Zbigniew Kempczyński [this message]
2024-06-17 11:16   ` [PATCH i-g-t 07/12] lib/intel_bufops: Add Ys tiling in linear_to and to_linear path Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 08/12] lib/intel_bufops: Drop unnecessary Tile4 function assignment Zbigniew Kempczyński
2024-06-17 11:16   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 09/12] lib/intel_bufops: Preparation for adding software tiling for Tile64 Zbigniew Kempczyński
2024-06-17 11:17   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 10/12] lib/intel_bufops: Drop Tile4 swizzling Zbigniew Kempczyński
2024-06-17 11:17   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 11/12] lib/intel_bufops: Don't disable x and y on platforms without swizzling Zbigniew Kempczyński
2024-06-17 16:43   ` Juha-Pekka Heikkila
2024-05-27  7:33 ` [PATCH i-g-t 12/12] tools/intel_tiling_detect: Introduce tiling detection tool Zbigniew Kempczyński
2024-06-17 19:21   ` Juha-Pekka Heikkila
2024-06-18  4:51     ` Zbigniew Kempczyński
2024-06-17 19:46   ` Kamil Konieczny
2024-06-18  5:15     ` Zbigniew Kempczyński
2024-05-27 18:40 ` ✓ Fi.CI.BAT: success for Introduce intel_tiling_detect tool Patchwork
2024-05-27 18:45 ` ✓ CI.xeBAT: " Patchwork
2024-05-28  7:29 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-28  7:46   ` Zbigniew Kempczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240527073345.54729-8-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox