Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, juha-pekka.heikkila@intel.com,
	jouni.hogander@intel.com
Subject: [PATCH i-g-t 3/4] tests/kms_dirtyfb: disable psr feature only if psr possible
Date: Fri,  7 Jun 2024 17:57:31 +0300	[thread overview]
Message-ID: <20240607145732.285557-4-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20240607145732.285557-1-vinod.govindapillai@intel.com>

When kms_dirtyfb tests are executed on cases where PSR is not
possible the tests are getting skipped. This is because igt_skip
is use in psr_set function. So avoid calling the psr_disable if
not necessary.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 tests/intel/kms_dirtyfb.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index 6121599ec..2a32fab56 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -169,7 +169,10 @@ static void check_feature(data_t *data)
 static void disable_features(data_t *data)
 {
 	intel_fbc_disable(data->drm_fd);
-	psr_disable(data->drm_fd, data->debugfs_fd, NULL);
+
+	if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL))
+		psr_disable(data->drm_fd, data->debugfs_fd, NULL);
+
 	intel_drrs_disable(data->drm_fd, data->pipe);
 }
 
-- 
2.34.1


  parent reply	other threads:[~2024-06-07 14:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07 14:57 [PATCH i-g-t 0/4] tests/kms_dirtyfb: few fbc related updates Vinod Govindapillai
2024-06-07 14:57 ` [PATCH i-g-t 1/4] lib/i915/fbc: print current fbc status if cannot be enabled Vinod Govindapillai
2024-06-07 20:21   ` Cavitt, Jonathan
2024-06-07 14:57 ` [PATCH i-g-t 2/4] lib/i915/fbc: add fbc frame size check helper Vinod Govindapillai
2024-06-07 20:42   ` Cavitt, Jonathan
2024-06-10 12:05     ` Govindapillai, Vinod
2024-06-07 14:57 ` Vinod Govindapillai [this message]
2024-06-07 20:43   ` [PATCH i-g-t 3/4] tests/kms_dirtyfb: disable psr feature only if psr possible Cavitt, Jonathan
2024-06-07 14:57 ` [PATCH i-g-t 4/4] tests/kms_dirtyfb: ensure plane size is within fbc supported limit Vinod Govindapillai
2024-06-07 20:44   ` Cavitt, Jonathan
2024-06-07 22:08 ` ✗ Fi.CI.BUILD: failure for tests/kms_dirtyfb: few fbc related updates Patchwork
2024-06-07 22:13 ` ✗ GitLab.Pipeline: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240607145732.285557-4-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    --cc=juha-pekka.heikkila@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox