From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [PATCH i-g-t 3/8] tests/intel/kms_pwrite_crc: Test cleanup
Date: Tue, 11 Jun 2024 10:23:43 +0530 [thread overview]
Message-ID: <20240611045348.3727239-4-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240611045348.3727239-1-bhanuprakash.modem@intel.com>
Make sure the below points in IGT cleanup:
- Sanitize the state before starting the subtest.
- Clear the states before exiting the subtest.
- Update existing libdrm APIs with IGT kms APIs.
- Other misc (Ex: update deprecated APIs/macros/enums, FB leaks etc..)
V2:
- Drop igt_fixture form igt_simple_main
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/intel/kms_pwrite_crc.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tests/intel/kms_pwrite_crc.c b/tests/intel/kms_pwrite_crc.c
index 12add5da6..338c92c3a 100644
--- a/tests/intel/kms_pwrite_crc.c
+++ b/tests/intel/kms_pwrite_crc.c
@@ -125,7 +125,6 @@ static void prepare_crtc(data_t *data)
igt_output_t *output = data->output;
drmModeModeInfo *mode;
- igt_display_reset(display);
/* select the pipe we want to use */
igt_output_set_pipe(output, data->pipe);
@@ -161,7 +160,7 @@ static void cleanup_crtc(data_t *data)
igt_plane_set_fb(data->primary, NULL);
- igt_output_set_pipe(output, PIPE_ANY);
+ igt_output_set_pipe(output, PIPE_NONE);
igt_display_commit(display);
igt_remove_fb(data->drm_fd, &data->fb[0]);
@@ -196,14 +195,14 @@ static data_t data;
igt_simple_main
{
data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
-
- data.devid = intel_get_drm_devid(data.drm_fd);
-
kmstest_set_vt_graphics_mode();
+ igt_display_require(&data.display, data.drm_fd);
+ igt_display_require_output(&data.display);
igt_require_pipe_crc(data.drm_fd);
- igt_display_require(&data.display, data.drm_fd);
+ data.devid = intel_get_drm_devid(data.drm_fd);
+ data.pipe_crc = NULL;
run_test(&data);
--
2.43.2
next prev parent reply other threads:[~2024-06-11 5:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 4:53 [PATCH i-g-t 0/8] IGT KMS Test cleanup Bhanuprakash Modem
2024-06-11 4:53 ` [PATCH i-g-t 1/8] tests/intel/kms_fence_pin_leak: " Bhanuprakash Modem
2024-06-14 5:28 ` B, Jeevan
2024-06-11 4:53 ` [PATCH i-g-t 2/8] tests/intel/kms_pipe_b_c_ivb: " Bhanuprakash Modem
2024-06-12 11:29 ` B, Jeevan
2024-06-11 4:53 ` Bhanuprakash Modem [this message]
2024-06-12 11:30 ` [PATCH i-g-t 3/8] tests/intel/kms_pwrite_crc: " B, Jeevan
2024-06-14 8:46 ` B, Jeevan
2024-06-11 4:53 ` [PATCH i-g-t 4/8] tests/kms_hdmi_inject: " Bhanuprakash Modem
2024-06-12 11:32 ` B, Jeevan
2024-06-11 4:53 ` [PATCH i-g-t 5/8] tests/kms_tiled_display: " Bhanuprakash Modem
2024-06-12 12:21 ` Kamil Konieczny
2024-06-14 8:09 ` [i-g-t V2 " Bhanuprakash Modem
2024-06-11 4:53 ` [PATCH i-g-t 6/8] tests/kms_tv_load_detect: " Bhanuprakash Modem
2024-06-12 11:34 ` B, Jeevan
2024-06-11 4:53 ` [PATCH i-g-t 7/8] tests/kms_universal_plane: " Bhanuprakash Modem
2024-06-12 11:35 ` B, Jeevan
2024-06-11 4:53 ` [PATCH i-g-t 8/8] tests/kms_properties: Create dynamic subtests Bhanuprakash Modem
2024-06-12 11:47 ` B, Jeevan
2024-06-11 7:14 ` ✓ Fi.CI.BAT: success for IGT KMS Test cleanup (rev2) Patchwork
2024-06-11 7:19 ` ✗ CI.xeBAT: failure " Patchwork
2024-06-11 9:35 ` ✗ CI.xeFULL: " Patchwork
2024-06-11 11:06 ` ✗ Fi.CI.IGT: " Patchwork
2024-06-14 13:18 ` ✓ CI.xeBAT: success for IGT KMS Test cleanup (rev3) Patchwork
2024-06-14 13:27 ` ✓ Fi.CI.BAT: " Patchwork
2024-06-14 23:06 ` ✓ CI.xeFULL: " Patchwork
2024-06-16 21:11 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611045348.3727239-4-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox