Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>,
	Jeevan B <jeevan.b@intel.com>,
	Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [PATCH i-g-t 4/8] tests/kms_hdmi_inject: Test cleanup
Date: Tue, 11 Jun 2024 10:23:44 +0530	[thread overview]
Message-ID: <20240611045348.3727239-5-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240611045348.3727239-1-bhanuprakash.modem@intel.com>

From: Kunal Joshi <kunal1.joshi@intel.com>

Make sure the below points in IGT cleanup:

 - Sanitize the state before starting the subtest.
 - Clear the states before exiting the subtest.
 - Update existing libdrm APIs with IGT kms APIs.
 - Other misc (Ex: update deprecated APIs/macros/enums, FB leaks etc..)

v2: (Bhanu)
 - Rebase
 - Initialize pointers with NULL
 - Update connector type HDMI checks

Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
Reviewed-by: Jeevan B <jeevan.b@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_hdmi_inject.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
index dce74fac0..d28be38e4 100644
--- a/tests/kms_hdmi_inject.c
+++ b/tests/kms_hdmi_inject.c
@@ -80,14 +80,15 @@ static drmModeConnector *
 get_connector(int drm_fd, drmModeRes *res)
 {
 	int i;
-	drmModeConnector *connector;
+	drmModeConnector *connector = NULL;
 
 	for (i = 0; i < res->count_connectors; i++) {
 
 		connector =
 			drmModeGetConnectorCurrent(drm_fd, res->connectors[i]);
 
-		if (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA)
+		if (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+		    connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)
 			break;
 
 		drmModeFreeConnector(connector);
@@ -243,6 +244,7 @@ igt_main
 
 	igt_fixture {
 		drmModeFreeConnector(connector);
+		drmModeFreeResources(res);
 		drm_close_driver(drm_fd);
 	}
 }
-- 
2.43.2


  parent reply	other threads:[~2024-06-11  5:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11  4:53 [PATCH i-g-t 0/8] IGT KMS Test cleanup Bhanuprakash Modem
2024-06-11  4:53 ` [PATCH i-g-t 1/8] tests/intel/kms_fence_pin_leak: " Bhanuprakash Modem
2024-06-14  5:28   ` B, Jeevan
2024-06-11  4:53 ` [PATCH i-g-t 2/8] tests/intel/kms_pipe_b_c_ivb: " Bhanuprakash Modem
2024-06-12 11:29   ` B, Jeevan
2024-06-11  4:53 ` [PATCH i-g-t 3/8] tests/intel/kms_pwrite_crc: " Bhanuprakash Modem
2024-06-12 11:30   ` B, Jeevan
2024-06-14  8:46     ` B, Jeevan
2024-06-11  4:53 ` Bhanuprakash Modem [this message]
2024-06-12 11:32   ` [PATCH i-g-t 4/8] tests/kms_hdmi_inject: " B, Jeevan
2024-06-11  4:53 ` [PATCH i-g-t 5/8] tests/kms_tiled_display: " Bhanuprakash Modem
2024-06-12 12:21   ` Kamil Konieczny
2024-06-14  8:09   ` [i-g-t V2 " Bhanuprakash Modem
2024-06-11  4:53 ` [PATCH i-g-t 6/8] tests/kms_tv_load_detect: " Bhanuprakash Modem
2024-06-12 11:34   ` B, Jeevan
2024-06-11  4:53 ` [PATCH i-g-t 7/8] tests/kms_universal_plane: " Bhanuprakash Modem
2024-06-12 11:35   ` B, Jeevan
2024-06-11  4:53 ` [PATCH i-g-t 8/8] tests/kms_properties: Create dynamic subtests Bhanuprakash Modem
2024-06-12 11:47   ` B, Jeevan
2024-06-11  7:14 ` ✓ Fi.CI.BAT: success for IGT KMS Test cleanup (rev2) Patchwork
2024-06-11  7:19 ` ✗ CI.xeBAT: failure " Patchwork
2024-06-11  9:35 ` ✗ CI.xeFULL: " Patchwork
2024-06-11 11:06 ` ✗ Fi.CI.IGT: " Patchwork
2024-06-14 13:18 ` ✓ CI.xeBAT: success for IGT KMS Test cleanup (rev3) Patchwork
2024-06-14 13:27 ` ✓ Fi.CI.BAT: " Patchwork
2024-06-14 23:06 ` ✓ CI.xeFULL: " Patchwork
2024-06-16 21:11 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240611045348.3727239-5-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox