From: "Jouni Högander" <jouni.hogander@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: kunal1.joshi@intel.com, ramanaidu.naladala@intel.com,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH i-g-t v3 1/7] lib/igt_psr: Set Panel Replay disable bit for PSR modes
Date: Fri, 14 Jun 2024 08:38:33 +0300 [thread overview]
Message-ID: <20240614053839.1822879-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240614053839.1822879-1-jouni.hogander@intel.com>
Set Panel Replay disable bit for PSR_MODE_* to prevent using Panel Replay
for panels supporting it.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
---
lib/igt_psr.c | 32 +++++++++++++++++++-------------
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index 6008b73a6..964f18487 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -163,30 +163,36 @@ static bool psr_set(int device, int debugfs_fd, int mode, igt_output_t *output)
*/
ret = psr_modparam_set(device, mode >= PSR_MODE_1);
} else {
- const char *debug_val;
+ int debug_val = mode <= PSR_MODE_2_SEL_FETCH ? 0x40 : 0;
switch (mode) {
case PSR_MODE_1:
- debug_val = "0x3";
- break;
+ case PR_MODE:
+ debug_val |= 0x3;
+ break;
case PSR_MODE_2:
- debug_val = "0x2";
- break;
+ debug_val |= 0x2;
+ break;
case PSR_MODE_2_SEL_FETCH:
- debug_val = "0x4";
- break;
- case PR_MODE:
- debug_val = "0x5";
- break;
case PR_MODE_SEL_FETCH:
- debug_val = "0x6";
+ debug_val |= 0x4;
break;
default:
/* Disables PSR */
- debug_val = "0x1";
+ debug_val = 0x1;
}
- ret = psr_write(debugfs_fd, debug_val, output);
+ /* old debugfs interface doesn't recognize Panel Replay disable bit */
+ do {
+ char debug_str[8];
+
+ sprintf(debug_str, "0x%x", debug_val);
+ ret = psr_write(debugfs_fd, debug_str, output);
+ if (!(debug_val & 0x40))
+ break;
+
+ debug_val &= ~0x40;
+ } while (ret <= 0);
igt_require_f(ret > 0, "PSR2 SF feature not available\n");
}
--
2.34.1
next prev parent reply other threads:[~2024-06-14 5:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 5:38 [PATCH i-g-t v3 0/7] Panel Replay eDP changes Jouni Högander
2024-06-14 5:38 ` Jouni Högander [this message]
2024-06-14 5:38 ` [PATCH i-g-t v3 2/7] lib/igt_psr: Psr status debugfs interface print "enabled" not "Enabled" Jouni Högander
2024-06-14 5:38 ` [PATCH i-g-t v3 3/7] lib/igt_psr: Handle PR_MODE2_SEL_FETCH and eDP PR_* in psr active check Jouni Högander
2024-06-14 5:38 ` [PATCH i-g-t v3 4/7] tests/intel/kms_psr_stress_test: Provide output to psr_wait_entry Jouni Högander
2024-06-14 5:38 ` [PATCH i-g-t v3 5/7] tests/kms_psr2_sf: Use stored psr mode instead of PSR_MODE_2_SEL_FETCH Jouni Högander
2024-06-21 9:17 ` [i-g-t, v3, " Joshi, Kunal1
2024-06-14 5:38 ` [PATCH i-g-t v3 6/7] lib/igt_psr: Fix PR_MODE sink support check Jouni Högander
2024-06-21 9:18 ` [i-g-t,v3,6/7] " Joshi, Kunal1
2024-06-14 5:38 ` [PATCH i-g-t v3 7/7] lib/igt_psr: Adjust igt_wait intervals Jouni Högander
2024-06-21 9:22 ` [i-g-t,v3,7/7] " Joshi, Kunal1
2024-06-14 7:36 ` ✓ Fi.CI.BAT: success for Panel Replay eDP changes (rev3) Patchwork
2024-06-14 7:40 ` ✓ CI.xeBAT: " Patchwork
2024-06-14 12:36 ` ✗ GitLab.Pipeline: warning " Patchwork
2024-06-14 13:14 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-24 8:11 ` Hogander, Jouni
2024-06-15 7:52 ` ✗ Fi.CI.IGT: " Patchwork
2024-06-24 8:21 ` Hogander, Jouni
2024-06-24 11:10 ` [PATCH i-g-t v3 0/7] Panel Replay eDP changes Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614053839.1822879-2-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox