From: "Jouni Högander" <jouni.hogander@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: kunal1.joshi@intel.com, ramanaidu.naladala@intel.com,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH i-g-t v3 7/7] lib/igt_psr: Adjust igt_wait intervals
Date: Fri, 14 Jun 2024 08:38:39 +0300 [thread overview]
Message-ID: <20240614053839.1822879-8-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240614053839.1822879-1-jouni.hogander@intel.com>
Currently we are observing problems with psr_wait_update. Poll interval is
10 ms. With eDP Panel Replay we are seeing scenario where on first poll PSR
status haven't yet changed to !SLEEP. Then we are waiting 10ms before next
check. During this 10ms sleep status changes to !SLEEP and back to SLEEP
and this is not noticed by psr_wait update and causing failure.
Fix this by adjusting poll intervals to 1ms.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
lib/igt_psr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index 42012243d..bc8e0e830 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -100,12 +100,12 @@ bool psr_wait_entry(int debugfs_fd, enum psr_mode mode, igt_output_t *output)
bool psr_wait_update(int debugfs_fd, enum psr_mode mode, igt_output_t *output)
{
- return igt_wait(!psr_active_check(debugfs_fd, mode, output), 40, 10);
+ return igt_wait(!psr_active_check(debugfs_fd, mode, output), 40, 1);
}
bool psr_long_wait_update(int debugfs_fd, enum psr_mode mode, igt_output_t *output)
{
- return igt_wait(!psr_active_check(debugfs_fd, mode, output), 500, 10);
+ return igt_wait(!psr_active_check(debugfs_fd, mode, output), 500, 1);
}
static ssize_t psr_write(int debugfs_fd, const char *buf, igt_output_t *output)
--
2.34.1
next prev parent reply other threads:[~2024-06-14 5:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 5:38 [PATCH i-g-t v3 0/7] Panel Replay eDP changes Jouni Högander
2024-06-14 5:38 ` [PATCH i-g-t v3 1/7] lib/igt_psr: Set Panel Replay disable bit for PSR modes Jouni Högander
2024-06-14 5:38 ` [PATCH i-g-t v3 2/7] lib/igt_psr: Psr status debugfs interface print "enabled" not "Enabled" Jouni Högander
2024-06-14 5:38 ` [PATCH i-g-t v3 3/7] lib/igt_psr: Handle PR_MODE2_SEL_FETCH and eDP PR_* in psr active check Jouni Högander
2024-06-14 5:38 ` [PATCH i-g-t v3 4/7] tests/intel/kms_psr_stress_test: Provide output to psr_wait_entry Jouni Högander
2024-06-14 5:38 ` [PATCH i-g-t v3 5/7] tests/kms_psr2_sf: Use stored psr mode instead of PSR_MODE_2_SEL_FETCH Jouni Högander
2024-06-21 9:17 ` [i-g-t, v3, " Joshi, Kunal1
2024-06-14 5:38 ` [PATCH i-g-t v3 6/7] lib/igt_psr: Fix PR_MODE sink support check Jouni Högander
2024-06-21 9:18 ` [i-g-t,v3,6/7] " Joshi, Kunal1
2024-06-14 5:38 ` Jouni Högander [this message]
2024-06-21 9:22 ` [i-g-t,v3,7/7] lib/igt_psr: Adjust igt_wait intervals Joshi, Kunal1
2024-06-14 7:36 ` ✓ Fi.CI.BAT: success for Panel Replay eDP changes (rev3) Patchwork
2024-06-14 7:40 ` ✓ CI.xeBAT: " Patchwork
2024-06-14 12:36 ` ✗ GitLab.Pipeline: warning " Patchwork
2024-06-14 13:14 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-24 8:11 ` Hogander, Jouni
2024-06-15 7:52 ` ✗ Fi.CI.IGT: " Patchwork
2024-06-24 8:21 ` Hogander, Jouni
2024-06-24 11:10 ` [PATCH i-g-t v3 0/7] Panel Replay eDP changes Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614053839.1822879-8-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox