From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Ewelina Musial <ewelina.musial@intel.com>,
Helen Koike <helen.koike@collabora.com>,
Jari Tahvanainen <jari.tahvanainen@intel.com>,
Petri Latvala <adrinael@adrinael.net>,
Rob Clark <robdclark@gmail.com>
Subject: [PATCH i-g-t] runner/settings: set PRUNE_KEEP_ALL as default
Date: Thu, 20 Jun 2024 15:02:16 +0200 [thread overview]
Message-ID: <20240620130216.85074-1-kamil.konieczny@linux.intel.com> (raw)
In testing drm-tip it is helpful to have reported all tests
results, especially when one have many dynamic ones we want
to get a parent result.
Cc: Ewelina Musial <ewelina.musial@intel.com>
Cc: Helen Koike <helen.koike@collabora.com>
Cc: Jari Tahvanainen <jari.tahvanainen@intel.com>
Cc: Petri Latvala <adrinael@adrinael.net>
Cc: Rob Clark <robdclark@gmail.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
runner/settings.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/runner/settings.c b/runner/settings.c
index 42d8137f1..eecadaf80 100644
--- a/runner/settings.c
+++ b/runner/settings.c
@@ -274,11 +274,11 @@ static const char *usage_str =
" results that are removed from the final results set.\n"
" Possible options:\n"
" keep-dynamic-subtests - Remove subtests that have dynamic\n"
- " subtests. (default)\n"
+ " subtests.\n"
" keep-dynamic - Alias for the above\n"
" keep-subtests - Remove dynamic subtests,\n"
" leaving just the parent subtest.\n"
- " keep-all - Don't remove anything\n"
+ " keep-all - Don't remove anything (default)\n"
" keep-requested - Remove reported results that are\n"
" not in the requested test set.\n"
" Useful when you have a hand-written\n"
@@ -672,6 +672,7 @@ bool parse_options(int argc, char **argv,
optind = 1;
settings->dmesg_warn_level = -1;
+ settings->prune_mode = -1;
while ((c = getopt_long(argc, argv, "hn:dt:x:e:sl:omb:L",
long_options, NULL)) != -1) {
@@ -791,6 +792,9 @@ bool parse_options(int argc, char **argv,
if (settings->dmesg_warn_level < 0)
settings->dmesg_warn_level = 4; /* KERN_WARN */
+ if (settings->prune_mode < 0)
+ settings->prune_mode = PRUNE_KEEP_ALL;
+
if (settings->list_all) { /* --list-all doesn't require results path */
switch (argc - optind) {
case 1:
--
2.43.0
next reply other threads:[~2024-06-20 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 13:02 Kamil Konieczny [this message]
2024-06-20 16:12 ` ✗ GitLab.Pipeline: warning for runner/settings: set PRUNE_KEEP_ALL as default Patchwork
2024-06-20 16:29 ` ✓ CI.xeBAT: success " Patchwork
2024-06-20 16:30 ` ✓ Fi.CI.BAT: " Patchwork
2024-06-20 18:31 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-21 4:28 ` ✗ Fi.CI.IGT: " Patchwork
2024-08-28 14:34 ` [PATCH i-g-t] " Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620130216.85074-1-kamil.konieczny@linux.intel.com \
--to=kamil.konieczny@linux.intel.com \
--cc=adrinael@adrinael.net \
--cc=ewelina.musial@intel.com \
--cc=helen.koike@collabora.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jari.tahvanainen@intel.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox