Re: [PATCH i-g-t] runner/settings: set PRUNE_KEEP_ALL as default

[Peter Senna Tschudin <peter.senna@intel.com>]

Tested by compilation-only.

On 20.06.2024 15:02, Kamil Konieczny wrote:
> In testing drm-tip it is helpful to have reported all tests
> results, especially when one have many dynamic ones we want
> to get a parent result.
> 
> Cc: Ewelina Musial <ewelina.musial@intel.com>
> Cc: Helen Koike <helen.koike@collabora.com>
> Cc: Jari Tahvanainen <jari.tahvanainen@intel.com>
> Cc: Petri Latvala <adrinael@adrinael.net>
> Cc: Rob Clark <robdclark@gmail.com>
Reviewed-by: Peter Senna Tschudin <peter.senna@intel.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  runner/settings.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/runner/settings.c b/runner/settings.c
> index 42d8137f1..eecadaf80 100644
> --- a/runner/settings.c
> +++ b/runner/settings.c
> @@ -274,11 +274,11 @@ static const char *usage_str =
>  	"                        results that are removed from the final results set.\n"
>  	"                        Possible options:\n"
>  	"                         keep-dynamic-subtests  - Remove subtests that have dynamic\n"
> -	"                                                  subtests. (default)\n"
> +	"                                                  subtests.\n"
>  	"                         keep-dynamic           - Alias for the above\n"
>  	"                         keep-subtests          - Remove dynamic subtests,\n"
>  	"                                                  leaving just the parent subtest.\n"
> -	"                         keep-all               - Don't remove anything\n"
> +	"                         keep-all               - Don't remove anything (default)\n"
>  	"                         keep-requested         - Remove reported results that are\n"
>  	"                                                  not in the requested test set.\n"
>  	"                                                  Useful when you have a hand-written\n"
> @@ -672,6 +672,7 @@ bool parse_options(int argc, char **argv,
>  	optind = 1;
>  
>  	settings->dmesg_warn_level = -1;
> +	settings->prune_mode = -1;
>  
>  	while ((c = getopt_long(argc, argv, "hn:dt:x:e:sl:omb:L",
>  				long_options, NULL)) != -1) {
> @@ -791,6 +792,9 @@ bool parse_options(int argc, char **argv,
>  	if (settings->dmesg_warn_level < 0)
>  		settings->dmesg_warn_level = 4; /* KERN_WARN */
>  
> +	if (settings->prune_mode < 0)
> +		settings->prune_mode = PRUNE_KEEP_ALL;
> +
>  	if (settings->list_all) { /* --list-all doesn't require results path */
>  		switch (argc - optind) {
>  		case 1:
Intel Semiconductor AG
Registered No. 020.30.913.786-7
Registered Office: Dufourstrasse 101 , 8008 Zurich, Switzerland