From: Dominik Karol Piatkowski <dominik.karol.piatkowski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Dominik Karol Piatkowski <dominik.karol.piatkowski@intel.com>
Subject: [PATCH i-g-t 1/1] lib/gpu_cmds: Fix hardcoded buffer size
Date: Mon, 24 Jun 2024 13:39:49 +0200 [thread overview]
Message-ID: <20240624113949.6846-2-dominik.karol.piatkowski@intel.com> (raw)
In-Reply-To: <20240624113949.6846-1-dominik.karol.piatkowski@intel.com>
This patch enables buffers larger than one page to be successfully
submitted, allowing for large shader execution.
Based on the find by Dominik Grzegorzek.
Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@intel.com>
---
lib/gpu_cmds.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
index 378fa9166..4f2781e7c 100644
--- a/lib/gpu_cmds.c
+++ b/lib/gpu_cmds.c
@@ -566,13 +566,13 @@ gen8_emit_state_base_address(struct intel_bb *ibb)
/* general state buffer size */
intel_bb_out(ibb, 0xfffff000 | 1);
/* dynamic state buffer size */
- intel_bb_out(ibb, 1 << 12 | 1);
+ intel_bb_out(ibb, ibb->size | 1);
/* indirect object buffer size */
intel_bb_out(ibb, 0xfffff000 | 1);
/* instruction buffer size, must set modify enable bit, otherwise it may
* result in GPU hang
*/
- intel_bb_out(ibb, 1 << 12 | 1);
+ intel_bb_out(ibb, ibb->size | 1);
}
void
@@ -610,13 +610,13 @@ gen9_emit_state_base_address(struct intel_bb *ibb)
/* general state buffer size */
intel_bb_out(ibb, 0xfffff000 | 1);
/* dynamic state buffer size */
- intel_bb_out(ibb, 1 << 12 | 1);
+ intel_bb_out(ibb, ibb->size | 1);
/* indirect object buffer size */
intel_bb_out(ibb, 0xfffff000 | 1);
/* intruction buffer size, must set modify enable bit, otherwise it may
* result in GPU hang
*/
- intel_bb_out(ibb, 1 << 12 | 1);
+ intel_bb_out(ibb, ibb->size | 1);
/* Bindless surface state base address */
intel_bb_out(ibb, 0 | BASE_ADDRESS_MODIFY);
@@ -1026,14 +1026,14 @@ xehp_emit_state_base_address(struct intel_bb *ibb)
/* general state buffer size */
intel_bb_out(ibb, 0xfffff000 | 1); //dw12
/* dynamic state buffer size */
- intel_bb_out(ibb, 1 << 12 | 1); //dw13
+ intel_bb_out(ibb, ibb->size | 1); //dw13
/* indirect object buffer size */
if (intel_graphics_ver(ibb->devid) >= IP_VER(20, 0)) //dw14
intel_bb_out(ibb, 0);
else
intel_bb_out(ibb, 0xfffff000 | 1);
/* intruction buffer size */
- intel_bb_out(ibb, 1 << 12 | 1); //dw15
+ intel_bb_out(ibb, ibb->size | 1); //dw15
/* Bindless surface state base address */
intel_bb_out(ibb, 0 | BASE_ADDRESS_MODIFY); //dw16
--
2.34.1
next prev parent reply other threads:[~2024-06-24 11:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 11:39 [PATCH i-g-t 0/1] lib/gpu_cmds: Fix hardcoded buffer size Dominik Karol Piatkowski
2024-06-24 11:39 ` Dominik Karol Piatkowski [this message]
2024-06-25 8:44 ` [PATCH i-g-t 1/1] " Grzegorzek, Dominik
2024-06-24 14:11 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-06-24 14:16 ` ✓ CI.xeBAT: " Patchwork
2024-06-24 17:24 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-25 12:31 ` [PATCH i-g-t 0/2] " Dominik Karol Piatkowski
2024-06-25 12:31 ` [PATCH i-g-t 1/2] " Dominik Karol Piatkowski
2024-06-25 12:31 ` [PATCH i-g-t 2/2] lib/gpu_cmds: Typo fix Dominik Karol Piatkowski
2024-06-26 11:33 ` Grzegorzek, Dominik
2024-06-25 12:55 ` ✗ Fi.CI.BUILD: failure for lib/gpu_cmds: Fix hardcoded buffer size Patchwork
2024-06-25 13:29 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624113949.6846-2-dominik.karol.piatkowski@intel.com \
--to=dominik.karol.piatkowski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox