From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>,
Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [PATCH i-g-t 3/3] tests/chamelium/kms_chamelium_color: prefer HDMI port for color tests to avoid DP FSM failures
Date: Tue, 25 Jun 2024 19:36:05 +0530 [thread overview]
Message-ID: <20240625140605.1420518-4-kunal1.joshi@intel.com> (raw)
In-Reply-To: <20240625140605.1420518-1-kunal1.joshi@intel.com>
Both DP and HDMI connectors are fine to capture, just we are more
stable on HDMI and sometimes face DP FSM failures, for color tests
prefer HDMI if its present, else use DP
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/chamelium/kms_chamelium_color.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/tests/chamelium/kms_chamelium_color.c b/tests/chamelium/kms_chamelium_color.c
index 392eaf1f4..5550cec22 100644
--- a/tests/chamelium/kms_chamelium_color.c
+++ b/tests/chamelium/kms_chamelium_color.c
@@ -468,6 +468,19 @@ static int test_setup(data_t *data, enum pipe p)
data->primary = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ /*
+ * Prefer to run this test on HDMI connector if its connected, since on DP we
+ * sometimes face DP FSM issue
+ */
+ for_each_valid_output_on_pipe(&data->display, p, data->output) {
+ for (i = 0; i < data->port_count; i++) {
+ if ((data->output->config.connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+ data->output->config.connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) &&
+ strcmp(data->output->name, chamelium_port_get_name(data->ports[i])) == 0)
+ return i;
+ }
+ }
+
for_each_valid_output_on_pipe(&data->display, p, data->output) {
for (i = 0; i < data->port_count; i++) {
if (strcmp(data->output->name,
--
2.25.1
next prev parent reply other threads:[~2024-06-25 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 14:06 [PATCH i-g-t 0/3] tests/chamelium: fixes for chamelium tests Kunal Joshi
2024-06-25 14:06 ` [PATCH i-g-t 1/3] lib/igt_debugfs: handle xe driver as well Kunal Joshi
2024-06-25 14:06 ` [PATCH i-g-t 2/3] tests/chamelium/kms_chamelium_color: plug ports before starting the test Kunal Joshi
2024-06-25 14:07 ` Modem, Bhanuprakash
2024-06-25 14:06 ` Kunal Joshi [this message]
2024-06-25 14:08 ` [PATCH i-g-t 3/3] tests/chamelium/kms_chamelium_color: prefer HDMI port for color tests to avoid DP FSM failures Modem, Bhanuprakash
2024-06-25 15:41 ` ✓ CI.xeBAT: success for tests/chamelium: fixes for chamelium tests (rev2) Patchwork
2024-06-25 15:49 ` ✓ Fi.CI.BAT: " Patchwork
2024-06-25 18:09 ` ✓ CI.xeFULL: " Patchwork
2024-06-26 10:21 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625140605.1420518-4-kunal1.joshi@intel.com \
--to=kunal1.joshi@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox