Re: [PATCH i-g-t 2/3] tests/chamelium/kms_chamelium_color: plug ports before starting the test

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

On 25-06-2024 07:36 pm, Kunal Joshi wrote:
> There is no harm in plugging discovered ports,
> just incase they are not plugged we skip in test_setup
> 
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>

Cc: Mark Yacoub <markyacoub@chromium.org>

LGTM:
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

> ---
>   tests/chamelium/kms_chamelium_color.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/tests/chamelium/kms_chamelium_color.c b/tests/chamelium/kms_chamelium_color.c
> index 4156023da..392eaf1f4 100644
> --- a/tests/chamelium/kms_chamelium_color.c
> +++ b/tests/chamelium/kms_chamelium_color.c
> @@ -709,6 +709,7 @@ run_tests_for_pipe(data_t *data)
>   
>   igt_main
>   {
> +	int i;
>   	data_t data = {};
>   
>   	igt_fixture {
> @@ -730,6 +731,13 @@ igt_main
>   
>   		if (!data.port_count)
>   			igt_skip("No ports connected\n");
> +		/*
> +		 * We don't cause any harm by plugging
> +		 * discovered ports, just incase they are not plugged
> +		 * we currently skip in test_setup
> +		 */
> +		for( i = 0; i < data.port_count; i++)
> +			chamelium_plug(data.chamelium, data.ports[i]);
>   
>   		kmstest_set_vt_graphics_mode();
>   	}