[PATCH i-g-t] tests/xe_intel_bb: Reduce render subtest execution time

[PATCH i-g-t] tests/xe_intel_bb: Reduce render subtest execution time

[Zbigniew Kempczyński]

Test xe_intel_bb verifies intel-bb so it doesn't make sense to perform
large render operations as those are covered in xe_render_copy test.
Use 256px surface for render instead 512 and 1024 px.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 tests/intel/xe_intel_bb.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/tests/intel/xe_intel_bb.c b/tests/intel/xe_intel_bb.c
index 5dd794b186..647fd64e7e 100644
--- a/tests/intel/xe_intel_bb.c
+++ b/tests/intel/xe_intel_bb.c
@@ -40,6 +40,7 @@
 #define HEIGHT	64
 #define STRIDE	(WIDTH * 4)
 #define SIZE	(HEIGHT * STRIDE)
+#define RENDER_WIDTH 256
 
 #define COLOR_00	0x00
 #define COLOR_33	0x33
@@ -1054,11 +1055,11 @@ igt_main_args("dpib", NULL, help_str, opt_handler, NULL)
 			if (!render_supports_tiling(xe, tiling, false))
 				continue;
 
-			for (width = 512; width <= 1024; width += 512)
-				igt_dynamic_f("render-%s-%u",
-					      blt_tiling_name(tiling), width)
-					render(bops, blt_tile_to_i915_tile(tiling),
-					       width, width);
+			width = RENDER_WIDTH;
+			igt_dynamic_f("render-%s-%u",
+				      blt_tiling_name(tiling), width)
+				render(bops, blt_tile_to_i915_tile(tiling),
+				       width, width);
 		}
 	}
 
-- 
2.34.1

RE: [PATCH i-g-t] tests/xe_intel_bb: Reduce render subtest execution time

[Piecielska, Katarzyna]

LGTM 😊 Let's do this.

Acked-by: Katarzyna Piecielska <katarzyna.piecielska@intel.com>

Kasia

-----Original Message-----
From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Zbigniew Kempczynski
Sent: Wednesday, July 3, 2024 8:33 AM
To: igt-dev@lists.freedesktop.org
Cc: Kempczynski, Zbigniew <zbigniew.kempczynski@intel.com>; Kamil Konieczny <kamil.konieczny@linux.intel.com>
Subject: [PATCH i-g-t] tests/xe_intel_bb: Reduce render subtest execution time

Test xe_intel_bb verifies intel-bb so it doesn't make sense to perform large render operations as those are covered in xe_render_copy test.
Use 256px surface for render instead 512 and 1024 px.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 tests/intel/xe_intel_bb.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/tests/intel/xe_intel_bb.c b/tests/intel/xe_intel_bb.c index 5dd794b186..647fd64e7e 100644
--- a/tests/intel/xe_intel_bb.c
+++ b/tests/intel/xe_intel_bb.c
@@ -40,6 +40,7 @@
 #define HEIGHT	64
 #define STRIDE	(WIDTH * 4)
 #define SIZE	(HEIGHT * STRIDE)
+#define RENDER_WIDTH 256
 
 #define COLOR_00	0x00
 #define COLOR_33	0x33
@@ -1054,11 +1055,11 @@ igt_main_args("dpib", NULL, help_str, opt_handler, NULL)
 			if (!render_supports_tiling(xe, tiling, false))
 				continue;
 
-			for (width = 512; width <= 1024; width += 512)
-				igt_dynamic_f("render-%s-%u",
-					      blt_tiling_name(tiling), width)
-					render(bops, blt_tile_to_i915_tile(tiling),
-					       width, width);
+			width = RENDER_WIDTH;
+			igt_dynamic_f("render-%s-%u",
+				      blt_tiling_name(tiling), width)
+				render(bops, blt_tile_to_i915_tile(tiling),
+				       width, width);
 		}
 	}
 
--
2.34.1

Re: [PATCH i-g-t] tests/xe_intel_bb: Reduce render subtest execution time

[Kamil Konieczny]

Hi Zbigniew,
On 2024-07-03 at 08:33:14 +0200, Zbigniew Kempczyński wrote:
> Test xe_intel_bb verifies intel-bb so it doesn't make sense to perform
> large render operations as those are covered in xe_render_copy test.
> Use 256px surface for render instead 512 and 1024 px.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>

LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

I will merge this without waiting for CI as this works on my
test machine and it just reduced number of performed tests.

Regards,
Kamil

> ---
>  tests/intel/xe_intel_bb.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/intel/xe_intel_bb.c b/tests/intel/xe_intel_bb.c
> index 5dd794b186..647fd64e7e 100644
> --- a/tests/intel/xe_intel_bb.c
> +++ b/tests/intel/xe_intel_bb.c
> @@ -40,6 +40,7 @@
>  #define HEIGHT	64
>  #define STRIDE	(WIDTH * 4)
>  #define SIZE	(HEIGHT * STRIDE)
> +#define RENDER_WIDTH 256
>  
>  #define COLOR_00	0x00
>  #define COLOR_33	0x33
> @@ -1054,11 +1055,11 @@ igt_main_args("dpib", NULL, help_str, opt_handler, NULL)
>  			if (!render_supports_tiling(xe, tiling, false))
>  				continue;
>  
> -			for (width = 512; width <= 1024; width += 512)
> -				igt_dynamic_f("render-%s-%u",
> -					      blt_tiling_name(tiling), width)
> -					render(bops, blt_tile_to_i915_tile(tiling),
> -					       width, width);
> +			width = RENDER_WIDTH;
> +			igt_dynamic_f("render-%s-%u",
> +				      blt_tiling_name(tiling), width)
> +				render(bops, blt_tile_to_i915_tile(tiling),
> +				       width, width);
>  		}
>  	}
>  
> -- 
> 2.34.1
> 

Re: [PATCH i-g-t] tests/xe_intel_bb: Reduce render subtest execution time

[Zbigniew Kempczyński]

On Wed, Jul 03, 2024 at 12:12:22PM +0200, Kamil Konieczny wrote:
> Hi Zbigniew,
> On 2024-07-03 at 08:33:14 +0200, Zbigniew Kempczyński wrote:
> > Test xe_intel_bb verifies intel-bb so it doesn't make sense to perform
> > large render operations as those are covered in xe_render_copy test.
> > Use 256px surface for render instead 512 and 1024 px.
> > 
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> 
> LGTM,
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> 
> I will merge this without waiting for CI as this works on my
> test machine and it just reduced number of performed tests.

Thank you for the review and merge.

--
Zbigniew

> 
> Regards,
> Kamil
> 
> > ---
> >  tests/intel/xe_intel_bb.c | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tests/intel/xe_intel_bb.c b/tests/intel/xe_intel_bb.c
> > index 5dd794b186..647fd64e7e 100644
> > --- a/tests/intel/xe_intel_bb.c
> > +++ b/tests/intel/xe_intel_bb.c
> > @@ -40,6 +40,7 @@
> >  #define HEIGHT	64
> >  #define STRIDE	(WIDTH * 4)
> >  #define SIZE	(HEIGHT * STRIDE)
> > +#define RENDER_WIDTH 256
> >  
> >  #define COLOR_00	0x00
> >  #define COLOR_33	0x33
> > @@ -1054,11 +1055,11 @@ igt_main_args("dpib", NULL, help_str, opt_handler, NULL)
> >  			if (!render_supports_tiling(xe, tiling, false))
> >  				continue;
> >  
> > -			for (width = 512; width <= 1024; width += 512)
> > -				igt_dynamic_f("render-%s-%u",
> > -					      blt_tiling_name(tiling), width)
> > -					render(bops, blt_tile_to_i915_tile(tiling),
> > -					       width, width);
> > +			width = RENDER_WIDTH;
> > +			igt_dynamic_f("render-%s-%u",
> > +				      blt_tiling_name(tiling), width)
> > +				render(bops, blt_tile_to_i915_tile(tiling),
> > +				       width, width);
> >  		}
> >  	}
> >  
> > -- 
> > 2.34.1
> > 

✗ Fi.CI.BAT: failure for tests/xe_intel_bb: Reduce render subtest execution time

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

== Series Details ==

Series: tests/xe_intel_bb: Reduce render subtest execution time
URL   : https://patchwork.freedesktop.org/series/135678/
State : failure

== Summary ==

Series 135678 revision 1 was fully merged or fully failed: no git log



[-- Attachment #2: Type: text/html, Size: 716 bytes --]