From: sk.anirban@intel.com
To: igt-dev@lists.freedesktop.org, anshuman.gupta@intel.com
Cc: vinay.belgaumkar@intel.com, aravind.iddamsetty@intel.com,
sk.anirban@intel.com, riana.tauro@intel.com,
Tauro@freedesktop.org
Subject: [PATCH i-g-t, v3] tests/intel/i915_pm_rps: Disable threshold subtests when SLPC is enabled
Date: Fri, 26 Jul 2024 12:21:12 +0530 [thread overview]
Message-ID: <20240726065112.106444-1-sk.anirban@intel.com> (raw)
From: Sk Anirban <sk.anirban@intel.com>
Skip these tests when SLPC is enabled as it fails frequently.
These tests are designed for host turbo and sysfs is not available
when SLPC is enabled.
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11455
v2: Add a skip all the threesold subtests
Provide explanations for failures (Riana)
Addressed cosmetic review comments (Riana)
v3: Addressed cosmetic review comments (Riana)
Reviewed-by: Tauro, Riana <riana.tauro@intel.com>
Signed-off-by: Sk Anirban <sk.anirban@intel.com>
---
tests/intel/i915_pm_rps.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tests/intel/i915_pm_rps.c b/tests/intel/i915_pm_rps.c
index 99b83f315..ace22b00c 100644
--- a/tests/intel/i915_pm_rps.c
+++ b/tests/intel/i915_pm_rps.c
@@ -1161,7 +1161,8 @@ igt_main
igt_subtest_with_dynamic("thresholds-idle") {
int tmp, gt;
-
+ igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
+ "This subtest is not supported when SLPC is enabled\n");
i915_for_each_gt(drm_fd, tmp, gt) {
igt_dynamic_f("gt%u", gt)
test_thresholds(drm_fd, gt, TEST_IDLE);
@@ -1170,7 +1171,8 @@ igt_main
igt_subtest_with_dynamic("thresholds") {
int tmp, gt;
-
+ igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
+ "This subtest is not supported when SLPC is enabled\n");
i915_for_each_gt(drm_fd, tmp, gt) {
igt_dynamic_f("gt%u", gt)
test_thresholds(drm_fd, gt, 0);
@@ -1179,7 +1181,8 @@ igt_main
igt_subtest_with_dynamic("thresholds-park") {
int tmp, gt;
-
+ igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
+ "This subtest is not supported when SLPC is enabled\n");
i915_for_each_gt(drm_fd, tmp, gt) {
igt_dynamic_f("gt%u", gt)
test_thresholds(drm_fd, gt, TEST_PARK);
@@ -1188,6 +1191,8 @@ igt_main
igt_subtest_with_dynamic("thresholds-idle-park") {
int tmp, gt;
+ igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
+ "This subtest is not supported when SLPC is enabled\n");
i915_for_each_gt(drm_fd, tmp, gt) {
igt_dynamic_f("gt%u", gt)
--
2.34.1
next reply other threads:[~2024-07-26 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 6:51 sk.anirban [this message]
2024-07-26 6:55 ` [PATCH i-g-t,v3] tests/intel/i915_pm_rps: Disable threshold subtests when SLPC is enabled Riana Tauro
2024-07-26 7:25 ` ✓ CI.xeBAT: success for " Patchwork
2024-07-26 7:36 ` ✓ Fi.CI.BAT: " Patchwork
2024-07-26 17:17 ` ✗ CI.xeFULL: failure " Patchwork
2024-07-27 1:18 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240726065112.106444-1-sk.anirban@intel.com \
--to=sk.anirban@intel.com \
--cc=Tauro@freedesktop.org \
--cc=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=riana.tauro@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox