Re: [PATCH i-g-t,v3] tests/intel/i915_pm_rps: Disable threshold subtests when SLPC is enabled

[Riana Tauro <riana.tauro@intel.com>]

Hi Anirban

On 7/26/2024 12:21 PM, sk.anirban@intel.com wrote:
> From: Sk Anirban <sk.anirban@intel.com>
> 
> Skip these tests when SLPC is enabled as it fails frequently.
> These tests are designed for host turbo and sysfs is not available
> when SLPC is enabled.
> 
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11455
> 
> v2: Add a skip all the threesold subtests
Typo again
>      Provide explanations for failures (Riana)
>      Addressed cosmetic review comments (Riana)
> v3: Addressed cosmetic review comments (Riana)
> 
> Reviewed-by: Tauro, Riana <riana.tauro@intel.com>
Wrong format. No comma First name and then last name
Copy paste the RB sent.

Thanks,
Riana
> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> ---
>   tests/intel/i915_pm_rps.c | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/intel/i915_pm_rps.c b/tests/intel/i915_pm_rps.c
> index 99b83f315..ace22b00c 100644
> --- a/tests/intel/i915_pm_rps.c
> +++ b/tests/intel/i915_pm_rps.c
> @@ -1161,7 +1161,8 @@ igt_main
>   
>   	igt_subtest_with_dynamic("thresholds-idle") {
>   		int tmp, gt;
> -
> +		igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
> +			      "This subtest is not supported when SLPC is enabled\n");
>   		i915_for_each_gt(drm_fd, tmp, gt) {
>   			igt_dynamic_f("gt%u", gt)
>   				test_thresholds(drm_fd, gt, TEST_IDLE);
> @@ -1170,7 +1171,8 @@ igt_main
>   
>   	igt_subtest_with_dynamic("thresholds") {
>   		int tmp, gt;
> -
> +		igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
> +			      "This subtest is not supported when SLPC is enabled\n");
>   		i915_for_each_gt(drm_fd, tmp, gt) {
>   			igt_dynamic_f("gt%u", gt)
>   				test_thresholds(drm_fd, gt, 0);
> @@ -1179,7 +1181,8 @@ igt_main
>   
>   	igt_subtest_with_dynamic("thresholds-park") {
>   		int tmp, gt;
> -
> +		igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
> +			      "This subtest is not supported when SLPC is enabled\n");
>   		i915_for_each_gt(drm_fd, tmp, gt) {
>   			igt_dynamic_f("gt%u", gt)
>   				test_thresholds(drm_fd, gt, TEST_PARK);
> @@ -1188,6 +1191,8 @@ igt_main
>   
>   	igt_subtest_with_dynamic("thresholds-idle-park") {
>   		int tmp, gt;
> +		igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
> +			      "This subtest is not supported when SLPC is enabled\n");
>   
>   		i915_for_each_gt(drm_fd, tmp, gt) {
>   			igt_dynamic_f("gt%u", gt)