Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t, v3] tests/intel/i915_pm_rps: Disable threshold subtests when SLPC is enabled
@ 2024-07-26  6:51 sk.anirban
  2024-07-26  6:55 ` [PATCH i-g-t,v3] " Riana Tauro
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: sk.anirban @ 2024-07-26  6:51 UTC (permalink / raw)
  To: igt-dev, anshuman.gupta
  Cc: vinay.belgaumkar, aravind.iddamsetty, sk.anirban, riana.tauro,
	Tauro

From: Sk Anirban <sk.anirban@intel.com>

Skip these tests when SLPC is enabled as it fails frequently. 
These tests are designed for host turbo and sysfs is not available 
when SLPC is enabled.

Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11455

v2: Add a skip all the threesold subtests
    Provide explanations for failures (Riana)
    Addressed cosmetic review comments (Riana)
v3: Addressed cosmetic review comments (Riana)

Reviewed-by: Tauro, Riana <riana.tauro@intel.com>
Signed-off-by: Sk Anirban <sk.anirban@intel.com>
---
 tests/intel/i915_pm_rps.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/tests/intel/i915_pm_rps.c b/tests/intel/i915_pm_rps.c
index 99b83f315..ace22b00c 100644
--- a/tests/intel/i915_pm_rps.c
+++ b/tests/intel/i915_pm_rps.c
@@ -1161,7 +1161,8 @@ igt_main
 
 	igt_subtest_with_dynamic("thresholds-idle") {
 		int tmp, gt;
-
+		igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
+			      "This subtest is not supported when SLPC is enabled\n");
 		i915_for_each_gt(drm_fd, tmp, gt) {
 			igt_dynamic_f("gt%u", gt)
 				test_thresholds(drm_fd, gt, TEST_IDLE);
@@ -1170,7 +1171,8 @@ igt_main
 
 	igt_subtest_with_dynamic("thresholds") {
 		int tmp, gt;
-
+		igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
+			      "This subtest is not supported when SLPC is enabled\n");
 		i915_for_each_gt(drm_fd, tmp, gt) {
 			igt_dynamic_f("gt%u", gt)
 				test_thresholds(drm_fd, gt, 0);
@@ -1179,7 +1181,8 @@ igt_main
 
 	igt_subtest_with_dynamic("thresholds-park") {
 		int tmp, gt;
-
+		igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
+			      "This subtest is not supported when SLPC is enabled\n");
 		i915_for_each_gt(drm_fd, tmp, gt) {
 			igt_dynamic_f("gt%u", gt)
 				test_thresholds(drm_fd, gt, TEST_PARK);
@@ -1188,6 +1191,8 @@ igt_main
 
 	igt_subtest_with_dynamic("thresholds-idle-park") {
 		int tmp, gt;
+		igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
+			      "This subtest is not supported when SLPC is enabled\n");
 
 		i915_for_each_gt(drm_fd, tmp, gt) {
 			igt_dynamic_f("gt%u", gt)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-07-27  1:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-26  6:51 [PATCH i-g-t, v3] tests/intel/i915_pm_rps: Disable threshold subtests when SLPC is enabled sk.anirban
2024-07-26  6:55 ` [PATCH i-g-t,v3] " Riana Tauro
2024-07-26  7:25 ` ✓ CI.xeBAT: success for " Patchwork
2024-07-26  7:36 ` ✓ Fi.CI.BAT: " Patchwork
2024-07-26 17:17 ` ✗ CI.xeFULL: failure " Patchwork
2024-07-27  1:18 ` ✗ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox