Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 i-g-t v2] tests/core_setmaster: Change break to continue in tweak_perm function
@ 2024-07-26 10:26 Bommu Krishnaiah
  2024-07-26 12:11 ` ✓ CI.xeBAT: success for tests/core_setmaster: Change break to continue in tweak_perm function (rev2) Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Bommu Krishnaiah @ 2024-07-26 10:26 UTC (permalink / raw)
  To: igt-dev; +Cc: Bommu Krishnaiah, Emil Velikov, Himal Prasad Ghimiray

Existing userspace assumes there's no gaps card’s, but I see cards
are not continues, after running “gta@core_hotunplug I am not seeing card0,
hence test is failing.

Failure sequence:

card0  renderD128  version

Subtest master-drop-set-user: SUCCESS (0.061s)

card0  renderD128  version

Subtest hotrebind-lateclose: SUCCESS (2.791s)

ls /sys/class/drm/
card1  renderD129  version

root@DUT4419LNL:/usr/local/libexec/igt-gpu-tools# ./core_setmaster --r master-drop-set-user
Subtest master-drop-set-user: FAIL (0.017s)

Failure on XE

Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
 tests/core_setmaster.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/core_setmaster.c b/tests/core_setmaster.c
index 9c2083f66..60ae06331 100644
--- a/tests/core_setmaster.c
+++ b/tests/core_setmaster.c
@@ -116,9 +116,8 @@ static unsigned tweak_perm(uint8_t *saved_perm, unsigned max_perm, bool save)
 	for (i = 0; i < max_perm; i++) {
 		snprintf(path, sizeof(path), "/dev/dri/card%u", i);
 
-		/* Existing userspace assumes there's no gaps, do the same. */
 		if (stat(path, &st) != 0)
-			break;
+			continue;
 
 		if (save) {
 			/* Save and toggle */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-07-27  5:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-26 10:26 [PATCH v2 i-g-t v2] tests/core_setmaster: Change break to continue in tweak_perm function Bommu Krishnaiah
2024-07-26 12:11 ` ✓ CI.xeBAT: success for tests/core_setmaster: Change break to continue in tweak_perm function (rev2) Patchwork
2024-07-26 12:19 ` ✓ Fi.CI.BAT: " Patchwork
2024-07-26 17:00 ` [PATCH v2 i-g-t v2] tests/core_setmaster: Change break to continue in tweak_perm function Kamil Konieczny
2024-07-26 22:42 ` ✓ CI.xeFULL: success for tests/core_setmaster: Change break to continue in tweak_perm function (rev2) Patchwork
2024-07-27  5:52 ` ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox