Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Manszewski <christoph.manszewski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	"Dominik Grzegorzek" <dominik.grzegorzek@intel.com>,
	"Maciej Patelczyk" <maciej.patelczyk@intel.com>,
	"Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>,
	"Pawel Sikora" <pawel.sikora@intel.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Kolanupaka Naveena" <kolanupaka.naveena@intel.com>,
	"Mika Kuoppala" <mika.kuoppala@intel.com>,
	"Gwan-gyeong Mun" <gwan-gyeong.mun@intel.com>,
	"Christoph Manszewski" <christoph.manszewski@intel.com>
Subject: [PATCH i-g-t v3 08/14] lib/gpgpu_shader: Add set/clear exception register (cr0.1) helpers
Date: Fri,  9 Aug 2024 14:38:07 +0200	[thread overview]
Message-ID: <20240809123813.109365-9-christoph.manszewski@intel.com> (raw)
In-Reply-To: <20240809123813.109365-1-christoph.manszewski@intel.com>

From: Andrzej Hajda <andrzej.hajda@intel.com>

To allow enabling and handling exceptions from shader and siplet
proper helpers should be provided.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Christoph Manszewski <christoph.manszewski@intel.com>
---
 lib/gpgpu_shader.c          | 28 ++++++++++++++++++++++++++++
 lib/gpgpu_shader.h          |  2 ++
 lib/iga64_generated_codes.c | 32 +++++++++++++++++++++++++++++++-
 3 files changed, 61 insertions(+), 1 deletion(-)

diff --git a/lib/gpgpu_shader.c b/lib/gpgpu_shader.c
index a98abc57e..40161c52b 100644
--- a/lib/gpgpu_shader.c
+++ b/lib/gpgpu_shader.c
@@ -628,6 +628,34 @@ void gpgpu_shader__write_dword(struct gpgpu_shader *shdr, uint32_t value,
 	", 2, y_offset, 3, value, value, value, value);
 }
 
+/**
+ * gpgpu_shader__clear_exception:
+ * @shdr: shader to be modified
+ * @value: exception bits to be cleared
+ *
+ * Clear provided bits in exception register: cr0.1 &= ~value.
+ */
+void gpgpu_shader__clear_exception(struct gpgpu_shader *shdr, uint32_t value)
+{
+	emit_iga64_code(shdr, clear_exception, "		\n\
+(W)	and (1|M0) cr0.1<1>:ud cr0.1<0;1,0>:ud ARG(0):ud	\n\
+	", ~value);
+}
+
+/**
+ * gpgpu_shader__set_exception:
+ * @shdr: shader to be modified
+ * @value: exception bits to be set
+ *
+ * Set provided bits in exception register: cr0.1 |= value.
+ */
+void gpgpu_shader__set_exception(struct gpgpu_shader *shdr, uint32_t value)
+{
+	emit_iga64_code(shdr, set_exception, "		\n\
+(W)	or (1|M0) cr0.1<1>:ud cr0.1<0;1,0>:ud ARG(0):ud	\n\
+	", value);
+}
+
 /**
  * gpgpu_shader__write_on_exception:
  * @shdr: shader to be modified
diff --git a/lib/gpgpu_shader.h b/lib/gpgpu_shader.h
index 76ff4989e..0bbeae66f 100644
--- a/lib/gpgpu_shader.h
+++ b/lib/gpgpu_shader.h
@@ -66,6 +66,8 @@ void gpgpu_shader__common_target_write(struct gpgpu_shader *shdr,
 				       uint32_t y_offset, const uint32_t value[4]);
 void gpgpu_shader__common_target_write_u32(struct gpgpu_shader *shdr,
 				     uint32_t y_offset, uint32_t value);
+void gpgpu_shader__clear_exception(struct gpgpu_shader *shdr, uint32_t value);
+void gpgpu_shader__set_exception(struct gpgpu_shader *shdr, uint32_t value);
 void gpgpu_shader__end_system_routine(struct gpgpu_shader *shdr,
 				      bool breakpoint_suppress);
 void gpgpu_shader__end_system_routine_step_if_eq(struct gpgpu_shader *shdr,
diff --git a/lib/iga64_generated_codes.c b/lib/iga64_generated_codes.c
index 71429d442..2cba1b315 100644
--- a/lib/iga64_generated_codes.c
+++ b/lib/iga64_generated_codes.c
@@ -3,7 +3,7 @@
 
 #include "gpgpu_shader.h"
 
-#define MD5_SUM_IGA64_ASMS 88529cc180578939c0b8c4bb29da7db6
+#define MD5_SUM_IGA64_ASMS 6cfe013e2a99076bcdf69ecdbf4333cf
 
 struct iga64_template const iga64_code_end_system_routine_step_if_eq[] = {
 	{ .gen_ver = 2000, .size = 44, .code = (const uint32_t []) {
@@ -170,6 +170,36 @@ struct iga64_template const iga64_code_write_on_exception[] = {
 	}}
 };
 
+struct iga64_template const iga64_code_set_exception[] = {
+	{ .gen_ver = 1272, .size = 8, .code = (const uint32_t []) {
+		0x80000966, 0x80118220, 0x02008010, 0xc0ded000,
+		0x80000901, 0x00010000, 0x00000000, 0x00000000,
+	}},
+	{ .gen_ver = 1250, .size = 8, .code = (const uint32_t []) {
+		0x80000966, 0x80218220, 0x02008020, 0xc0ded000,
+		0x80000901, 0x00010000, 0x00000000, 0x00000000,
+	}},
+	{ .gen_ver = 0, .size = 8, .code = (const uint32_t []) {
+		0x80000166, 0x80218220, 0x02008020, 0xc0ded000,
+		0x80000101, 0x00010000, 0x00000000, 0x00000000,
+	}}
+};
+
+struct iga64_template const iga64_code_clear_exception[] = {
+	{ .gen_ver = 1272, .size = 8, .code = (const uint32_t []) {
+		0x80000965, 0x80118220, 0x02008010, 0xc0ded000,
+		0x80000901, 0x00010000, 0x00000000, 0x00000000,
+	}},
+	{ .gen_ver = 1250, .size = 8, .code = (const uint32_t []) {
+		0x80000965, 0x80218220, 0x02008020, 0xc0ded000,
+		0x80000901, 0x00010000, 0x00000000, 0x00000000,
+	}},
+	{ .gen_ver = 0, .size = 8, .code = (const uint32_t []) {
+		0x80000165, 0x80218220, 0x02008020, 0xc0ded000,
+		0x80000101, 0x00010000, 0x00000000, 0x00000000,
+	}}
+};
+
 struct iga64_template const iga64_code_media_block_write[] = {
 	{ .gen_ver = 2000, .size = 56, .code = (const uint32_t []) {
 		0x80000061, 0x05054220, 0x00000000, 0xc0ded003,
-- 
2.34.1


  parent reply	other threads:[~2024-08-09 12:39 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 12:37 [PATCH i-g-t v3 00/14] Test coverage for GPU debug support Christoph Manszewski
2024-08-09 12:38 ` [PATCH i-g-t v3 01/14] drm-uapi/xe: Sync with oa uapi fix Christoph Manszewski
2024-08-09 14:21   ` Kamil Konieczny
2024-08-09 12:38 ` [PATCH i-g-t v3 02/14] drm-uapi/xe: Sync with eudebug uapi Christoph Manszewski
2024-08-20  7:52   ` Zbigniew Kempczyński
2024-08-09 12:38 ` [PATCH i-g-t v3 03/14] lib/xe_ioctl: Add wrapper with vm_bind_op extension parameter Christoph Manszewski
2024-08-20  7:54   ` Zbigniew Kempczyński
2024-08-09 12:38 ` [PATCH i-g-t v3 04/14] lib/xe_eudebug: Introduce eu debug testing framework Christoph Manszewski
2024-08-19  8:30   ` Grzegorzek, Dominik
2024-08-19 15:33     ` Manszewski, Christoph
2024-08-20  8:14   ` Zbigniew Kempczyński
2024-08-20 16:14     ` Manszewski, Christoph
2024-08-20 17:45       ` Kamil Konieczny
2024-08-21  7:05         ` Manszewski, Christoph
2024-08-21  9:31         ` Zbigniew Kempczyński
2024-08-22 15:39           ` Kamil Konieczny
2024-08-23  7:58             ` Manszewski, Christoph
2024-08-09 12:38 ` [PATCH i-g-t v3 05/14] tests/xe_eudebug: Test eudebug resource tracking and manipulation Christoph Manszewski
2024-08-09 12:38 ` [PATCH i-g-t v3 06/14] lib/gpgpu_shader: Extend shader building library Christoph Manszewski
2024-08-09 12:38 ` [PATCH i-g-t v3 07/14] lib/gpgpu_shader: Add write_on_exception template Christoph Manszewski
2024-08-19 10:09   ` Grzegorzek, Dominik
2024-08-09 12:38 ` Christoph Manszewski [this message]
2024-08-09 12:38 ` [PATCH i-g-t v3 09/14] lib/intel_batchbuffer: Add helper to get pointer at specified offset Christoph Manszewski
2024-08-19 10:10   ` Grzegorzek, Dominik
2024-08-09 12:38 ` [PATCH i-g-t v3 10/14] lib/gpgpu_shader: Allow enabling illegal opcode exceptions in shader Christoph Manszewski
2024-08-19 10:12   ` Grzegorzek, Dominik
2024-08-09 12:38 ` [PATCH i-g-t v3 11/14] tests/xe_exec_sip: Extend SIP interaction testing Christoph Manszewski
2024-08-21  9:49   ` Zbigniew Kempczyński
2024-08-09 12:38 ` [PATCH i-g-t v3 12/14] lib/intel_batchbuffer: Add support for long-running mode execution Christoph Manszewski
2024-08-09 12:38 ` [PATCH i-g-t v3 13/14] tests/xe_eudebug_online: Debug client which runs workloads on EU Christoph Manszewski
2024-08-09 14:38   ` Kamil Konieczny
2024-08-19 15:31     ` Manszewski, Christoph
2024-08-19  9:58   ` Grzegorzek, Dominik
2024-08-19 15:36     ` Manszewski, Christoph
2024-08-09 12:38 ` [PATCH i-g-t v3 14/14] tests/xe_live_ktest: Add xe_eudebug live test Christoph Manszewski
2024-08-09 13:36 ` ✗ GitLab.Pipeline: warning for Test coverage for GPU debug support (rev3) Patchwork
2024-08-09 13:50 ` ✓ CI.xeBAT: success " Patchwork
2024-08-09 14:01 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-09 14:24 ` [PATCH i-g-t v3 00/14] Test coverage for GPU debug support Kamil Konieczny
2024-08-09 15:40 ` ✗ CI.xeFULL: failure for Test coverage for GPU debug support (rev3) Patchwork
2024-08-10 18:30 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240809123813.109365-9-christoph.manszewski@intel.com \
    --to=christoph.manszewski@intel.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dominik.grzegorzek@intel.com \
    --cc=dominik.karol.piatkowski@intel.com \
    --cc=gwan-gyeong.mun@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=kolanupaka.naveena@intel.com \
    --cc=maciej.patelczyk@intel.com \
    --cc=mika.kuoppala@intel.com \
    --cc=pawel.sikora@intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox