Re: [PATCH i-g-t v3 13/14] tests/xe_eudebug_online: Debug client which runs workloads on EU

["Manszewski, Christoph" <christoph.manszewski@intel.com>]

Hi Kamil,

On 9.08.2024 16:38, Kamil Konieczny wrote:
> Hi Christoph,
> On 2024-08-09 at 14:38:12 +0200, Christoph Manszewski wrote:
>> From: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
>>
>> For typical debugging under gdb one can specify two main usecases:
>> accessing and manupulating resources created by the application and
>> manipulating thread execution (interrupting and setting breakpoints).
>>
>> This test adds coverage for the latter by checking that:
>> - EU workloads that hit a instruction with breakpoint bit set will stop
>>    halt execution and the debugger will report this via attention events,
>> - the debugger is able to interrupt workload execution by issuing a
>>    'interrupt_all' ioctl call,
>> - the debugger is able to resume selected workloads that are stopped.
>>
>> Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>> Signed-off-by: Christoph Manszewski <christoph.manszewski@intel.com>
>> Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@intel.com>
>> Signed-off-by: Pawel Sikora <pawel.sikora@intel.com>
>> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
>> Signed-off-by: Kolanupaka Naveena <kolanupaka.naveena@intel.com>
>> ---
>>   tests/intel/xe_eudebug_online.c | 2203 +++++++++++++++++++++++++++++++
>>   tests/meson.build               |    1 +
>>   2 files changed, 2204 insertions(+)
>>   create mode 100644 tests/intel/xe_eudebug_online.c
> [...cut...]
> 
> Please use checkpatch.pl from linux kernel, watch out for
> whitespace errors, unbalanced braces '{/}' in if...else
> and few other problems.
> 
> A few useful options for checkpatch.pl are in CONTRIBUTE.md

Thanks, I will address these issues in the next revision.

Christoph

> 
> Regards,
> Kamil
>