From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [i-g-t 1/4] tests/kms_color: Add more logs to skips
Date: Tue, 13 Aug 2024 11:08:42 +0530 [thread overview]
Message-ID: <20240813053845.2567954-2-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240813053845.2567954-1-bhanuprakash.modem@intel.com>
Debugging would be easier if we had logs available for
test failures and skips. This patch adds print statements
at crucial points to provide better insights.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_color.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/tests/kms_color.c b/tests/kms_color.c
index 645a03537..5f0128bca 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -893,11 +893,18 @@ run_deep_color_tests_for_pipe(data_t *data, enum pipe p)
uint64_t max_bpc = get_max_bpc(output);
bool ret;
- if (!max_bpc)
+ if (!max_bpc) {
+ igt_info("Output %s: Doesn't support \"max bpc\" property.\n",
+ igt_output_name(output));
continue;
+ }
- if (!panel_supports_deep_color(data->drm_fd, output->name))
+ if (!panel_supports_deep_color(data->drm_fd, output->name)) {
+ igt_info("Output %s: Doesn't support deep-color.\n",
+ igt_output_name(output));
continue;
+ }
+
/*
* In intel driver, for MST streams pipe_bpp is
* restricted to 8bpc. So, deep-color >= 10bpc
@@ -905,16 +912,22 @@ run_deep_color_tests_for_pipe(data_t *data, enum pipe p)
* supports 10bpc. Once KMD FIXME, is resolved
* this MST constraint can be removed.
*/
- if (is_intel_device(data->drm_fd) && igt_check_output_is_dp_mst(output))
+ if (is_intel_device(data->drm_fd) && igt_check_output_is_dp_mst(output)) {
+ igt_info("Output %s: DP-MST doesn't support deep-color on Intel hardware.\n",
+ igt_output_name(output));
continue;
+ }
igt_display_reset(&data->display);
igt_output_set_prop_value(output, IGT_CONNECTOR_MAX_BPC, 10);
igt_output_set_pipe(output, p);
if (is_intel_device(data->drm_fd) &&
- !igt_max_bpc_constraint(&data->display, p, output, 10))
+ !igt_max_bpc_constraint(&data->display, p, output, 10)) {
+ igt_info("Output %s: Doesn't support 10-bpc.\n",
+ igt_output_name(output));
continue;
+ }
data->color_depth = 10;
data->drm_format = DRM_FORMAT_XRGB2101010;
--
2.43.2
next prev parent reply other threads:[~2024-08-13 5:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 5:38 [i-g-t 0/4] Add more logs to skips (KMS) Bhanuprakash Modem
2024-08-13 5:38 ` Bhanuprakash Modem [this message]
2024-08-21 5:23 ` [i-g-t 1/4] tests/kms_color: Add more logs to skips Samala, Pranay
2024-08-13 5:38 ` [i-g-t 2/4] tests/kms_dither: " Bhanuprakash Modem
2024-08-21 5:24 ` Samala, Pranay
2024-08-13 5:38 ` [i-g-t 3/4] tests/kms_vblank: " Bhanuprakash Modem
2024-08-21 5:50 ` Samala, Pranay
2024-08-13 5:38 ` [i-g-t 4/4] tests/kms_vrr: " Bhanuprakash Modem
2024-08-21 5:56 ` Samala, Pranay
2024-08-26 6:08 ` Samala, Pranay
2024-08-13 7:04 ` ✓ CI.xeBAT: success for Add more logs to skips (KMS) Patchwork
2024-08-13 7:21 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-13 8:58 ` ✗ CI.xeFULL: failure " Patchwork
2024-08-13 14:12 ` ✗ Fi.CI.IGT: " Patchwork
2024-08-21 7:14 ` ✓ CI.xeBAT: success for Add more logs to skips (KMS) (rev2) Patchwork
2024-08-21 7:35 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-21 8:43 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-08-21 9:54 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813053845.2567954-2-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox