Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [i-g-t 3/4] tests/kms_vblank: Add more logs to skips
Date: Tue, 13 Aug 2024 11:08:44 +0530	[thread overview]
Message-ID: <20240813053845.2567954-4-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240813053845.2567954-1-bhanuprakash.modem@intel.com>

Debugging would be easier if we had logs available for
test failures and skips. This patch adds print statements
at crucial points to provide better insights.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_vblank.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
index 696bc0b71..c53741b62 100644
--- a/tests/kms_vblank.c
+++ b/tests/kms_vblank.c
@@ -520,8 +520,10 @@ static void run_subtests(data_t *data)
 						continue;
 
 					if (!all_pipes && data->pipe != active_pipes[0] &&
-					    data->pipe != active_pipes[last_pipe])
+					    data->pipe != active_pipes[last_pipe]) {
+						igt_info("Skipping pipe %s\n", kmstest_pipe_name(data->pipe));
 						continue;
+					}
 
 					igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data->pipe), data->output->name) {
 						data->flags = m->flags | NOHANG;
@@ -544,8 +546,10 @@ static void run_subtests(data_t *data)
 						continue;
 
 					if (!all_pipes && data->pipe != active_pipes[0] &&
-					    data->pipe != active_pipes[last_pipe])
+					    data->pipe != active_pipes[last_pipe]) {
+						igt_info("Skipping pipe %s\n", kmstest_pipe_name(data->pipe));
 						continue;
+					}
 
 					igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data->pipe), data->output->name) {
 						data->flags = m->flags;
@@ -656,8 +660,10 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 				continue;
 
 			if (!all_pipes && data.pipe != active_pipes[0] &&
-					  data.pipe != active_pipes[last_pipe])
+					  data.pipe != active_pipes[last_pipe]) {
+				igt_info("Skipping pipe %s\n", kmstest_pipe_name(data.pipe));
 				continue;
+			}
 
 			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data.pipe), data.output->name)
 				crtc_id_subtest(&data, fd);
-- 
2.43.2


  parent reply	other threads:[~2024-08-13  5:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13  5:38 [i-g-t 0/4] Add more logs to skips (KMS) Bhanuprakash Modem
2024-08-13  5:38 ` [i-g-t 1/4] tests/kms_color: Add more logs to skips Bhanuprakash Modem
2024-08-21  5:23   ` Samala, Pranay
2024-08-13  5:38 ` [i-g-t 2/4] tests/kms_dither: " Bhanuprakash Modem
2024-08-21  5:24   ` Samala, Pranay
2024-08-13  5:38 ` Bhanuprakash Modem [this message]
2024-08-21  5:50   ` [i-g-t 3/4] tests/kms_vblank: " Samala, Pranay
2024-08-13  5:38 ` [i-g-t 4/4] tests/kms_vrr: " Bhanuprakash Modem
2024-08-21  5:56   ` Samala, Pranay
2024-08-26  6:08     ` Samala, Pranay
2024-08-13  7:04 ` ✓ CI.xeBAT: success for Add more logs to skips (KMS) Patchwork
2024-08-13  7:21 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-13  8:58 ` ✗ CI.xeFULL: failure " Patchwork
2024-08-13 14:12 ` ✗ Fi.CI.IGT: " Patchwork
2024-08-21  7:14 ` ✓ CI.xeBAT: success for Add more logs to skips (KMS) (rev2) Patchwork
2024-08-21  7:35 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-21  8:43 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-08-21  9:54 ` ✗ CI.xeFULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240813053845.2567954-4-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox