Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>
Subject: [PATCH 1/2] dumb_buffer: Remove invalid-bpp subtest
Date: Wed, 14 Aug 2024 11:54:25 -0700	[thread overview]
Message-ID: <20240814185426.70418-1-robdclark@gmail.com> (raw)

From: Rob Clark <robdclark@chromium.org>

These allocations are not necessarily invalid.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 tests/dumb_buffer.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/tests/dumb_buffer.c b/tests/dumb_buffer.c
index 1d4bf296c53e..579d2f906b6d 100644
--- a/tests/dumb_buffer.c
+++ b/tests/dumb_buffer.c
@@ -136,25 +136,6 @@ static void dumb_destroy(int fd, uint32_t handle)
 	igt_assert_eq(__dumb_destroy(fd, handle), 0);
 }
 
-static void invalid_dimensions_test(int fd)
-{
-	struct drm_mode_create_dumb create;
-
-	memset(&create, 0, sizeof(create));
-	create.width = 4032;
-	create.height = 2016;
-	create.bpp = 24;
-	igt_assert_eq(__dumb_create(fd, &create), -EINVAL);
-
-	create.bpp = 32;
-	create.width = 0;
-	igt_assert_eq(__dumb_create(fd, &create), -EINVAL);
-
-	create.width = 4032;
-	create.height = 0;
-	igt_assert_eq(__dumb_create(fd, &create), -EINVAL);
-}
-
 static void valid_dumb_creation_test(int fd)
 {
 	struct drm_mode_create_dumb create = {
@@ -397,9 +378,6 @@ igt_main
 		fd = drm_open_driver(DRIVER_ANY);
 	}
 
-	igt_subtest("invalid-bpp")
-		invalid_dimensions_test(fd);
-
 	igt_subtest("create-valid-dumb")
 		valid_dumb_creation_test(fd);
 
-- 
2.46.0


             reply	other threads:[~2024-08-14 18:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 18:54 Rob Clark [this message]
2024-08-14 18:54 ` [PATCH 2/2] device_reset: Require a PCI device Rob Clark
2024-08-19 17:09   ` Kamil Konieczny
2024-08-19 17:36   ` Kamil Konieczny
2024-08-19 18:51     ` Rob Clark
2024-08-20 10:07       ` Kamil Konieczny
2024-08-14 20:17 ` ✗ Fi.CI.BUILD: failure for series starting with [1/2] dumb_buffer: Remove invalid-bpp subtest Patchwork
2024-08-14 20:26 ` ✗ GitLab.Pipeline: warning " Patchwork
2024-08-19 17:16 ` [PATCH 1/2] " Kamil Konieczny
2024-08-19 18:25   ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814185426.70418-1-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=robdclark@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox