From: Rob Clark <robdclark@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>
Subject: [PATCH 2/2] device_reset: Require a PCI device
Date: Wed, 14 Aug 2024 11:54:26 -0700 [thread overview]
Message-ID: <20240814185426.70418-2-robdclark@gmail.com> (raw)
In-Reply-To: <20240814185426.70418-1-robdclark@gmail.com>
From: Rob Clark <robdclark@chromium.org>
Too much baked in assumptions that the drm device is a PCI device.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
tests/device_reset.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/device_reset.c b/tests/device_reset.c
index 8ed3ef5220fc..c49f94e2faed 100644
--- a/tests/device_reset.c
+++ b/tests/device_reset.c
@@ -200,6 +200,7 @@ static void init_device_fds(struct device_fds *dev)
igt_require_gem(dev->fds.dev);
igt_assert(device_sysfs_path(dev->fds.dev, dev_path));
+ igt_require(strstr(dev_path, "/sys/devices/pci") == dev_path);
addr_pos = strrchr(dev_path, '/');
igt_assert(addr_pos);
igt_assert_eq(sizeof(dev->dev_bus_addr) - 1,
--
2.46.0
next prev parent reply other threads:[~2024-08-14 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 18:54 [PATCH 1/2] dumb_buffer: Remove invalid-bpp subtest Rob Clark
2024-08-14 18:54 ` Rob Clark [this message]
2024-08-19 17:09 ` [PATCH 2/2] device_reset: Require a PCI device Kamil Konieczny
2024-08-19 17:36 ` Kamil Konieczny
2024-08-19 18:51 ` Rob Clark
2024-08-20 10:07 ` Kamil Konieczny
2024-08-14 20:17 ` ✗ Fi.CI.BUILD: failure for series starting with [1/2] dumb_buffer: Remove invalid-bpp subtest Patchwork
2024-08-14 20:26 ` ✗ GitLab.Pipeline: warning " Patchwork
2024-08-19 17:16 ` [PATCH 1/2] " Kamil Konieczny
2024-08-19 18:25 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814185426.70418-2-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=robdclark@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox