Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2] tests/kms_3d: Add more logs to skips/failure
@ 2024-08-28  4:33 Pranay Samala
  2024-08-28  5:14 ` ✗ CI.xeBAT: failure for tests/kms_3d: Add more logs to skips/failure (rev2) Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Pranay Samala @ 2024-08-28  4:33 UTC (permalink / raw)
  To: igt-dev; +Cc: jeevan.b, bhanuprakash.modem, sameer.lattannavar, pranay.samala

Having some logs for test failures and skips would
make debugging much easier.

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/kms_3d.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/tests/kms_3d.c b/tests/kms_3d.c
index ad6c45e9b..66c2ddfc1 100644
--- a/tests/kms_3d.c
+++ b/tests/kms_3d.c
@@ -55,7 +55,8 @@ igt_simple_main
 	res = drmModeGetResources(drm_fd);
 	igt_require(res);
 
-	igt_assert(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_STEREO_3D, 1) >= 0);
+	igt_assert_f(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_STEREO_3D, 1) >= 0,
+		     "Failed to enable STEREO_3D capability\n");
 
 	/* find an hdmi connector */
 	for (int i = 0; i < res->count_connectors; i++) {
@@ -65,7 +66,7 @@ igt_simple_main
 		drmModeFreeConnector(connector);
 		connector = NULL;
 	}
-	igt_require(connector);
+	igt_require_f(connector, "Unable to get HDMI Connector\n");
 
 	kmstest_unset_all_crtcs(drm_fd, res);
 
@@ -85,7 +86,7 @@ igt_simple_main
 			mode_count++;
 	}
 
-	igt_assert(mode_count);
+	igt_assert_f(mode_count, "3D modes not detected\n");
 
 	/* set 3D modes */
 	igt_info("Testing:\n");
@@ -95,8 +96,10 @@ igt_simple_main
 		int crtc_mask = -1;
 		int ret;
 
-		if (!(connector->modes[i].flags & DRM_MODE_FLAG_3D_MASK))
+		if (!(connector->modes[i].flags & DRM_MODE_FLAG_3D_MASK)) {
+			igt_info("%i: Doesn't support 3D MASK\n", res->connectors[i]);
 			continue;
+		}
 
 		/* create a configuration */
 		ret = kmstest_get_connector_config(drm_fd, connector_id,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-29  7:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-28  4:33 [PATCH i-g-t v2] tests/kms_3d: Add more logs to skips/failure Pranay Samala
2024-08-28  5:14 ` ✗ CI.xeBAT: failure for tests/kms_3d: Add more logs to skips/failure (rev2) Patchwork
2024-08-28  5:14 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-28  6:29 ` [PATCH i-g-t v2] tests/kms_3d: Add more logs to skips/failure Modem, Bhanuprakash
2024-08-28 11:46 ` ✗ CI.xeFULL: failure for tests/kms_3d: Add more logs to skips/failure (rev2) Patchwork
2024-08-29  7:47 ` ✓ Fi.CI.IGT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox